[Trigger] Computer Freezes

[annoying]

Hello people! Need help here!

When the following trigger runs in-game, my computer freezes, and I have to turn it off to get it working again.


I need help, what is wrong with it, and how do I make it work?

Edit: Don't mind reading more, it works now. Thank you for the help!

 

[Emm-A-]

i dont know whats wrong with it, but please change Triggering Player to Owner of Triggering Unit, because this is correct

 

[annoying]

Thank you, shall do that when I have access to the computer on which I have the map. But if anyone knows what causes the crash, in case it isn't the "Triggering Player" bit, please post it.

 

[Eccho]

Im just curious, what value is the 'Playernumber' having? I dont see you redeclaring it in your trigger.

 

[annoying]

Oh, sorry. It is the number of active players in the game. Other triggers control it, and it works as it should.

 

[Eccho]

Alright, then, the freeze is probably due to the massive amount of unit created on a location which leaks. Use a temppoint-variable to avoid leaking. Also, since you are creating N units, it returns 'last created unit group'. Avoid using 'Units in region' since it leaks another unit group, and you have this action 3 times, resulting to 3 unit groups and a huge amount of pointleaks.

• Untitled Trigger 001
  • Events
    • Unit - A unit enters region1
  • Conditions
    • ((Owner of (Triggering unit)) controller) Equal to User
  • Actions
    • Set temppoint = (Center of region1)
    • Game - Display to (All players) the text: ((Name of (Triggering player)) + has triggered the next wave!)
    • Unit - Create (Playernumber x 3) Skeleton Warrior for Player 12 (Brown) at temppoint facing Default building facing degrees
    • Custom script: call RemoveLocation( udg_temppoint )
    • Set temppoint = (Center of Section1Entry)
    • Unit Group - Order (Last created unit group) to Move To temppoint
    • Custom script: call RemoveLocation( udg_temppoint )

-------- As it goes for the waits, and same actions again, Im not sure why you do that. --------

 

[Anachron]

Ecco you failed, you just create 3 units on region 1 when 1 unit enters it, so you have an endless loop in it. So you create 3 units, each unit triggers the trigger so all create another 9 units on that location.

Simple Turn trigger off before all actions are done
and on after all actions have been done

 

[Eccho]

No I dont... I assumed that player brown is a computer player, thus the trigger will never be ran for a computer player (the condition check). And as it would be pretty simple to fix anyways...

And spell my name right next time please.

 

[Lord_BoNes]

• Actions
  • Disable trigger <this trigger>
  • ** Insert the rest of the actions **
  • Enable trigger <this trigger>

If the trigger is active when the units are created, then there's a chance that the newly created unit will activate the trigger again, causing an infinate (or close enough to it) loop that would make Wc3 lock up.

I'm pretty sure that this is what everyone else has been trying to say, I've just rapped it up.

 

[Eccho]

Meh.. you guys.. It is not really necessary. The condition forks fine. It will only be triggered if the entering unit it owned by a user player. Brown is assumingly a computer player...

 

[annoying]

Yes, Brown is a computer player. I got it working now, so there is no more need for this thread.

Thank you, everyone.