Code won't spawn units...

[TheSilverhand]

What's going on? I have the code set to set a location for a unit on spawn. But every time they're supposed to spawn they don't. I tried to test it out on another unit. and they work fine. but every time I try to see if this works. it doesn't? Did I mess up somewhere? If u can check the map itself and see if u can fix it. Let me know before, please.

If u can do it for me. I'll credit you for your work. If not, I'm sure I can solve it later.

 

[DoomBlade]

Well I made an empty map with trigger like this

• Y
  • Events
    • Time - Every 2.00 seconds of game time
  • Conditions
  • Actions
    • Unit - Create 1 (Random level 1 creep unit-type) for Player 1 (Red) at (Center of (Playable map area)) facing Default building facing degrees

So I'm guessing it's somewhere else in the code, since this runs properly.
I also made this trigger with position of unit and center of existing region and they all worked.

Maybe you could create a unit that it works with and then try replacing the unit with a random level 1 creep unit-type?

 

[Macadamia]

Yes I also tried to find the problem.

But your map is not a basic simple one, it is HUGE.
I mean It is really really nice.

I would love to help more but I stayed away from GUI for 18 years so it tends to make the triggers harder for me to read.

Also you use some libraries I am not yet familiar with.

But I like that map and I would love to see it work one day.

If you can't find the issue yourself, and when I will have finished fixing the couple of issues on my own map, I am willing to dig deeper and see if I can trace where the bug comes from, in case I could be of any help.

So far I see no obvious reasons : you have plenty of creeps in Neutral Hostile compatible with all tilesets, It should spawn.

Keep us updated if you stay stucked. And great job on the map by the way !

EDIT : try to add debugging actions where you suspect there could be a problem
For example, you could display the name or the type of the ZUnit[10] you just created on the screen.
If you put the display action just next to your unit creation itself, and if it doesn't display anything, it just means your trigger is not enabled/started properly.

 

[TheSilverhand]

Glad you like the map. Its purpose was to allow you to do more than defend. You can adventure and explorer the region and kill creeps if u wanted too. The Creeps have been lowered. Perhaps that might decrease desync. I might just go back to my other trigger that I had. Perhaps it's not worth trying to fix leaks for.

 

[Macadamia]

Oh trust me I did !
I felt a bit lonely without waves of creeps spawning so I tracked other creeps on the map, bought a few spells including endurance aura to level 5

I stopped because at some point for some reason my hero suddenly vanished when i was wandering near the south central gate.


Anyway it was very pleasant to play it.

I hadn't played since 2004, back then we only had basic DotAs, I even made my own attempt with many custom spells and whatever seemed like the hype by then, but it was boring in comparison.

I am not familiar with the recent evolutions of DotA maps, nor have I ever played the standalone version or things like Leagues of Legends, but I believe your map brings something to the table that makes it less "another dota-clone".

I'm not a great fan of GUI as I find it a bit messy and uneasy to work with, but I have to commend you for what you have done, this is really nice !

 

[TheSilverhand]

OH MY GOD I FOUND OUT WHAT'S WRONG HAHAHAHAHAHHA I have set RemoveUnit(udg_Zunit[1]) at the end of my triggers. HAHAHAHA time to fix that

 

[DoomBlade]

OH MY GOD I FOUND OUT WHAT'S WRONG HAHAHAHAHAHHA I have set RemoveUnit(udg_Zunit[1]) at the end of my triggers. HAHAHAHA time to fix that

Glad to hear that! well done.

 

[TheSilverhand]

The problem I have is that I lack item creation ideas. I want to make a full area of recipes. but the hard work is trying to find the right recipes and names for them.

 

[Macadamia]

OMG gratz on finding the bug on your own, hats off !!!

As for the items, don't rush yourself. So far the map seems really enjoyable. And maybe you don't need to spend days and days doing a similar item system as DotAs.

Keep the map as it is for now, try to track as many bugs as possible (like the one making heroes disappear), try your map a lot, optimize it slowly over the time until you feel really satisfied.

Then, if you still feel it is missing something, start writing down ideas on any kind of text editor until you find some that would be enjoyable to implement together.

So far you have made a great job with your spell shops. They are sorted in a sensible manner, And most of the improvements you could make are probably mostly cosmetic.


Please keep us updated, I would like to try your map again !

EDIT : In the long term, maybe consider learning Jass, it makes life so much easier as you can write clean code and manage potential leaks or desync issues directly. Not pushing you, if you're a GU addict, but just give it a think (or two ^^)

 

[DoomBlade]

Legendary/Ancient items

Alesdair, Ancient Staff
Damathes, Titans Helm
Elediah, Dagger of Ages
Rajmund, Unbreakable Shield
Korgulg, The Cleaver (Axe)
Sjoerd, Golden Armor
Agjold & Sveld (Sword Pair)

Items:

Staff of Time
Netherworld Staff
Ring of the Arch-magi
Assassin's Blade
Berserker's Gloves
Salvation
Rallying Banner
Urn of Souls/Magic/Death/Light/Darkness/XXX
Doom
Void
Blood Stone
Ancient Bow
Crown of Glory
Enchanted Shield
Light's Scepter/Scepter of Light
Staff of Wisdom
Valor
Blessed Armor
Furious Helm

Took some item names from an old ass map I made myself, feel free to use them.
If you liked the item names, feel free to ask for more!
I suck at coding, but my imagination is endless with stuff like this!

 

[TheSilverhand]

The thing about the recipes isn't just the item stats. I wanted to make all items have a special thing about them. Example A, All heroes have a special on level up. Mage restores mana to all allies, Enchantress resets all CDS on allies. etc.. I also want to expand and add more spells. but it's not easy. especially when you don't really know how to make the best spells.

Anyone is allowed to mess with my map. (Even though now with the new ToS, Everything made in the WE is the sole property of Blizzard.)

 

[Macadamia]

Seems like I'm not the only one who likes your map

OK I have good news. I went through my old files, and I found my old DotA-like I made in 2003 called Atlantis Beyond Icecrown
And guess what : this map was still made 80% with GUI Triggers.

Here is the unprotected version (don't worry I am the author ChrydGod was my (silly) mapmaker name back in the days.). It was never released to the public.

In that map i used a kind of item fusion system you could have a look at.

FYI the map works under reforged if you want to test it a bit.

You can borrow / use any of its content if you find anything interesting in it.

But as I said, take your time, your map doesn't feel empty with features so far !!!


EDIT : Don't worry too much about the TOS for now unless you'd want to remake the history of DotA, I doubt Blizzard is going to try to steal your work. They have a bad enough reputation today as it is

 

[TheSilverhand]

I appreciate it a lot. Anyone can mess with my map. It's been out for almost a year now. The problem with it is that I am trying to stitch up leaks. Which can take a while. The reason I was trying to set up triggers to spawn units that way is because I believe its anti-leak.

 

[Macadamia]

Well when it comes to leaks, Jass makes it really easy to solve.

But don't worry about that right now. Please polish other aspects of the map first.

I didn't know it had been out for a while as I only came back to WC3 in december.

If you are not in an emergency, I am willing to review your map for memory leaks when my current project will be finished (should be soon enough).


PS : If you had spawning triggers that worked better before, even if they leaked, put them back. Leaks should be easy and should not need to rewrite your entire spawn system..

 

[TheSilverhand]

My map has too many leaks. when people join and the game loads in. A random person is auto desynced. aka not letting them have fun. So I want to get rid of the leaks so people can play without worrying about getting kicked out during the loading screen.

 

[Macadamia]

Careful leaks and de-syncs are distinct issues.
A de sync occurs when a handle is created, destroyed or takes different values for different players. Some blizzard gui functions can cause desyncs as they were badly written, or more likely because they were not intended for multiplayer.

When I will be able to spend time on your map, I will be able to track both. Wish I could right now, but I am virtually working days and nights at the moment