Cloaking System with Events

[Wrda]

In the example Map Initialization event won't work, when adding units to the system. However, a 0s timer will be enough.
Either CloakingSystemAddUnit should add the ability 'abilcode' to the unit or the user has to manually add it, while at same time passing the ability id to the function. The instructions weren't very clear on this part. You can optimize CloakingSystemAddUnit function further by caching GetUnitUserData(u).
In CloakingSystemRemoveUnit, you can if BlzGroupGetSize(udg_cloaking_system_unitgroup) == 0 then instead CountUnitsInGroup, since it's faster and better because it doesn't loop through all units. Also, the timer should be destroyed (pause first).
In Cloaking System Periodic trigger, you can also use BlzGroupGetSize and cache Picked Unit too.

It does seem like a nice alternate approach to deal with the invisibility transition, although I like the standard one.

Very few things to be fixed, but some are quite important.

 

[KitsuneTailsPrower]

Updated based on feedback

 

[Wrda]

I might have not been when I said this:

Either CloakingSystemAddUnit should add the ability 'abilcode' to the unit or the user has to manually add it, while at same time passing the ability id to the function.

What I mean is that you have to choose: 1) use the function

UnitAddAbility(u, abilcode)

inside, to actually add the ability to the unit.
or 2) tell the user to add the ability manually (if the unit doesn't have yet) and then use the ability id in one of the arguments of the system's function.

I've come to realise dead units will have data attached to them that might not be removed, particularly the timer. I think it's worth to mention the remove function in instructions, even if it is somewhat obvious.

A bit of nitpicking, but no longer a reason for not being approved as this can be done swiftly.

Approved

 

[Spacebuns]

Why do I get "Failed to parse map data. The map is possibly corrupt or protected." when trying to Preview triggers?

 

[KitsuneTailsPrower]

Why do I get "Failed to parse map data. The map is possibly corrupt or protected." when trying to Preview triggers?

Not sure since the map isn't protected: Ask the hive staff.

 

[Pyrogasm]

I actually almost made a thread about that today. A lot of recent resources can’t have their triggers previewed, but older resources (mine for example) aren’t affected. So far not sure what exactly causes it.

 

[deepstrasz]

Why do I get "Failed to parse map data. The map is possibly corrupt or protected." when trying to Preview triggers?

1.31+ Maps "Preview Triggers"

I remember it was being discussed that the maps for 1.3.1+ used different trigger format, so the "Preview Trigger" function on hive would not work for them. Was just wondering if that is something that might come back. I know most people probably don't use it, but for me it is super helpful when...

www.hiveworkshop.com

 

[Daffa]

I actually almost made a thread about that today. A lot of recent resources can’t have their triggers previewed, but older resources (mine for example) aren’t affected. So far not sure what exactly causes it.

It seems there are changes to the trigger files that causes parsing for 1.35 to break. I recall 1.32 and 1.33 seems to parse correctly, but I need to double check those.