Chaoslaser v2 GUI and JASS (v1.10)

[Moderator]

19:59, 22nd Sep 2009
The_Reborn_Devil:

It's not compatible with 1.24 :/

 

[Dynasti]

Ok, I'm currently busy but not that busy that I can't comment.

SCREENSHOT FTW!

Going to test the spell later

 

[-Berz-]

Well, i was the firs one that downloaded this... IMO a bit to big green effects, but i like the "burst" looks sweet.

Maybe making it deal more damage and make more missiles, like a "half nova".

Triggering is fine.

Approved!

 

[Squiggy]

Uhm yeah.. damage-concerning issues don't count as it's easy as pie to edit the values ^^

 

[Mage_Goo]

ok, Squiggy, nice spell
but here's few bugs:
1. when i start channel it, then order unit to stops, then the ability still channeling and get started, without unit channeling it and the ability didn't go into cool down, and i can repeat it many times. maybe you can add trigger that check when unit is stops channeling.
2. when the beam 'throwed' (not the beam that released on impact, but when ability is started), the beam didn't deal any damage. maybe you ca adding it.
3. when 'beam' impact, it damages unit in square, make it on circle.

that's all. and you should tells that this spell need custom value on the dummy.
otherways, great spell.

 

[Dynasti]

that's all. and you should tells that this spell need custom value on the dummy..

Well, since the custom value only applies to the dummies it has nothing to say.

It would have been another thing if the casting unit's value was in use.

 

[Squiggy]

Mh.. I'll look over the first issue - but the second one doesn't seem right to me D:
I mean, the dummies have permanent immolation dealing 40 dmg in 150 AoE

 

[Mage_Goo]

hmm, sorry then. for second issue, i didn't see the dummy have the 'damage' ability.
for third issue, i miss-seeing the trigger, sorry, it damage unit in circle.

and for custom value, it's just for information, but i think it still can cause bug in some map that give every unit custom value for example. (well, it's very-very rare to see map like that)

just suggestion, but you can make damage more adjustable by adding it with trigger. because in trigger you can make damage more complex, like (level of ability x strength).
well, it just suggestion.

sorry for wrong issue.

 

[Squiggy]

Hmm.. maybe I'll edit it - but then I'd have to rewrite a huge part of the spell since I can't refer to (Triggering Unit) in the second trigger

//edit:
I just updated that one, fixed the challenge-issue by using a stun being applied to the casting unit - that way it gets a nice buff (This unit is charging his laser) *lulz*

And for the rectangular damaging, since there'd be a leak if I used a dynamically generated region, i'll leave it as it is..

 

[ZerO-]

Pretty good spell haven't seen many Laser-type spells around.
One pointer looks too green to me looks like the laser is going to turn into the Hulk or something haha . oh and perhaps you could up the damage as well

final rating 3.1/5

 

[Squiggy]

So i herd u like jass so i put a code in the code so you can approve while u approve D:

-> Update: Added the jass-version

 

[Deuterium]

Couldn't check the Jass version in-game... most probably 'cause I still use WC3 v1.21.

Umm, I didn't fully read the script but it looks well-done and well-structured.

Yet, you forgot to null the trigger local variable in the Init function.

And here's a better version of that:

Jass

    private function AntiLeaker takes nothing returns boolean
        return true
    endfunction
    
    private function SpellInit takes nothing returns nothing
        local trigger t = CreateTrigger()
        local filterfunc f = Filter(function AntiLeaker)
        local integer i = 0
        loop
            call TriggerRegisterPlayerUnitEvent(t, Player(i), EVENT_PLAYER_UNIT_SPELL_EFFECT, f)
            set i = i + 1
            exitwhen i == 16
        endloop
        call TriggerAddCondition(t, Condition(function Conditions))
        call TriggerAddAction(t, function Actions)
        set f = null
        set t = null
    endfunction

You'd be getting rid of 16 leaks using that filter, and having your whole script BJ free

 

[Kingz]

Several suggestions/questions:
1.Why do you use a double block for globals? I mean u have 3 global variables and 2 global blocks
2.nvm
3.You could have just used local reals x,y for GetUnitX(),GetUnitY() and avoid calling the GetUnitX(),GetUnitY() functions.
4.Add the constant integer variable for the unit you are creating, else the spell might not work after importing it.

    globals
        //...other globals  before this one...
        private constant integer Dummy1ID = 'n001'
        private constant integer Dummy2ID = 'n002'
    endglobals

All in all nice to see you are working in jass.
Much easier than GUI if you ask me, structs are too good

 

[Deuterium]

off-topic @ Kingz:
nahh I personally don't like vJass except for the globals block thing...
I just like the whole indexing thing in GUI, and I wouldn't mind using it in Jass (but I don't think I would )

 

[calex3]

off-topic
can you tell me where did you learned Jass....i want it too
i just want local variable functions....if oyu can give em some tutorial pls....tnx
....btw didn't check spells yet..
i will give you rep tomorrow... @You have given out too much Reputation in the last 24 hours, try again later!@

 

[Kingz]

@Everyone
Guys this is Squiggy's spell, if you got offtop stuff to tell me do it via VM.(visitor mesages for thos who don't know)

Btw Squiggy i tested this and it didn't work
The spell isn't MUI even with the structs and stuff...
I suggest you to try to find the source of this problem and consult with Hindyhat(cause you said he is your teacher) or someone else.

 

[Squiggy]

1.Why do you use a double block for globals? I mean u have 3 global variables and 2 global blocks

Now I've added more than two other constants.
Also, it's easier to modify if you don't have to bother about some globals and just change the constants

3.You could have just used local reals x,y for GetUnitX(),GetUnitY() and avoid calling the GetUnitX(),GetUnitY() functions.

Why should I use even more variables for just ONE use?

4.Add the constant integer variable for the unit you are creating, else the spell might not work after importing it.

Why should it?

can you tell me where did you learned Jass....i want it too

I'm given lessons from HINDYchat

And on a sidenote, the spell's mui again

 

[gunggang777]

Post the link for JNGP !

off-topic
can you tell me where did you learned Jass....i want it too
i just want local variable functions....if oyu can give em some tutorial pls....tnx
....btw didn't check spells yet..
i will give you rep tomorrow... @You have given out too much Reputation in the last 24 hours, try again later!@

off top

i learn with Thanthos
or you can test by your self download JNGP
and practice it's best tool for helping newbie.
you should ask pros if you have question :X
hmmm you shall begin(to make vJass) as simple spell, convert to text
remove bj declare global use variable remove leaks etc..
or you can PM me or thanthos
thx!

 

[Deuterium]

well, first there's the tutorial section, second there are alot of Jass spells to be checked, third you can start testing with converting from GUI to Jass...

 

[Kingz]

Gj Squiggy it's now MUI, jass and nice too.
Only thing that you really should do is to make the dummy ID's constant.
Ask HindyHat if you don't trust me, do that cause you will then make this spell much more user friendly.

 

[breebree123]

there is only one word i can say ."EPIC!".
yeah!

 

[Deuterium]

Only thing that you really should do is to make the dummy ID's constant.

Yupp usually Id's are constant.

 

[Squiggy]

Why would one want to change the model if he/she can just change the model of the existing dummy? D:

 

[Kingz]

I see you don't understand.
While improting your spell the ID of the DUMMY CHANGES therefore it should be in a constant value so users don't have to replace the ID's manualy inside the code.
There are SLIM chances that the ID of the dummy you are using will be same upon import.

 

[Squiggy]

There is only one instance per dummy unit, I don't think that would make much sense to set a constant integer :>

 

[Deuterium]

Nooo Squiggy you're not getting it

Umm, you created a new map, set the trigger and dummy, the dummy ID is 'h000'

I have a map which I've been working on for a year, I copy your triggers and your dummy, the dummy Id wouldn't be 'h000' but something more like 'h203'

Then the guy search your globals and he doesn't know where yo change it...
that's why you need to set a private constant integer in the globals for the dummy id

Got it now? =D

 

[Squiggy]

I DID get it, the dummies are only used ONCE, I don't set it to an integer <.<

 

[Deuterium]

ukhh Squiggy you can be stuborn sometimes
Well I won't argue anymore, but so that you get the idea:

globals
     private constant integer Dummy = 'n000'
endglobals

//in some function
call CreateUnit(bla bla, Dummy, bla bla...)

it's not a matter of how many times you use it, it's just a matter of the person not to have to search for the dummy in the script and just adjust it in the globals...

well it's your decision after all...

 

[Squiggy]

Oh yeah - one more thing.

There is no need to null the trigger

 

[Deuterium]

Umm, you sure? Coz if it's local (I can't remember if you used a local one or not), it's only local integers and reals shouldn't be nulled... (that's what I know )

 

[Kingz]

As i know there is no need to null triggers, as he only creates one and triggers don't leak anyway

 

[Dimetrixdemon]

oh i download it and test not so good