Chain System [SUMI] [ZINC] [V2.0]

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

Bribe:

Needs an in-game screenshot.

 

[Adiktuz]

Wow nice, and its in Zinc!!! been a long time since I last saw a zinc spell uploaded here... looks pretty cool too... ^_^

and oh, some of my systems have longer call functions... ^_^


question:

what will happen if we change the 200 thingy?

and why are some values hard-coded? like the 2 in this example
if (Chain[x].TickCount >= 2)

Suggestion:
Add interface methods especially one which runs upon getting hit by lightning so that we can easily add things like special buffs upon hit...

and make the texttags optional...

 

[baassee]

Why do you prefix the timer and the group? They're private.

Make a changeable constant for the "200" limit, should be changeable.

Why aren't attacktype, damagetype and weapontype in the function call?

Use SetWidgetLife instead of setunitstate, it's faster.

If the damage should be recognized as melee or range should also be two parameters.

doesn't this leak a texttag? I mean those texttag calls for lifespan are only used if the texttag boolean is true but the texttag is created no matter what

why do you even consider using local locations? use two static locations in the struct or two globals and move the locations instead

use GetWidgetLife

what if the user wants the hit effect to be created at the chest attachment of the target unit?

recycle groups, destroying them in vJASS/ZINC is just lame

create interface or take a function into the parameter when a unit is hit by a lightning (as Adiktuz said)

 

[Axarion]

The System looks nice, but it still needs some work. Yeah its easy to use, but I am missing much more customization options. What if the units hit shall get a buff instead of damage? Some sort of interface or function interfaces would be nice. Also you use FirstOfGroup(). So Heroes would get hit first always and then other units (which is good often), but what if the user wants to hit really randomly?

 

[baassee]

Then you have to use the BJ.

 

[Adiktuz]

if you would retain the FoG, I think its better to just transfer the actions inside a group enum filter which will be called here GroupEnumUnitsInRange(CS_GROUP, Chain[x].X, Chain[x].Y, Chain[x].Radius, GroupEnumFilterHere)... I guess its faster than calling FoG... not sure though...

 

[Raven0]

Thanks for your comments, i'll get around to fixing this stuff eventually.

I think i'll make two call functions, one that is very simple and has only 6 or so parameters and another that has full cutomization with 13 or 14 parameters.


______________________________________

what will happen if we change the 200 thingy

It changes the max instance amount, meaning that atm you can only have 200 chains active at one time on the map. I don't see why anybody would ever have more than 10 going at once, but i've still made it a global that people can modify in the next version as base suggested.

and why are some values hard-coded? like the 2 in this example

changed to a global in the next version along with an explanation of what it does.

Suggestion:
Add interface methods especially one which runs upon getting hit by lightning so that we can easily add things like special buffs upon hit...

working on it ^-^

and make the texttags optional...

They are optional, the last parameter sent in a boolean on whether or not to show texttags or not.

Why do you prefix the timer and the group? They're private.

Because otherwise they are just called "TIMER" and "GROUP" which annoys me personally as a coder.

Make a changeable constant for the "200" limit, should be changeable.

done ^-^

Why aren't attacktype, damagetype and weapontype in the function call?

made an alternative function call that includes these things

Use SetWidgetLife instead of setunitstate, it's faster.

done

If the damage should be recognized as melee or range should also be two parameters.

Also in the alternative function call

doesn't this leak a texttag? I mean those texttag calls for lifespan are only used if the texttag boolean is true but the texttag is created no matter what

my bad. fixed.

why do you even consider using local locations? use two static locations in the struct or two globals and move the locations instead

done ^-^

use GetWidgetLife

done ^-^

what if the user wants the hit effect to be created at the chest attachment of the target unit?

working on a way to fit this in

 

[PurgeandFire]

At the top of the code, you should add this:

    constant string LIGHTNING_CHAIN_LIGHTNING_PRIMARY   = "CLPB";
    constant string LIGHTNING_CHAIN_LIGHTNING_SECONDARY = "CLSB";
    constant string LIGHTNING_DRAIN                     = "DRAB";
    constant string LIGHTNING_DRAIN_LIFE                = "DRAL";
    constant string LIGHTNING_DRAIN_MANA                = "DRAM";
    constant string LIGHTNING_FINGER_OF_DEATH           = "AFOD";
    constant string LIGHTNING_FORKED_LIGHTNING          = "FORK";
    constant string LIGHTNING_HEALING_WAVE_PRIMARY      = "HWPB";
    constant string LIGHTNING_HEALING_WAVE_SECONDARY    = "HWSB";
    constant string LIGHTNING_LIGHTNING_ATTACK          = "CHIM";
    constant string LIGHTNING_MAGIC_LEASH               = "LEAS";
    constant string LIGHTNING_MANA_BURN                 = "MBUR";
    constant string LIGHTNING_MANA_FLARE                = "MFPB";
    constant string LIGHTNING_SPIRIT_LINK               = "SPLK";

As a reference because some people are either: a) too lazy to look them up, or b) don't know what the string is supposed to be.

Also, your group recycling is a bit overcomplicated. It can simply be:

//! zinc
library GroupRecycling
{
    group groups[];
    private integer index = 0;
    
    function ReleaseGroup(group g) -> nothing
    {
        GroupClear(g)
        groups[index] = g;
        index = index + 1;
    }
    
    function GetGroup() -> group
    {
        if (index == 0) { return CreateGroup(); }
        index = index - 1;
        return groups[index];
    }
}
//! endzinc

Which is the method used in this system:
http://www.thehelper.net/forums/showthread.php/136087-Recycle

 

[Raven0]

As a reference because some people are either: a) too lazy to look them up, or b) don't know what the string is supposed to be.

Good idea ^-^

Also, your group recycling is a bit overcomplicated. It can simply be:

I'll take a look at the differences. thanks

 

[Adiktuz]

I think the easier function call should use ATTACK_TYPE_SPELL and DAMAGE_TYPE_MAGIC instead of normal...

 

[baassee]

Or you use GroupUtils as the rest of us does ;D

 

[Raven0]

I think the easier function call should use ATTACK_TYPE_SPELL and DAMAGE_TYPE_MAGIC instead of normal...

The ones I used are the attacktype and damagetype that normal WC3 spells use. Although, you wouldn't know it from the variable names.

Or you use GroupUtils as the rest of us does ;D

I'll pry just do that.
________________________
Thanks for all your feedback

 

[Lambdadelta]

==================================================
--why use this over chain lightning/healing wave in object editor?--
==================================================

things you can do if you create your chain spells using this system that you couldn't if you use the object editor:

- change the damage/heal amount to anything at anytime.
- use any lightning types that you want
- show floating text that displays the amount damage/healed over each unit.
- apply custom stats you may have used in your map (such as spellpower or magic defense)

Things the object editor abilities allow you to do:

• the lightning follows the target correctly. This system only makes the lightning go to the unit's coordinates.
• the lightning stems from the casting unit. This one is just strange.

sdfsf

Everything be a mess, a giant mess! MESS. May I recommend you take a look at this? This is something people should be seeing instead of your current thing. O_O. O_O. O_O.

 

[Raven0]

Updated, please share what you think ^-^

 

[Bribe]

== true

Please get rid of those.

Seeing as how you use ExecuteFunc, this is not compatible with Vexorian's Map Optimizer. With the extremely long variable names you use, the Optimizer would come in very handy in order to 1. reduce map file size, 2. improve in-game speed (yes, long variable names slow down the game, it's unreal)

BoltPeriodic() iterates through a linear stack instead of a circularly linked-list, which slows down performance. Storing values into next/prev nodes is faster in every way.

GetNextAvailableChainIndex and GetNextAvailableBoltIndex use an O(N) search which is the world's slowest search. There are plenty of better indexing techniques than this, even Vexorian's struct-indexing technique.

Chains[index].destroy();

You're calling this from above the struct, meaning that destroy is called via a function interface instead of a proper call.