CAT (Custom attack type) system

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

01:27, 8th Jan 2015
IcemanBo:
https://www.hiveworkshop.com/threads/cat-custom-attack-type-system.259569/post-2637296

 

[Tal'Rarity]

You should fix those two potential bugs, otherwise cool idea and I really like the name you picked for it. meow =)

A proper damage detect system might be better even though I know your trying to do it before that. Unit is attacked isn't fun to work with due to the many bugs it can create.

 

[Callahan]

Unit attack is just my personal use in demo map because it was my original intent and it's easier to make demo effect that way I don't have to create a dummy ability.
You can make any event you want in the trigger.
It can be on ability cast or damage event if you use dd system.
I plan on making an update with possibility to kill unit at end of effect if people want to use dummy unit missile with this system.
And I will find a way to fix double powerslam bug.

 

[deathismyfriend]

Remove the and all condition block it is useless. It just slows the trigger down. The only time you need an and all block is inside an or all condition block.

Read the if condition and you will see that it says all conditions are true.

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • And - All (Conditions) are true
      • Conditions

This should be stored in a variable. (Level of Ghost (Visible) for CAT_Unit[CAT_CurrentIndex]) Greater than 0
What if the unit uses the spell then levels the ability ? It will then get the benefits of the increased level.

After reducing your max index counter you need to reduce the loop integer. Otherwise a spell index gets skipped whenever a spell is removed.

• Set CAT_MaxIndex = (CAT_MaxIndex - 1)

• Set CAT_CurrentIndex = (CAT_CurrentIndex - 1)

Never use Attacked unit use triggering unit instead. It is faster and more efficient.

This should be stored as it will be used more than once. (Owner of CAT_Unit[CAT_CurrentIndex]))
Also you should change this unit group and pick all units in range then sort through the units to remove. It will be more efficient, faster and easier to edit.

Hidden

• Unit Group - Remove all units of (Units within CAT_FinalAoeRadius[CAT_CurrentIndex] of CAT_LocOffset[CAT_CurrentIndex] matching ((((Matching unit) belongs to an ally of (Owner of CAT_Unit[CAT_CurrentIndex])) Equal to True) and ((Matching unit) Not equal to CAT_TargetUnit[CAT_CurrentIndex]))) from CAT_DamageGroup[CAT_CurrentIndex]

The same should be done with any unit group that uses more than one Matching unit calls.

 

[Callahan]

This should be stored in a variable. (Level of Ghost (Visible) for CAT_Unit[CAT_CurrentIndex]) Greater than 0
What if the unit uses the spell then levels the ability ? It will then get the benefits of the increased level.

I don't think I need to store Ghost (visible) in a variable.
Ghost (visible) is an ability that do nothing but remove unit collision.It doesn't appear in command UI and has no data and have no use of stats than can be modified.
It can be leveled only through trigger and won't benefit from level anyway.

if you want a unit that has ghost visible by default and use this system then just create a new ability from it and give the custom ability instead.

Also you should change this unit group and pick all units in range then sort through the units to remove. It will be more efficient, faster and easier to edit.

Hidden

• Unit Group - Remove all units of (Units within CAT_FinalAoeRadius[CAT_CurrentIndex] of CAT_LocOffset[CAT_CurrentIndex] matching ((((Matching unit) belongs to an ally of (Owner of CAT_Unit[CAT_CurrentIndex])) Equal to True) and ((Matching unit) Not equal to CAT_TargetUnit[CAT_CurrentIndex]))) from CAT_DamageGroup[CAT_CurrentIndex]

The same should be done with any unit group that uses more than one Matching unit calls.

And for group with matching condition this is what I do.
But in that case I remove friendly units but if you target your own unit it will not remove the targeted friendly unit.I have no choice but to have 2 matching condition.
This is not 2 matching unit to remove but one remove and one not to remove.
It's either that or remove all friendly then add back target if friendly which seem less efficient than remove all friendly but target.

 

[deathismyfriend]

I don't think I need to store Ghost (visible) in a variable.
Ghost (visible) is an ability that do nothing but remove unit collision.It doesn't appear in command UI and has no data and have no use of stats than can be modified.
It can be leveled only through trigger and won't benefit from level anyway.

if you want a unit that has ghost visible by default and use this system then just create a new ability from it and give the custom ability instead.

And for group with matching condition this is what I do.
But in that case I remove friendly units but if you target your own unit it will not remove the targeted friendly unit.I have no choice but to have 2 matching condition.
This is not 2 matching unit to remove but one remove and one not to remove.
It's either that or remove all friendly then add back target if friendly which seem less efficient than remove all friendly but target.

Can you quote or refer to what you are talking about. Nothing here makes sense or tells me what you are talking about.

 

[Callahan]

The post above.

 

[deathismyfriend]

The post above.

You should quote the items you are talking about. A lot of that can mean many different things in my above post.

 

[IcemanBo]

• There are like 20 triggers for your Demo. Seperate them from the system folder.
• Your config helper seems outdated. Type "circler" is never mentioned.
• The way you handle with add/remove crow form might bring unwanted results. Use this method: https://www.hiveworkshop.com/threads/how-give-unit-ability-fly.201936/post-1987015
• Filter "PickedUnit" instead of creating extra unit groups that will be removed from DamageGroup. It's highly inefficient.
• Why does IsBeingMovedGroup even exist?
• Your Assault-Type does use SetUnitX/Y natives without checking for WouldBounds or anything similar. It may lead to game crash.
• Only remove Ghost ability onDeindex if unit did not have it before.
• Unit/Target -loc don't need to be arrays.

I tested your demo, the attacks were pretty interesting.
The Blademaster did not always make his spin animation.
Some attacks stop orders for attacked unit, or temporary remove/disable it's attack. This may influence the game behaviour of enemies, not like normal wc3 attacks do.
I don't find it very easy for the user to use this system, but it might be interesting for some maps.

I don't really like all the code for all types is thrown together into one big mega loop that handles all kind of stuff with a large amount of linear checks.
An overhead is guaranteed for each iteration, multiple times. Maybe you should think of to split the types for a smarter handling. Even if this would mean extra loop, etc.

I can see you've put much effort into this system, but for now there are some points that need to be changed.

Needs Fix