Burning Eye by Klingo v1.03

[Moderator]

Hanky:
Leakless and MUI. Looks okay after updating. Approved!

Just as hint: You could improve the indexing.

 

[Klingo]

This is my First spell. I think it's MUI , it's leakless , bugless. Pls rate and comment.

 

[Kingz]

Please use hidden tags for the spell triggers.

 

[Klingo]

Please use hidden tags for the spell triggers.

how?

 

[Kingz]

Well like this:

[hidden="Spell triggers"]
trigger code should be pasted here
[/hidden]

 

[Dr Super Good]

Set BEGeyserPoint[BEIndex[2]] = (Position of BEGeyser[BEIndex[2]])

This leaks as it is run in a loop 10 times under BEIndex[2] being constant (not changing) and the asigned location is not removed until the end of the loop, resulting in 9 location leaks. Every handle you create must be destroyed if you no longer need it (or it no longer affects the game).

Why are you using static indicies so much (eg BEIndex[2]])... The whole point of arrays are to provide dynamic indicies so you defeat their purpose using static ones. Rather just use a normal variable in this situation as it is faster to reference (no offset finding required etc).

This system does not recycle indexes, it only just restricts their range to a seemingly random number.

Do you really run code every one second? What is the point of doing that if no spells are active, you tell me.

Obviously as it is GUI it leaks handle indicies and is not very efficent but you can not be blamed for that.

 

[Klingo]

I cleared the some of the leaks and i was wondering how i could close and open the periodic trigger to stay it Mui.

 

[Dr Super Good]

When destroying an instance, if that was the last active instance disable the timer / trigger. When making an instance if it is the only active instance (must be 0 before) thus enable the timer / trigger.

 

[X-OMG-X]

Yea Dr Super Good is always right

Btw, nice use of special effects.

 

[Klingo]

i'll try to fix that but later , i have shcool...


edit: I tried something that close the trigger when it's finish.

 

[gaby-boy]

Nice Job Klingo!