BotL Spells - Review

[Malhorne]

Okay let's go.
Start whenever you have spell to be reviewed.

 

[Paliouras]

Can we use it as another off topic thread?

 

[Malhorne]

Not at all.

 

[chobibo]

Ahaha XD
chobibo goes offtopic mode!

 

[Paliouras]

So chobibo what do you think of life?

 

[chobibo]

It's great, specially the girls. How about you?

 

[Malhorne]

Pls guys....

 

[chobibo]

Okay dude, Sorry about that

 

[Vinz]

Over photosshopped lips alert.

 

[chobibo]

It's not shopped dude. It's the most awesome lips you'll ever see.

 

[Vinz]

Your lips?
E: K Almighty Heathen(*) God

*According to Bernkastel.

 

[Malhorne]

Guys...

 

[T. D. W.]

okay, wait notice me when you make a BotL Discussion ... : p

firstly, moderating BotL is mainly my thing... xD but if you want to discuss further more, no prob

secondly, lol my lips here are not Photoshopped xD

thirdly, lol again, i only kiss 2 people lol (i don't like to kiss people mainly)

and finally, STOP off topic

 

[chobibo]

Hey, this is Malhorne's thread, why you going boss on us here?

 

[T. D. W.]

he said to stop OT... i'm enforcing the rules...

 

[chobibo]

Oh, okay. So this is your thread too...

 

[T. D. W.]

like you wish... it's related to BotL anyway

 

[chobibo]

I wish what? And you already said it's related to BotL so it is indeed your thread.

 

[T. D. W.]

Ok, w/e
I need to finish my homework :/

 

[Malhorne]

Ohoh guys come on stop that now....
It is the thread I started to moderating the coding since I though I was one of the best on this group to do it.
But if you don't think so just tell me and I'll not.

 

[chobibo]

Sorry about that Malhorne.

 

[Malhorne]

No problem at all.

 

[chobibo]

Can you review a spell I'm making dude?

 

[Malhorne]

I can make it surely
Maybe not this evening but tomorrow morning but hell yes !

 

[T. D. W.]

Dunno who are you talking with, but i will review any spell

 

[chobibo]

Haha, okay I got scared. haha xD

 

[Malhorne]

If you're post on PM.
I'll only review the code atm.

 

[chobibo]

I haven't finished it yet, I'll pm both of you when I'm done. Don't worry it will be simple, it's not a serious one, just a spell I made for fun haha.

 

[Malhorne]

Ok no problem

 

[chobibo]

Powerful spell capable of killing the caster.

vjass spell

scope TrollYah initializer onInit

    globals
        
        private constant integer    ABILITY_ID      =   'AOwk'
        private constant string     EFFECT          =   "Abilities\\Spells\\Orc\\WarStomp\\WarStompCaster.mdl"
        
    endglobals
    
    private function core takes nothing returns boolean
        local unit c=GetTriggerUnit()
        
        if (GetSpellAbilityId()==ABILITY_ID) then
        call AddSpecialEffect(EFFECT,GetUnitX(c),GetUnitY(c))
        call KillUnit(c)
        endif
        
        set c=null
        return false
    endfunction
    
    private function onInit takes nothing returns nothing
        local trigger t=CreateTrigger()
        call TriggerRegisterAnyUnitEventBJ(t,EVENT_PLAYER_UNIT_SPELL_EFFECT)
        call TriggerAddCondition(t,Filter(function core))
        // I will not set t to null, this ain't gonna be destroyed anyways.
    endfunction

endscope

 

[Malhorne]

I would like it better like this :

scope TrollYah initializer onInit

    globals
        
        private constant integer    ABILITY_ID      =   'AOwk'
        private constant string     EFFECT          =   "Abilities\\Spells\\Orc\\WarStomp\\WarStompCaster.mdl"
        
    endglobals
    
    private function core takes nothing returns boolean
        local unit c
        
        if (GetSpellAbilityId()==ABILITY_ID) then
            set c = GetTriggerUnit()
            call AddSpecialEffect(EFFECT,GetUnitX(c),GetUnitY(c))
            //What about the effect ?
            //Why not :
            // call DestroyEffect(AddSpecialEffect(EFFECT,GetUnitX(c),GetUnitY(c)))
            call KillUnit(c)
            set c = null
        endif
        return false
    endfunction
    
    private function onInit takes nothing returns nothing
        local trigger t=CreateTrigger()
        call TriggerRegisterAnyUnitEventBJ(t,EVENT_PLAYER_UNIT_SPELL_EFFECT)
        call TriggerAddCondition(t,Filter(function core))
        // I will not set t to null, this ain't gonna be destroyed anyways.
    endfunction
endscope

 

[Vinz]

Why ..

 

[Malhorne]

What why ?

 

[chobibo]

No, I intended not to remove the effect. Lag would make the user think "hell, a lot of things must be going on the background when I cast this spell..."

 

[Malhorne]

So you want it to stay there forever ?
I don't know if it repeats ^^

 

[chobibo]

Oh alright, going to fix that...

scope TrollYah initializer onInit

    globals
        
        private constant integer    ABILITY_ID      =   'AOwk'
        private constant string     EFFECT          =   "Abilities\\Spells\\Orc\\WarStomp\\WarStompCaster.mdl"
        
    endglobals
    
    private function core takes nothing returns boolean
        local unit c=GetTriggerUnit()
        
        if (GetSpellAbilityId()==ABILITY_ID) then
        // credits to Malhorne for making me remove the effect...
        call DestroyEffect(AddSpecialEffect(EFFECT,GetUnitX(c),GetUnitY(c)))
        call KillUnit(c)
        endif
        
        set c=null
        return false
    endfunction
    
    private function onInit takes nothing returns nothing
        local trigger t=CreateTrigger()
        call TriggerRegisterAnyUnitEventBJ(t,EVENT_PLAYER_UNIT_SPELL_EFFECT)
        call TriggerAddCondition(t,Filter(function core))
        // I will not set t to null, this ain't gonna be destroyed anyways.
    endfunction

endscope

 

[Malhorne]

Why don't you indent your if block ?
Why not setting the var c into the if block and the null of c into the block too ? -> It leads to less operations when it's not the good id.

 

[Vinz]

Why make a skill that kills the caster. :<

 

[chobibo]

Okay will do!

scope TrollYah initializer onInit

    globals
        
        private constant integer    ABILITY_ID      =   'AOwk'
        private constant string     EFFECT          =   "Abilities\\Spells\\Orc\\WarStomp\\WarStompCaster.mdl"
        
    endglobals
    
    private function core takes nothing returns boolean
        local unit c
        
        // Credits to Malhorne, for overall optimization
        if (GetSpellAbilityId()==ABILITY_ID) then
            set c=GetTriggerUnit()
            call DestroyEffect(AddSpecialEffect(EFFECT,GetUnitX(c),GetUnitY(c)))
            call KillUnit(c)
            set c=null
        endif
        
        return false
    endfunction
    
    private function onInit takes nothing returns nothing
        local trigger t=CreateTrigger()
        call TriggerRegisterAnyUnitEventBJ(t,EVENT_PLAYER_UNIT_SPELL_EFFECT)
        call TriggerAddCondition(t,Filter(function core))
        // I will not set t to null, this ain't gonna be destroyed anyways.
    endfunction

endscope

 

[Malhorne]

Okay now I'm going out to see some cinemas art
See ya tomorrow (I have class only from 3h30pm to 5h30pm GMT+1 tomorrow)

 

[chobibo]

Approved? the spell?
@Wrathion: It's for a troll map I'm making for Paliouras.

 

[Vinz]

Ahh okay. Wait. You're making a map for Paliouras. What kind of map?

 

[chobibo]

Mindless Slaughter™, a map where you don't get to buy items, you just kill swarms of enemy units, that spell over there is the suicide skill. It ends the game, coz you can't die normally, since your hero will have 'Avul'.

 

[T. D. W.]

Spell approved!
1/5 lol lacking!
Just kidding xD

 

[chobibo]

Haha, 1/5 is appropriate.

 

[T. D. W.]

Oh well lol

 

[Paliouras]

I am here ya know

 

[T. D. W.]

We kno yeah

 

[Malhorne]

Oh sorry to be a bit dephased xD
I forgot to told you this chobibo :

scope TrollYah initializer onInit

    globals
        
        private constant integer    ABILITY_ID      =   'AOwk'
        private constant string     EFFECT          =   "Abilities\\Spells\\Orc\\WarStomp\\WarStompCaster.mdl"
        
    endglobals
    
    private function core takes nothing returns boolean
        local unit c
        
        // Credits to Malhorne, for overall optimization
        if (GetSpellAbilityId()==ABILITY_ID) then
            set c=GetTriggerUnit()
            call DestroyEffect(AddSpecialEffect(EFFECT,GetUnitX(c),GetUnitY(c)))
            call KillUnit(c)
            set c=null
        endif
        
        return false
    endfunction
    
    private function onInit takes nothing returns nothing
        local trigger t=CreateTrigger()
        call TriggerRegisterAnyUnitEventBJ(t,EVENT_PLAYER_UNIT_SPELL_EFFECT)
        call TriggerAddCondition(t,Filter(function core))
        //Preloading effects to avoid lags :)
        call Preload(EFFECT)
        // I will not set t to null, this ain't gonna be destroyed anyways.
    endfunction

endscope

 

[chobibo]

Why thank you! have some melons.