Blizz-Like Melee Settings For Extra Races 2.5

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

10 Aug 2012
Magtheridon96:

We have come to the conclusion that this will be approved.
First, you have to get rid of /all/ the BJs.
It's a huge improvement.

For example, call PickMeleeAI(indexPlayer, udg_AM_AI_FilePath[indexRace], null, null)
runs about 10 lines of code, but it could simply be replaced with 1 line:
call StartMeleeAI(indexPlayer, udg_AM_AI_FilePath[indexRace])

Getting rid of the BJs will allow you to produce cleaner and faster code.

The function that gets the nearest gold mine can be replaced with a FirstOfGroup loop enum.

You would call GroupEnumUnitsInRange(enumGroup, x, y, 2000, null)
And loop over all the units like this:

loop
    set tempUnit = FirstOfGroup(enumGroup)
    exitwhen tempUnit == null
    call GroupRemoveUnit(enumGroup, tempUnit)

    if GetUnitTypeId(tempUnit) == 'ngol' then
        // do actions here.
        // you would just get the distance and check if it's less
        // than the current distance you stored. If so, set the 
        // nearestMine variable to tempUnit.
    endif
endloop
// At this point, nearestMine will be equal to the nearest 
// mine.

There are so many things you could do to improve this.

Old reviews

12 Nov
Bribe: I don't like that this resource is 99% copied code from Blizzard.j.

To me this would be better as a tutorial, since it's not very configurable in its current state either.

I don't think any amount of work you put into this is going to make me feel good about approving it. I don't get the feeling like this is an appropriate resource for us, and it is a difficult decision for me to decide what to do with it.

edit
8th of August 2012
Magtheridon96:

As Bribe said, I also do not know whether this should be approved or not, but for the time being, it would be better to improve it.
First, you can get rid of the remaining BJs.

edit
Also, merge lines like this:

local integer index
set index = 1

->
local integer index = 1

 

[x3GlikE]

Test...now

The idea is very good, Allows the user to easily create new races and mess around with the old ones.
Haven't checked triggering yet.

 

[gthkeno]

at first when i saw this i though you just changed the units like instead of peons you got grunts, but once i clicked on it I understood. change the title to something else, you might get more hits. downloading.....

 

[Adiktuz]

does the basic AI work for this or you need to make custom AI for the custom races?

 

[GIANT_CRAB]

Use boolean comparison, instead of integer, its gonna make ur life easier using it.

 

[VeljkoM]

Custom Ai is needed for custom races.

And yea I just love this thing. Wish it was on third race contests tho.

 

[PB_L]

Heroes don't have tp

 

[Mephestrial]

Use boolean comparison, instead of integer, its gonna make ur life easier using it.

For what parts?

Heroes don't have tp

tp?

tp = scroll of teleportation, the very first hero of each race always gets it...

I can't believe it. I accidently deleted

• Melee Game - Give trained Heroes a Scroll of Town Portal (for all players)

when I modified melee initialization.

 

[naitsirk]

tp = scroll of teleportation, the very first hero of each race always gets it...

 

[ADVRipper]

Thanks. I like it. I created a lot of custom races, but i don't know anything about triggers. So, i always had to change the player slot to change the race.

But why only 8 races?

There are Humans, Orcs, Undead, Night Elf, and 4 more races.

That's not enough, at least for me.

I have 16 custom races, and want to make more 4.

One other problem:

The first hero is free, but only the first altar hero has supposed to be free. Not the first Tavern hero.

 

[ADVRipper]

Custom Races.

"You can have as many races as you can fit in a dialog box. You just need to create a dialog button for each new race and give it a numeric value. Then you need to set that race's variables like the other races have done for them and finally set the NumOfRaces variable to the number of races that you have."

Mephestrial,

You are right. I don't know what i did wrong before, But anyway, i deleted the new custom races triggers, and create them again. Now it works.

I don't know how to make the 13th, 14th, 15th ... races to work.

When i select them in the beginning, nothing happens.

13th option is Random now.



"Also even with pure melee triggers a tavern hero can be free if it is your first hero. "


You are right again! I could swear that the first Tavern hero has not free. But i checked again in Normal Melee Game, and indeed the first Tavern hero is free, if you didn't get any altar hero.

I'm sure that in the past it was not free, but with all the updates we automatically download when we go to Battle.net, this was probably changed and i didn't notice.


I don't know if it's possible to create a "Next >>" option to go to another page with more races to choose.

But, thanks a lot for these triggers. I always dreamed to have a "Custom Race" selection system. Man, i don't know how to thank you.

 

[ADVRipper]

One small bug.

I found another problem.

Set HallEntanglesGoldmine = True

Don't work.

The Tree of Life always starts too far away from the Gold Mine to entangle it.


Please, let me know when you update the triggers.

 

[ADVRipper]

It's working.

"I found another problem.

Set HallEntanglesGoldmine = True

Don't work."



Sorry. I forgot to do that:

Set UnitType_Goldmine = Entangled Gold Mine

It's perfect. Too bad there is a 12 races limit.

 

[Bribe]

Lots of memory leaks in the custom script code (MeleeStartingUnitsCustom especially), lot of "ConvertedPlayerId" bj's shows very little thought was applied into the custom scripts.

This needs a lot of work. The GUI side of things sees a lot of problems.

RacesDialogClickDetection - this needs to take advantage of the else-actions.

And - All (Conditions) are true

- This line is not needed. Conditions automatically check if all are true. In fact, that whole statement should just be removed and put as an "else" action, because you do not need to re-check what the value is that way.

CreateAlteredMeleeStartingUnits - horrendous. What is it even doing? There is a lot of bad structure found her, especially concerning the waits.

 

[Bribe]

"noobs who can't see pattern" is no reason to write really redundant code that does nothing and even slows things down. If what you did was intentional, what you did is worse than adding a "Do nothing" action.

 

[Adiktuz]

GetConvertedPlayerId(indexPlayer)

is the same as

GetPlayerId(player) + 1

 

[Marcos DAB]

Custom Ai is needed for custom races.

And yea I just love this thing. Wish it was on third race contests tho.

I agree completely

 

[SpectreD]

Wow this could be very useful, i use to want to be able to make custom races and now i can 5/5

 

[ZXander_Stealth]

I having problem when I import the triggers into my map...
call AlteredMeleeStartingUnits()
call AlteredMeleeInitVictoryDefeat()

both of these made my map can not be saved...
What is the problem?
Can anyone help?


Edit..
The map can be saved but have message about the trigger error...

 

[Adiktuz]

are you sure you copied the whole custom script into the map header?

 

[ZXander_Stealth]

I did not see custom script..

 

[Adiktuz]

what? look at the first page, the code at the very first hidden tag... I think it was on the map header on his demo map, that's why you didn't saw it...

 

[ZXander_Stealth]

I found it.. Thanks...


Edit: By the way, how do I import the code into my map? Just select all text and copy?

 

[Adiktuz]

yeah, just copy it, open your trigger editor and paste it into the map header...

 

[Maximum_Evil]

Very usefull, great job!

 

[jsmoove]

This has been great. I've been away from WC3 modding for 16 years. I always wanted to "fix" the races (remove the blood elves from the alliance for example) and add a few more that were lore correct. This is allowing me and my friends to do just that. Thank you for posting. It has allowed me to revisit this project I abandoned 16 years ago.

 

[Harold Grey]

This is very useful! However, to those looking specifically to setup to allow all buildings labeled as town halls to be accounted for in the crippling/uncrippling messages, see this post/thread. It is easier than trying to extract the relevant parts from Mephestrial's good work.