[JASS] bj_lastCreatedUnit vs GetLastCreatedUnit()

[emperor_d3st]

Hi.
Using bj_lastCreatedUnit seems totally logical to me, but I see a lot of users using the GetLastCreatedUnit() instead. Is there a reason for that or they just simply make a mistake?

Another question is:
Do the bj_lastCreatedUnit and its counterparts (e.g.: bj_lastCreatedTimerDialog, etc) leak in BJs? Just because some BJs I checked do not clear the bj_lastWhatevers.

For example:

function CreateUnitAtLocSaveLast takes player id, integer unitid, location loc, real face returns unit
    if (unitid == 'ugol') then
        set bj_lastCreatedUnit = CreateBlightedGoldmine(id, GetLocationX(loc), GetLocationY(loc), face)
    else
        set bj_lastCreatedUnit = CreateUnitAtLoc(id, unitid, loc, face)
    endif

    return bj_lastCreatedUnit
endfunction

Thanks for the help.

 

[moyackx]

The reason that some users use the GetLastCreatedUnit() is because they are noobs and don't know that this function actually do this:

function GetLastCreatedUnit takes nothing returns unit
    return bj_lastCreatedUnit // <= Doh!!!
endfunction

About your second question.... it would be nice to apply a good programming practice that is setting to null your variables before assigning a new value. To be clear: a variable will leak if and only if it's created and is not destroyed after being used.

 

[PurplePoot]

Using bj_lastCreatedUnit seems totally logical to me, but I see a lot of users using the GetLastCreatedUnit() instead. Is there a reason for that or they just simply make a mistake?

Converted GUI, or newbs as Moyack said.

Another question is:
Do the bj_lastCreatedUnit and its counterparts (e.g.: bj_lastCreatedTimerDialog, etc) leak in BJs? Just because some BJs I checked do not clear the bj_lastWhatevers.

That makes no sense, seeing as the bj variables are globals.

 

[emperor_d3st]

All right, thanks for clearing things up for me. (I have to spread some reputation around to give PurplePoot again)

 

[Captain Griffen]

Using GetLastCreatedUnit() or bj_lastCreatedUnit is just silly; I've never done it in JASS, and now cheap globals in vJASS makes it pretty much entirely defunct.

 

[emperor_d3st]

Well, I'm yet to learn about vJass, HandleVars and Structs on a level to be able to use them with confidence. Looks like I should, but until then it's good to know that bj_something > GetLastSomething.

 

[Earth-Fury]

no, really, defining global variables is quite possibly the simplest thing you can do... (its not even vJASS, all JASS Helper does is merge all global blocks in to a single one, as scripts are only supposed to have a single globals block.) It's even simpler than using the stupid ass GUI variable editor:

globals
    // Syntax:
    [constant] <type> [array] <name> [= <value>]
    // Examples:
    constant real TIMER_TIMEOUT = 1 // the value of a constant can not be changed.
    integer PeonCount = 0 // a normal global which starts with a 0 value
    timer SpellTimer // Uninitialized. You must set a value to this variable before using it.
    unit array PlayerHeroes // You can not "= value" on an array.
endglobals

Note that initializing variables to some function will crash the game before it even finishes loading your map. don't do things like:

globals
    unit Me = CreateUnit(...)
endglobals

 

[emperor_d3st]

Okay, thanks. But I don't understand why is this simpler than

set bj_lastCreatedUnit = CreateUnit(...)