Auto Save System Issue.

[C.B.King]

solved

 

[Uncle]

SaveMaxValue should be equal to the highest value possible for that given thing. For example, if you have 10 savable items in the game, and their values range from 1 to 10, then the SaveMaxValue for that should be 10.

Also, why did you redesign the AutoSave trigger to work like that? All of the variables inside use the Player number of SaveLoadEvent_Player, so there's no reason to have any redundancy. You can Pick through every player, Set them as SaveLoadEvent_Player, and Run the save trigger.

• Loop - Actions
• Set Variable SaveLoadEvent_Player = (Picked player)
• Trigger - Run AutoSave (ignoring conditions)

I recommend using a Player Group that only contains active USERS and not computers/leavers.

Anyway, this Save/Load system seems to have issues all of the time. It just doesn't want to play nice and there's a limit to how much you can save.

 

[C.B.King]

SaveMaxValue should be equal to the highest value possible for that given thing. For example, if you have 10 savable items in the game, and their values range from 1 to 10, then the SaveMaxValue for that should be 10.

Also, why did you redesign the AutoSave trigger to work like that? All of the variables inside use the Player number of SaveLoadEvent_Player, so there's no reason to have any redundancy. You can Pick through every player, Set them as SaveLoadEvent_Player, and Run this trigger.

• Loop - Actions
• Set Variable SaveLoadEvent_Player = (Picked player)
• Trigger - Run AutoSave (ignoring conditions)

I recommend using a Player Group that only contains active USERS and not computers/leavers.

Anyway, this Save/Load system seems to have issues all of the time. It just doesn't want to play nice and there's a limit to how much you can save.

the Auto save runs through another trigger, so how it works, it wont work as triggering player id, so have to set the id, and then save, but to save for all players, so to set it per player it saving.

 

[Uncle]

I think you're misunderstanding a lot of things going on here. SaveMaxValue should not be 100000 for everything, because most things won't even come close to that value. It's not the SaveCount that it's the max value of, it's the thing that you're saving (Skins, Items, Kills, Gold, etc). Also, you should only have one Save trigger and it needs to contain every value that you want to Save. You can't split the Saves up into different sections and Save some stuff now and some stuff later. It's either ALL or nothing.

And you can ALWAYS get access to the Active Players and their Player Numbers. There's never a time that you cannot do this. You just have to use a Pick Every Player action and Set SaveLoadEvent_Player = (Picked player), then run AutoSave.

You shouldn't be checking the Player slot status of your players every single time you run Calculate. At the start of the game you want to Add all of the active Users to a Player Group. Then when a Player leaves the game you remove them from said Player Group. The result will be a Player Group that gives you access to all of the active users at any given moment.

• Set Active Players
  • Events
    • Time - Elapsed game time is 0.50 seconds
  • Conditions
  • Actions
    • Set VariableSet ActivePlayers = (All players matching ((((Matching player) slot status) Equal to Is playing) and (((Matching player) controller) Equal to User)).)

• Player Leaves
  • Events
    • Player - Player 1 (Red) leaves the game
    • Player - Player 2 (Blue) leaves the game
    • Player - Player 3 (Teal) leaves the game
  • Conditions
  • Actions
    • Player Group - Remove (Triggering player) from ActivePlayers.

Now you can save all active players whenever you want using these actions:

• Actions
  • Player Group - Pick every player in ActivePlayers and do (Actions)
    • Loop - Actions
      • Set VariableSet SaveLoadEvent_Player = (Picked player)
      • Trigger - Run AutoSave <gen> (ignoring conditions)

Or if you want to save a specific player, skip the Pick Every Player action and reference them directly.

You're making things WAY harder on yourself by not using the Pick Every Player action. You should be using Pick Every Player in ActivePlayers in most if not all of your triggers that reference more than 1 Player at a time. You should rarely need to reference a specific player. That's the beauty of an Array and this Player Number design, one Action can work for ALL of your players.

When you run into situations where one Array [Index] isn't good enough because you need Variables like these:

• Set Variable PlayerItem1[X] = Some value
• Set Variable PlayerItem2[X] = Some value
• Set Variable PlayerItem3[X] = Some value

You can use Hashtables which act almost like 2 dimensional Arrays, IE:

• Set Variable PlayerItem[X][Y] = Some value

I recommend taking a look into them.

 

[C.B.King]

I think you're misunderstanding a lot of things going on here. SaveMaxValue should not be 100000 for everything, because most things won't even come close to that value. It's not the SaveCount that it's the max value of, it's the thing that you're saving (Skins, Items, Kills, Gold, etc). Also, you should have only one Save trigger and it needs to contain every value that you want to Save. You can't split the Saves up into different sections and Save some stuff now and some stuff later. It's either ALL or nothing.

You can ALWAYS get access to the Active Players and their Player Numbers. There's never a time that you cannot do this. You just have to use a Pick Every Player action and Set SaveLoadEvent_Player = (Picked player), then run AutoSave.

You shouldn't be checking the Player slot status of your players every single time you run Calculate. At the start of the game you want to Add all of the active Users to a Player Group. Then when a Player leaves the game you remove them from said Player Group. The result will be a Player Group that gives you access to all of the active users at any given moment.

• Set Active Players
  • Events
    • Time - Elapsed game time is 0.50 seconds
  • Conditions
  • Actions
    • Set VariableSet ActivePlayers = (All players matching ((((Matching player) slot status) Equal to Is playing) and (((Matching player) controller) Equal to User)).)

• Player Leaves
  • Events
    • Player - Player 1 (Red) leaves the game
    • Player - Player 2 (Blue) leaves the game
    • Player - Player 3 (Teal) leaves the game
  • Conditions
  • Actions
    • Player Group - Remove (Triggering player) from ActivePlayers.

Now you can save all active players whenever you want using these actions:

• Actions
  • Player Group - Pick every player in ActivePlayers and do (Actions)
    • Loop - Actions
      • Set VariableSet SaveLoadEvent_Player = (Picked player)
      • Trigger - Run AutoSave <gen> (ignoring conditions)

Or if you want to save a specific player, skip the Pick Every Player action and reference them directly.

You're making things WAY harder on yourself by not using the Pick Every Player action. You should be using Pick Every Player in ActivePlayers in most if not all of your triggers that reference more than 1 Player at a time. You should rarely need to reference a specific player. That's the beauty of an Array and this Player Number design, one Action can work for ALL of your players.

When you run into situations where one Array [Index] isn't good enough because you need Variables like these:

• Set Variable PlayerItem1[X] = Some value
• Set Variable PlayerItem2[X] = Some value
• Set Variable PlayerItem3[X] = Some value

You can use Hashtables which enable you much greater control. I recommend taking a look into them.

yeah making it harder on my self than it has to be, makes sense, anywho i did set the item and skin int max to 1, but it then gives u 100000 score for some reason when u load

 

[Uncle]

yeah making it harder on my self than it has to be, makes sense, anywho i did set the item and skin int max to 1, but it then gives u 100000 score for some reason when u load

Why would their Max value be 1? There's certainly more than 1 Skin and more than 1 Item. The Max value is a limit to how much of that thing you can save, so if you Set the Max value of Gold to 5000, then the player can only save up to 5000 gold. Even if the player had 99999 Gold, the system would only allow them to Save 5000.

I think you're still misunderstanding how this stuff works. It took me a while to wrap my head around it all but eventually I got it. I'm sure if you keep trying you'll eventually get it working as well. Keep in mind that this Save and Load system has caused many headaches before, I've helped many people use it and they seem to always have issues. It could be a Reforged thing, maybe it used to work properly in the older versions.

 

[C.B.King]

Why would their Max value be 1? There's certainly more than 1 Skin and more than 1 Item. The Max value is a limit to how much of that thing you can save, so if you Set the Max value of Gold to 5000, then the player can only save up to 5000 gold. Even if the player had 99999 Gold, the system would only allow them to Save 5000.

I think you're still misunderstanding how this stuff works. It took me a while to wrap my head around it all but eventually I got it. I'm sure if you keep trying you'll eventually get it working as well. Keep in mind that this Save and Load system has caused many headaches before, I've helped many people use it before and they seem to always have issues. It could be a Reforged thing, maybe it used to work properly in older versions.

as theres 10 different skins, all different intergers, and u can only unlock skin once therefore max u be getting is 1

basically if u unlock a skin, it sets ur skin int to 1, so confirm u unlocked the skin, so all it needs to save is 1 for unlocked 0 for locked

is no reason to go above 1 as u can only unlock that skin id once.

also not a reforged thing, it works perfectly in my other map still and that was made in reforged.

 

[Uncle]

as theres 10 different skins, all different intergers, and u can only unlock skin once therefore max u be getting is 1

basically if u unlock a skin, it sets ur skin int to 1, so confirm u unlocked the skin, so all it needs to save is 1 for unlocked 0 for locked

is no reason to go above 1 as u can only unlock that skin id once.

also not a reforged thing, it works perfectly in my other map still and that was made in reforged.

My friend, read my explanation as to how SaveMaxValue works. It's a limit to the VALUE of your SaveValue variable.

So using Skins as an example:

• Set Variable Skin[1] = X
• Set Variable Skin[2] = X
• Set Variable Skin[3] = X

SaveMaxValue should be 3 because there's 3 total Skins.

It doesn't matter if a player can only unlock 1 skin, the save system doesn't care about that. All it wants to do is save these integers in a text file. All SaveMaxValue does is limit the size of these Integers.

 

[C.B.King]

My friend, read my explanation as to how SaveMaxValue works. It's a limit to the VALUE of your SaveValue variable.

So using Skins as an example:

• Set Variable Skin[1] = X
• Set Variable Skin[2] = X
• Set Variable Skin[3] = X

SaveMaxValue should be 3 because there's 3 total Skins.

It doesn't matter if a player can only unlock 1 skin, the save system doesn't care about that. All it wants to do is save these integers in a text file. All SaveMaxValue does is limit the size of these Integers.

doing what u suggested didn't work, setting max value to 100 for example some reason u start with 74k score, set to 1000 started with 35k score, set max to 10000 and u started with 4620 score, and setting it back to 100000 for all testing things, it doesn't load the score at all

and again for the skins example, u counting my skins as a Array so Skin[ArrayNumber] my skins not run as a array number they are array, but that array is Skin[PLayerID: Triggering Player]

unless am not reading correctly what ur saying.

Yes is multiple skins, u can unlock all of them, is why there there own interger, but as i said, when u unlock a skin, i use this, so no matter what the players number for CSkin2 is max of 1, as no matter how many times u use the item the interger will never pass 1, is why i said only need max value of one per skin

• Set VariableSet CSkin2[(Player number of (Owner of (Casting unit)))] = 1

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • (Casting unit) Equal to SetHeroGS[1]
        • (Casting unit) Equal to SetHeroGS[2]
        • (Casting unit) Equal to SetHeroGS[3]
        • (Casting unit) Equal to SetHeroGS[4]
        • (Casting unit) Equal to SetHeroGS[5]
        • (Casting unit) Equal to SetHeroGS[6]
        • (Casting unit) Equal to SetHeroGS[7]
    • (Ability being cast) Equal to |cff00ff00WarGlaives of Azzinoth|r
  • Then - Actions
    • Trigger - Run ResetSkin <gen> (checking conditions)
    • Wait 0.10 seconds
    • Set VariableSet CSkin2[(Player number of (Owner of (Casting unit)))] = 1
    • Game - Display to (All players) the text: ((Name of (Owner of (Casting unit))) + : Power of the |cff00ff00WarGlaives of Azzinoth|r!)
    • Unit - Add Illidan Form to (Casting unit)
    • Unit - Remove Illidan Form from (Casting unit)
    • Sound - Play Illidan <gen>
  • Else - Actions

basically are u saying combine this

• Set VariableSet SaveCount = (SaveCount + 1)
• Set VariableSet SaveValue[SaveCount] = CSkin1[(Player number of SaveLoadEvent_Player)]
• Set VariableSet SaveMaxValue[SaveCount] = 1

into this

• Set VariableSet SaveCount = (SaveCount + 1)
• Set VariableSet SaveValue[SaveCount] = CSkin1[(Player number of SaveLoadEvent_Player)]
• Set VariableSet SaveValue[SaveCount] = CSkin2[(Player number of SaveLoadEvent_Player)]
• Set VariableSet SaveValue[SaveCount] = CSkin3[(Player number of SaveLoadEvent_Player)]
• Set VariableSet SaveValue[SaveCount] = CSkin4[(Player number of SaveLoadEvent_Player)]
• Set VariableSet SaveValue[SaveCount] = CSkin5[(Player number of SaveLoadEvent_Player)]
• Set VariableSet SaveValue[SaveCount] = CSkin6[(Player number of SaveLoadEvent_Player)]
• Set VariableSet SaveValue[SaveCount] = CSkin7[(Player number of SaveLoadEvent_Player)]
• Set VariableSet SaveValue[SaveCount] = CSkin8[(Player number of SaveLoadEvent_Player)]
• Set VariableSet SaveValue[SaveCount] = CSkin9[(Player number of SaveLoadEvent_Player)]
• Set VariableSet SaveValue[SaveCount] = CSkin10[(Player number of SaveLoadEvent_Player)]
• Set VariableSet SaveMaxValue[SaveCount] = 10

but then how would then load up that u unlocked 3 of the 10 skins for example

EDIT: i think i may know what u mean now, so doing some tests to see.
EDITEDIT: Nope that didnt work, trying something else
EDITEDITEDIT: Nope that didnt work either.

@Uncle - I Figured it out, it had nothing to do with anything you suggested, however i like the idea of putting all code into one loop, but i aint sure how so ima keep it how it is, as it working perfectly,.

After all these issue, when i was about to sleep, it come to my mind what am doing wrong, i checked my other map with codes working, and it confirmed my thought, so i did that and it now works.

EDIT: TY for trying to help though

 

[Uncle]

Ah, I see how you're doing the Skins now, I assumed you were saving an Integer that represented the Skins unlocked, and that Integer would correspond to the [Index] of your Arrays. So like if a player had Skin #9 unlocked then you would Save the integer 9. My mistake.

You're correct to set the MaxValue to 1 for the Skins since you're saving either 0 (locked) or 1 (unlocked).

I guess just make sure that SaveMaxValue is no higher than it needs to be and that problem should be solved, if you didn't already.
Also, make sure that all of these values match up properly in the Save AND Load trigger and that you Load in the Reverse order of how you Saved.

Regarding the Loop thing, you just need to delete every redundant action from AutoSave. So every Action between Player 2 and Player 8 (the last player) would get deleted. Then you'd delete the "Set SaveLoadEvent_Player = Player 1 (Red)" action because that's already Set for you in the Pick Every Player action (Loop). Look at how the Loop works in my previous post, it Sets SaveLoadEvent_Player = (Picked player) and then it runs AutoSave.

So if you had 3 Players in your ActivePlayers group the Loop would go like this:
Pick the 1st player in ActivePlayers -> Set SaveLoadEvent_Player = (Picked player) -> Run AutoSave
Pick the 2nd player in ActivePlayers -> Set SaveLoadEvent_Player = (Picked player) -> Run AutoSave
Pick the 3rd player in ActivePlayers -> Set SaveLoadEvent_Player = (Picked player) -> Run AutoSave

It would run AutoSave 3 times, once for each player. So SaveLoadEvent_Player would be equal to a new player each time it runs. That's why the Actions in AutoSave don't need to be repeated for each individual player, they only need to happen once for SaveLoadEvent_Player.

Also, in your trigger that you posted above that Sets the Skin for the player when they cast an ability, your Wait is not safe:

• Wait 0.10 seconds
• Set VariableSet CSkin2[(Player number of (Owner of (Casting unit)))] = 1

(Casting unit) is not guaranteed to be the same unit after the Wait has finished. This is because (Casting unit) acts like a global variable that will change when ANY unit casts an ability. So during that Waiting period if another unit casts an ability they will become the new (Casting unit).

Event Response Myths

"All event responses are lost except triggering unit" Who said this non-sense first? Attacked Unit: Same thing with triggering unit Attacking Unit: Working correctly Buying Unit: Working correctly Selling Unit: Working correctly Sold Unit...

www.hiveworkshop.com

If you change (Casting unit) to (Triggering unit) then there won't be any issue. Alternatively, you can get rid of the Wait.

Waits need to be handled properly or your map will have a lot of bugs.

 

[C.B.King]

@Uncle - yeah the issue was I didn’t have the load code in reverse dunno why took me so many hours to remember that.

And for Casting Unit, I can’t change the wait time without it it doesn’t reset the skin, so just change that to Triggering Unit I Assume by your post.

 

[Uncle]

@Uncle - yeah the issue was I didn’t have the load code in reverse dunno why took me so many hours to remember that.

And for Casting Unit, I can’t change the wait time without it it doesn’t reset the skin, so just change that to Triggering Unit I Assume by your post.

That makes sense. There's always a lot of confusion surrounding this system.

And yes, use Triggering Unit.