Aspect of the Cheetah

[Moderator]

16 July 2012
Bribe: It can use some work but it is bug free from what I can tell. Approved 2.6/5.

past review

20:59, 15th Feb 2012
Pharaoh_: I'd advise you to work with integers as orders. I would also want you to create a function that returns true or false (set by the user); this will determine whether the Dazed buff will be removed from the caster, after he goes unimmolation or not (true to remove it, false to retain it).
For the dummy unit, set Stats - Hide Minimap Display to True.

Useful otherwise.

 

[Magtheridon96]

The code is fine

All you have to do is make "immolation", "unimmolation", "slow" and "bloodlust" configurable like everything else

And the Init trigger could be shrunken down to be this:

function InitTrig_AotC takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_ISSUED_ORDER)
    call TriggerAddCondition(t, Condition(function AotC_Condition1))
    call TriggerAddAction(t, function AotC_Action1)
    set t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t1, EVENT_PLAYER_UNIT_ATTACKED)
    call TriggerAddCondition(t, Condition(function AotC_Condition2))
    call TriggerAddAction(t, function AotC_Action2)
    set t = null
endfunction

Oh and you could merge the actions and the conditions so you'll only be using conditions ;p

function AotC_Action1 takes nothing returns nothing
    local string id = AotC_Order()
    local integer i
    local unit c
    local unit u
    if id == "immolation" then
        set c = GetTriggerUnit()
        set u = CreateUnit(GetTriggerPlayer(), AotC_UnitId(), GetUnitX(c), GetUnitY(c), 0)
        call UnitAddAbility(u, AotC_UnitAbility())
        call SetUnitAbilityLevel(u, AotC_UnitAbility(), GetUnitAbilityLevel(c, AotC_HeroAbility()))
        call IssueTargetOrder(u, "bloodlust", c)
        call UnitApplyTimedLife(u, 'BTLF', .5)
        set u = null
        set c = null
    elseif id == "unimmolation" then
        call UnitRemoveAbility(GetTriggerUnit(), AotC_AbilityBuff())
    endif
endfunction

function AotC_Action2 takes nothing returns nothing
    local unit c = GetTriggerUnit()
    local integer i = GetUnitAbilityLevel(c, AotC_HeroAbility())
    local unit u
    if i > 0 then
        set u = CreateUnit(Player(PLAYER_NEUTRAL_AGGRESSIVE), AotC_UnitId(), GetUnitX(c), GetUnitY(c), 0)
        call UnitAddAbility(u, AotC_DazeAbility())
        call SetUnitAbilityLevel(c, AotC_DazeAbility(), i)
        call IssueTargetOrder(u, "slow", c)
        call UnitApplyTimedLife(u, 'BTLF', .5)
        set u = null
    endif
    set c = null
endfunction

function InitTrig_AotC takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_ISSUED_ORDER)
    call TriggerAddCondition(t, Condition(function AotC_Action1))
    set t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t1, EVENT_PLAYER_UNIT_ATTACKED)
    call TriggerAddCondition(t, Condition(function AotC_Action2))
    set t = null
endfunction

As you can see, I didn't cache the level in Action1 because it was only used once ;P
I also didn't cache the caster unless the Id of the order is immolation, because if it's unimmolation, I'm only calling it once, so not using the local is ok

 

[KhaosMachine]

Need fix? Ok, but what fix?

 

[Magtheridon96]

^ This:

One can abuse the "EVENT_PLAYER_UNIT_ATTACKED" by spamming orders (usually the "stop" order is the easiest exploit). To avert this, you could use a damage detection system like Weep's.

=p

 

[KhaosMachine]

Maght, can you teachme how to implement the system? I neve implement a system to any trigger. PLEASE

 

[Magtheridon96]

All you have to do is copy all the system code from this: http://www.hiveworkshop.com/forums/spells-569/gui-damage-engine-201016/

Put it into your testmap, and instead of registering the attack event to the trigger, do this:

function InitTrig_AotC takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_ISSUED_ORDER)
    call TriggerAddCondition(t, Condition(function AotC_Action1))
    set t = CreateTrigger()
    call TriggerRegisterVariableEvent(t, "udg_DamageEvent", EQUAL, 1.)
    call TriggerAddCondition(t, Condition(function AotC_Action2))
    set t = null
endfunction

That's how Bribe's system works

 

[Bribe]

I am pretty sure OrderId2String returns null after saving/loading the game. If that's so, you want to change your script:

    if GetIssuedOrderId() == @OrderId(@AotC_TurnOn()@)@ then
    elseif GetIssuedOrderId() == @OrderId(@AotC_TurnOff()@)@ then

 

[xorkatoss]

the ability seems to work just fine, the only "bad" thing i see is that you get the aspect of the cheetah buff twice...

 

[KhaosMachine]

the ability seems to work just fine, the only "bad" thing i see is that you get the aspect of the cheetah buff twice...

Yes, I know, I think the same, but I can not get it with a single icon

Sorry for my english

 

[xorkatoss]

Yes, I know, I think the same, but I can not get it with a single icon

Sorry for my english

oh well, the spell still works so i doubt it's gonna be a problem

 

[Alain.Mark]

wouldn't it be proper if the spell's ms bonus must change while it is active, when the spell is being updated/leveled up? :O

 

[jim7777]

using OrderId for getting the order ids of an order string should make things easier... esp to the user.. instead of searching google (most people may do) what the order id is...

e.g.

OrderId("immolation")
anyways it's your choice

 

[Matarael]

So like,... what does this ability actually do? I kept reading the description but found nothing explaining it.

 

[Olaca09]

Is there any quick way to copy all the variables? Otherwise importing this is going to take hours (o).(o) /Importer Noob

 

[Bribe]

The author can include a variable-creating trigger, or you could.