[Trigger] Arrow key movement

[-Berz-]

Hello, its been a while since I worked with WE now I installed wc3 again and I found one unfinished map on my PC, I had this nice idea for a map but I stopped working on it because of its arrow key movement which works but it becomes really laggy when tested with more than 3 players. Now I'm hoping someone could try to figure out why.

Triggurz

• Melee Initialization
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Camera - Lock camera target for Player 1 (Red) to Arthas 0001 <gen>, offset by (0.00, 0.00) using The unit's rotation
    • Camera - Lock camera target for Player 2 (Blue) to Arthas 0037 <gen>, offset by (0.00, 0.00) using The unit's rotation
    • Camera - Lock camera target for Player 3 (Teal) to Arthas 0039 <gen>, offset by (0.00, 0.00) using The unit's rotation
    • Camera - Lock camera target for Player 4 (Purple) to Arthas 0040 <gen>, offset by (0.00, 0.00) using The unit's rotation
    • Camera - Lock camera target for Player 5 (Yellow) to Arthas 0043 <gen>, offset by (0.00, 0.00) using The unit's rotation
    • Camera - Lock camera target for Player 6 (Orange) to Arthas 0044 <gen>, offset by (0.00, 0.00) using The unit's rotation
    • For each (Integer A) from 1 to 6, do (Actions)
      • Loop - Actions
        • Visibility - Create an initially Enabled visibility modifier for (Player((Integer A))) emitting Visibility across (Playable map area)
        • Set Move_Press_Up[(Integer A)] = False
        • Trigger - Add to Move UP <gen> the event (Player - (Player((Integer A))) Presses the Up Arrow key)
        • Trigger - Add to Move UP stop <gen> the event (Player - (Player((Integer A))) Releases the Up Arrow key)
        • -------- - --------
        • Set Move_Press_Left[(Integer A)] = False
        • Trigger - Add to Move Left <gen> the event (Player - (Player((Integer A))) Presses the Left Arrow key)
        • Trigger - Add to Move Left stop <gen> the event (Player - (Player((Integer A))) Releases the Left Arrow key)
        • -------- - --------
        • Set Move_Press_Right[(Integer A)] = False
        • Trigger - Add to Move Right <gen> the event (Player - (Player((Integer A))) Presses the Right Arrow key)
        • Trigger - Add to Move Right stop <gen> the event (Player - (Player((Integer A))) Releases the Right Arrow key)
        • -------- - --------
        • Trigger - Add to Move DOWN <gen> the event (Player - (Player((Integer A))) Presses the Down Arrow key)
        • -------- - --------

• Move UP
  • Events
  • Conditions
  • Actions
    • Set Move_Press_Up[(Player number of (Triggering player))] = True
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Move UP Execution <gen> is on) Equal to False
      • Then - Actions
        • Trigger - Turn on Move UP Execution <gen>
      • Else - Actions

• Move UP stop
  • Events
  • Conditions
  • Actions
    • Set Move_Press_Up[(Player number of (Triggering player))] = False
    • For each (Integer A) from 1 to 6, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Move_Press_Up[(Integer A)] Equal to True
          • Then - Actions
            • Skip remaining actions
          • Else - Actions
    • Trigger - Turn off Move UP Execution <gen>

• Move UP Execution
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • For each (Integer A) from 1 to 6, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Move_Press_Up[(Integer A)] Equal to True
          • Then - Actions
            • Set Move_Group_Up = (Units in (Playable map area) matching ((((Matching unit) is A Hero) Equal to True) and ((((Matching unit) is selected by (Player((Integer A)))) Equal to True) and ((Owner of (Matching unit)) Equal to (Player((Integer A)))))))
            • Unit Group - Pick every unit in Move_Group_Up and do (Actions)
              • Loop - Actions
                • Set Move_Up_Location_Unit = (Position of (Picked unit))
                • Set Move_Up_Location = (Move_Up_Location_Unit offset by 50.00 towards (Facing of (Picked unit)) degrees)
                • Unit - Order (Picked unit) to Move To Move_Up_Location
                • Custom script: call RemoveLocation(udg_Move_Up_Location_Unit)
                • Custom script: call RemoveLocation(udg_Move_Up_Location)
            • Custom script: call DestroyGroup(udg_Move_Group_Up)
          • Else - Actions

Other moves left right... are the same just different actions for movement.
I think the problem begins with event every 0.03 seconds, because there must be like 500 events 0.03 running every second, but I can't think of anything else to make this system work.

Map:

 

[dardas]

how about every 0.10 seconds making the unit move 3.3333333333333333333333333333333 times more? (Used caculator.)

 

[MortAr]

I really wish I could help you, but unfortunely I don't see any problems with the whole thing, except the periodic trigger running constantly.
Maybe you could add units to a global group and check if it's empty, then turn off the periodic trigger and vice versa.

Otherwise, here are some suggestions.

 

[-Berz-]

how about every 0.10 seconds making the unit move 3.3333333333333333333333333333333 times more? (Used caculator.)

tried, but the movement was "stucking" like hero made 2 steps then he stopped and so on... even if i increased order from 50 to 150 or something.

I really wish I could help you, but unfortunely I don't see any problems with the whole thing, except the periodic trigger running constantly.
Maybe you could add units to a global group and check if it's empty, then turn off the periodic trigger and vice versa.

Otherwise, here are some suggestions.

I have tested those all out, none suits my style of map. :< And are way to tricky to edit.

 

[koosha]

I need a system as it!
Any one Can use an test then give a map link?
plz

 

[-Berz-]

Anyone else? :>

 

[koosha]

Please give this as a map
I cannot set these!
Help me plz!

 

[-Berz-]

Please give this as a map
I cannot set these!
Help me plz!

Huh? How could I help you, since this doesn't work how it should.

 

[koosha]

It doesnt work?
give this spell as a map
or you can fix this map
http://s3.aks98.com/images/61152120310739804480.rar
Its problem is cannot true moving with changing camera!

 

[-Berz-]

Simply attach a .w3x (map without raring/zipping/compressing/whatever) And we'll see what we can do about your camera or what you're talking about.

I suggest you use some kind of translator, because it's really difficult to understand your english.

 

[koosha]

Can you Fix this map?
When I Rotate Camera{The rotate system alonge facing angel unit isnt in this map} The Arrow keys Do wrong move!
Can you Set it?

 

[koosha]

Hello, its been a while since I worked with WE now I installed wc3 again and I found one unfinished map on my PC, I had this nice idea for a map but I stopped working on it because of its arrow key movement which works but it becomes really laggy when tested with more than 3 players. Now I'm hoping someone could try to figure out why.

Triggurz

• Melee Initialization
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Camera - Lock camera target for Player 1 (Red) to Arthas 0001 <gen>, offset by (0.00, 0.00) using The unit's rotation
    • Camera - Lock camera target for Player 2 (Blue) to Arthas 0037 <gen>, offset by (0.00, 0.00) using The unit's rotation
    • Camera - Lock camera target for Player 3 (Teal) to Arthas 0039 <gen>, offset by (0.00, 0.00) using The unit's rotation
    • Camera - Lock camera target for Player 4 (Purple) to Arthas 0040 <gen>, offset by (0.00, 0.00) using The unit's rotation
    • Camera - Lock camera target for Player 5 (Yellow) to Arthas 0043 <gen>, offset by (0.00, 0.00) using The unit's rotation
    • Camera - Lock camera target for Player 6 (Orange) to Arthas 0044 <gen>, offset by (0.00, 0.00) using The unit's rotation
    • For each (Integer A) from 1 to 6, do (Actions)
      • Loop - Actions
        • Visibility - Create an initially Enabled visibility modifier for (Player((Integer A))) emitting Visibility across (Playable map area)
        • Set Move_Press_Up[(Integer A)] = False
        • Trigger - Add to Move UP <gen> the event (Player - (Player((Integer A))) Presses the Up Arrow key)
        • Trigger - Add to Move UP stop <gen> the event (Player - (Player((Integer A))) Releases the Up Arrow key)
        • -------- - --------
        • Set Move_Press_Left[(Integer A)] = False
        • Trigger - Add to Move Left <gen> the event (Player - (Player((Integer A))) Presses the Left Arrow key)
        • Trigger - Add to Move Left stop <gen> the event (Player - (Player((Integer A))) Releases the Left Arrow key)
        • -------- - --------
        • Set Move_Press_Right[(Integer A)] = False
        • Trigger - Add to Move Right <gen> the event (Player - (Player((Integer A))) Presses the Right Arrow key)
        • Trigger - Add to Move Right stop <gen> the event (Player - (Player((Integer A))) Releases the Right Arrow key)
        • -------- - --------
        • Trigger - Add to Move DOWN <gen> the event (Player - (Player((Integer A))) Presses the Down Arrow key)
        • -------- - --------

• Move UP
  • Events
  • Conditions
  • Actions
    • Set Move_Press_Up[(Player number of (Triggering player))] = True
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Move UP Execution <gen> is on) Equal to False
      • Then - Actions
        • Trigger - Turn on Move UP Execution <gen>
      • Else - Actions

• Move UP stop
  • Events
  • Conditions
  • Actions
    • Set Move_Press_Up[(Player number of (Triggering player))] = False
    • For each (Integer A) from 1 to 6, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Move_Press_Up[(Integer A)] Equal to True
          • Then - Actions
            • Skip remaining actions
          • Else - Actions
    • Trigger - Turn off Move UP Execution <gen>

• Move UP Execution
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • For each (Integer A) from 1 to 6, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Move_Press_Up[(Integer A)] Equal to True
          • Then - Actions
            • Set Move_Group_Up = (Units in (Playable map area) matching ((((Matching unit) is A Hero) Equal to True) and ((((Matching unit) is selected by (Player((Integer A)))) Equal to True) and ((Owner of (Matching unit)) Equal to (Player((Integer A)))))))
            • Unit Group - Pick every unit in Move_Group_Up and do (Actions)
              • Loop - Actions
                • Set Move_Up_Location_Unit = (Position of (Picked unit))
                • Set Move_Up_Location = (Move_Up_Location_Unit offset by 50.00 towards (Facing of (Picked unit)) degrees)
                • Unit - Order (Picked unit) to Move To Move_Up_Location
                • Custom script: call RemoveLocation(udg_Move_Up_Location_Unit)
                • Custom script: call RemoveLocation(udg_Move_Up_Location)
            • Custom script: call DestroyGroup(udg_Move_Group_Up)
          • Else - Actions

Other moves left right... are the same just different actions for movement.
I think the problem begins with event every 0.03 seconds, because there must be like 500 events 0.03 running every second, but I can't think of anything else to make this system work.

*I can attach a map if needed

But Its better to set it on a map for test and simple install!
Please attach a map!

 

[-Berz-]

Ok, I'll check it out sometime today.

 

[GhostThruster]

I find adding Custom Script: DestroyTrigger(GetTriggeringTrigger()) helps. Add that to the initialization.
Or else, please attach a map so people can get a better understanding.

 

[Anachron]

The problem is: The wc3 event handler has delay on arrow keyboard events.
I think this is because they have their own timer.

You can't do anything about it, I tried that too.
You can still give the unit 4 abilities, up, down, left and right and check the cast (make it instant).

 

[koosha]

The man that I upload here isnt your system!
my map's system
Its better attach a map with your system

 

[-Berz-]

Ok, map added to the first post.

GhostThruster, I don't see how that would help, since the trigger gets turned off after releasing key.

Anachron, that would work, but I need other spells, and I'd lost 4 spell slots then, even now I'll need to make a spell book to put some minor spells in.

koosha, looking at your map now. *Edit: I don't see what's wrong, it works correctly even if you scroll the camera or hit delete or insert. And that system was approved and i think with a rating 4/5 so it should work without problems.

Hmm... I'll try to run my system trough timers, bu then I'll need a separate trigger for every player, since you can't define event using array "player number of triggering player"

 

[koosha]

Your system has a problem!
Unit usually stops his move!
Its my maps trigger
Any one Can fix it?
The camera is true but keys are incorrect!

 

[GhostThruster]

Add that to the Map Initialization, not the Loop trigger! I read a tutorial that said it helps performance by deleting a one-time use only trigger.

 

[-Berz-]

Your system has a problem!
Unit usually stops his move!
Its my maps trigger
Any one Can fix it?
The camera is true but keys are incorrect!

No I cannot help you.

 

[koosha]

This will the best camera and arrow keys!If a editor fix its keys!
Your camera and keys cannot good act

 

[koosha]

How Can solve my problem?

 

[Exilus4]

View attachment Systems.w3x this<<<<make by me try it .iam was make this system more than 10 time all wont make any lag one...you can use on your map

 

[-Berz-]

Ok, I'll check it out.

Well your system works only for one player :<

Still thanks for trying.

 

[GhostThruster]

Here's my version. I dunno if it is laggy or not, coz I didn't test it online, but it looks good and will be especially awesome in Third Person Shooters.

 

[-Berz-]

YEAH! this is what I'm talking about!

Thanks I'll take a deeper look to your system and I'll rip out the parts I need, because your is similar to my system.

Thanks!

This can be marked as solved now.

Edit:

Your system got only one problem it doesn't use units movement speed, but i'll manage that out.

 

[GhostThruster]

I don't really like to use Issue Orders. Move Instantly is alot more smoother and realistic, and also more editable.

 

[-Berz-]

Well I got my working now, but the unit still stuck when facing a tree, it's realistic in some way put annoying during the game. But I don't know eater, I cannot test it online :<

 

[GhostThruster]

What is 'eater'? You can stop the unit from bumping into destructables by deleting the
"Pick Every Destructible" action in the periodic spell.

 

[-Berz-]

I made a typo, actually I can't even write that word right :<

Well, I tested system online, and it works without lag, thanks to your code, I was able to edit my I'll figure out something for that tree issue.