are camera shakes safe?

[caleman]

no lag, no leaks, no making the players computer use a lot of resources in late game, etc?

• Grupo de jugadores - Pick every player in Grupo jugador: Jugador 1 (rojo) and do (Cámara - Shake the camera for (Picked player) with magnitude 10.00)

 

[BloodDrunk]

of course they are, I don't see reasonson whyhyy they wouldn't be safeafefee

 

[deathismyfriend]

he is probably asking because pan camera as needed leaks horribly.

The camera shake on the other hand doesnt leak. Also plz translate things to english when u post.

 

[MasterTrainer]

I don't think it's a bad thing to shake the camera; I mean, all it needs is a real duration right?

 

[deathismyfriend]

Yea it doesn't leak anything.

 

[MasterTrainer]

Clarify something for me: do units leak?

 

[PurgeandFire]

Clarify something for me: do units leak?

Units take up memory, yes. However, a leak is not really a "leak" until it becomes something unnecessarily using memory (or lose reference to it, but ignore that in the case of units because you should always be able to reference them). When having a unit on the map, think about whether you need it there. If there is a boss on the map, yes, you need it there. Therefore, it is not really a leak.

However, let's say you have some dummies for a spell. Once you are done with them you should be able to remove them without worry, since you won't need them anymore. If you don't remove them, it can be considered leaking memory because you have those units there when you don't actually need them.

 

[caleman]

what do you mean by real duration?

if the units are coming out of buildings (normal warcraft) the handlecounter doesnt go up, if you create them via trigger it does go up

 

[PurgeandFire]

what do you mean by real duration?

if the units are coming out of buildings (normal warcraft) the handlecounter doesnt go up, if you create them via trigger it does go up

By "real duration" he means a duration input that is of the type real. For example, 4.6

As for your latter statement, the units coming out of buildings should still have a unique handle ID, so the handle counter should go up, in theory. Either way, they still take up memory.

 

[caleman]

and why do you think this handlecounter doesnt go up?

function HandleCount takes nothing returns nothing
local location L = Location(0,0)
call BJDebugMsg(I2S(GetHandleId(L)-0x100000))
call RemoveLocation(L)
set L = null
endfunction

//===========================================================================
function InitTrig_HandleCounter takes nothing returns nothing
local trigger t = CreateTrigger()
call TriggerRegisterTimerEvent(t,0.09,true)
call TriggerAddAction(t,function HandleCount)
set t = null
endfunction

should i find a better one?

 

[deathismyfriend]

thats a good one and use jass tags when posting jass.

As stated by purgeandfire it should go up. i havent tested it tho so im not sure.

Also units always leak memory even when removed. but removing them lets the handle id recycle. if these handle ids dont get recycled wc3 will eventually run out and crash

 

[caleman]

is the "remove unit" trigger that we use and the "putrefaction time - bone" from game constant the same thing?

 

[MasterTrainer]

I'm not sure I understand what Handle counters are. Can anyone explain that in a brief and short statement?

 

[deathismyfriend]

is the "remove unit" trigger that we use and the "putrefaction time - bone" from game constant the same thing?

not sure what u mean ?
what statement are u referring to.

@ mastertrainer
every object in wc3 is given a handle. basically every object on the map needs to be indexed / de-indexed. This is what a handle is used for. handle is a unique id to each object. so by using a handle counter u see if the handles dont go down / get de-indexed.

 

[Binsu]

Camera shakes are not that dangerous and is safe to use unless you have some triggers accompanied with it that leaks.

 

[MasterTrainer]

@ mastertrainer
every object in wc3 is given a handle. basically every object on the map needs to be indexed / de-indexed. This is what a handle is used for. handle is a unique id to each object. so by using a handle counter u see if the handles dont go down / get de-indexed.

Thanks! I understand now.

 

[deathismyfriend]

Camera shakes are not that dangerous and is safe to use unless you have some triggers accompanied with it that leaks.

that still means that camera shakes are safe. its the triggers that would be the problem.

 

[MasterTrainer]

^ Agreed.

 

[deathismyfriend]

Thanks! I understand now.

np lol

 

[Binsu]

Of course, you are right. Shakes are safe, its the only triggers with it that makes leaks or when you used it improperly.

 

[deathismyfriend]

ya but he was only asking about camera shakes not triggers with them in it that could be done poorly

 

[MasterTrainer]

I think we have all come to the conclusion that camera shakes are safe to use in-game.

By that fact I think this thread should be closed, unless the original poster has something to say.

Let's not extend this any further.

 

[Binsu]

ya but he was only asking about camera shakes not triggers with them in it that could be done poorly

So affirmative, camera shakes are safe.

 

[MasterTrainer]

I love quoting myself.

I think we have all come to the conclusion that camera shakes are safe to use in-game.

By that fact I think this thread should be closed, unless the original poster has something to say.

Let's not extend this any further.

 

[Binsu]

I love quoting myself.

And you do know we commented at the same time :b

 

[MasterTrainer]

I know. I would quote myself again, but it has lost it's intended meaning.