[Trigger] Anti-Block (Lag)

[eleljrk]

Ok, so the idea was to make a working Anti-Block system which actually don't lag.. And which works instantly.. I came up with this idea:

Trigger

• Anti Block
  • Events
    • Unit - A unit Begins construction
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (ABChain is empty) Equal to True
      • Then - Actions
        • Set TempLoc = (Position of (Triggering unit))
        • Set ABChain = (Units in (Entire map) matching ((Matching unit) Equal to (Triggering unit)))
        • Set ABMin = (X of TempLoc)
        • Set ABMax = (X of TempLoc)
      • Else - Actions
    • Set ABCheck = False
    • Unit Group - Pick every unit in ABChain and do (Actions)
      • Loop - Actions
        • Set TempLoc2 = (Position of (Picked unit))
        • Set TempGroup = (Units owned by (Owner of (Triggering unit)))
        • Unit Group - Pick every unit in TempGroup and do (Actions)
          • Loop - Actions
            • Set TempLoc3 = (Position of (Picked unit))
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Unit-type of (Picked unit)) Not equal to Human Builder
                • ((Picked unit) is in ABChain) Equal to False
                • (Distance between TempLoc2 and TempLoc3) Less than 182.00
              • Then - Actions
                • Unit Group - Add (Picked unit) to ABChain
                • If ((X of TempLoc3) Less than ABMin) then do (Set ABMin = (X of TempLoc3)) else do (Do nothing)
                • If ((X of TempLoc3) Greater than ABMax) then do (Set ABMax = (X of TempLoc3)) else do (Do nothing)
                • Set ABCheck = True
              • Else - Actions
    • Custom script: call DestroyGroup(udg_TempGroup)
    • Custom script: call RemoveLocation(udg_TempLoc3)
    • Custom script: call RemoveLocation(udg_TempLoc2)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ABCheck Equal to False
      • Then - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (ABMax - ABMin) Greater than or equal to 1792.00
          • Then - Actions
            • Special Effect - Create a special effect at TempLoc using Abilities\Spells\Human\DispelMagic\DispelMagicTarget.mdl
            • Special Effect - Destroy (Last created special effect)
            • Unit - Remove (Triggering unit) from the game
          • Else - Actions
        • Custom script: call DestroyGroup(udg_ABChain)
        • Custom script: call RemoveLocation(udg_TempLoc)
      • Else - Actions
        • Trigger - Run Anti Block <gen> (checking conditions)

This does work for anti-blocking.. This works instantly.. But when the "Chain" is long enough, it lags everytime you build a new tower into the chain.

So the question is: Any ideas how to "remove" the lag?

Define "chain": Towers which touches each other.

Examples:

|       |
|XXXXXX |
|       |
| XXXXXX|
|       |
|XXXXXX |
|       |
| XXXXXX|
|       |
|XXXXXX |
|       |

|       |
|XXXXXX |
|     X |
| XXX X |
| X   X |
| X XXX |
| X     |
| XXXXXX|
|       |
|XXXXXX |
|       |

EDIT:
Trigger updated with leak (pointed out by Maker) fixed..

 

[Mac_MacNuggets]

Why don't you make the creatures attack the building if they get blocked.

 

[eleljrk]

1. Could benefit the player. (Construct, wait for it.. wait for it.. sell it)
2. Because attacking creatures may attack wrong tower.
3. This would look way more professional if I made it to work correctly.

 

[Maker]

Add

• Custom script: set bj_wantDestroyGroup = true

before

• Unit Group - Pick every unit in (Units owned by (Owner of (Triggering unit))) and do (Actions)

 

[eleljrk]

Isn't it

• Custom script: set bj_wantDestroyGroup = true

Or am I wrong?

Anyway, thanks for pointing out a leak I missed.. I will do it old style anyway.. (Create the group, then destroy it.)

 

[Maker]

Yeah, I was typing in a hurry. Using that custom script will execute the code slightly faster than using a variable.

 

[eleljrk]

Is it required to run that in every Trigger, or just once in (for example) Map Initialization..?
And it's faster because you just run 1 action instead of 2, right?

Anyway, anything else that may make this script quicker to excecute? I was hoping someone had a cleaver way of skipping the looping I use..

 

[Maker]

These are in wrong place:

• Custom script: call DestroyGroup(udg_TempGroup)
• Custom script: call RemoveLocation(udg_TempLoc3)
• Custom script: call RemoveLocation(udg_TempLoc2)

Could you post the system in a map? There are thingsthat can be optimized, but I'm too lazy to type them. Easier to just fix in the editor.

 

[eleljrk]

I know all my Custom Scripts can be placed somewhere else. But wouldn't it cause more lag if it's excecuted more times? I mean.. If a variable is used in a loop like this:

loop 1 to 10...
set TempLocation = some location

Wouldn't it be cleaver to destroy the leak outside the loop, and destroy the variable just once instead of 10 times? I don't believe the variable is stored somewhere else outside itself, unless you or someone else can prove me wrong..