[Trigger] Another spell review..

[Hollification]

I just finished another spell, I'm hoping this ones leakless, and fine the way it is.
Here we go.
I'm just posting these for learning purposes.

• Soul Eater
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to (==) Soul Eater (UL)
  • Actions
    • -------- Set Variables --------
    • Set SoulEaterAbpoint = (Target point of ability being cast)
    • -------- Special Effects --------
    • Unit - Create 1 SoulEaterDummy1 for Player 1 (Red) at SoulEaterAbpoint facing (Position of (Triggering unit))
    • Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
    • Unit - Create 1 SoulEaterDummy2 for Player 1 (Red) at SoulEaterAbpoint facing (Position of (Triggering unit))
    • Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
    • -------- Damage --------
    • Unit Group - Pick every unit in (Units within 600.00 of SoulEaterAbpoint matching ((((Matching unit) is A structure) Equal to (==) False) and ((((Matching unit) is alive) Equal to (==) True) and (((Matching unit) belongs to an enemy of (Triggering player)) Equal to (==) True)))) and do (Actions)
      • Loop - Actions
        • Unit - Cause (Triggering unit) to damage (Picked unit), dealing ((Real((Level of (Ability being cast) for (Triggering unit)))) x (0.50 x (Real((Intelligence of (Triggering unit) (Include bonuses)))))) damage of attack type Spells and damage type Normal
        • Custom script: call RemoveLocation (udg_SoulEaterAbpoint)

 

[MortAr]

• Unit - Create 1 SoulEaterDummy1 for Player 1 (Red) at SoulEaterAbpoint facing (Position of (Triggering unit))

This causes a leak, you need to store the location into a variable first.
And, use (Owner of (Triggering Unit)) instead of "Player 1 (red)" so that every player could use the spell.

Also put this:

• Custom script: call RemoveLocation (udg_SoulEaterAbpoint)

Outside the group loop.

 

[Hollification]

• Unit - Create 1 SoulEaterDummy1 for Player 1 (Red) at SoulEaterAbpoint facing (Position of (Triggering unit))

This causes a leak, you need to store the location into a variable first.
And, use (Owner of (Triggering Unit)) instead of "Player 1 (red)" so that every player could use the spell.

Also put this:

• Custom script: call RemoveLocation (udg_SoulEaterAbpoint)

Outside the group loop.

Thanks again, I'm trying to make sure the map won't lag out, and i'm also trying to learn how to make better trigger-enhancing spells.

 

[ForeverBeADragon]

One more leak..

• -------- Damage --------
• Custom script: set bj_wantDestroyGroup = true

 

[mckill2009]

Player 1 (Red) >>> TriggerPlayer

trigger enhancing spells is really hard for beginners, I suggest you look into the tutorials
and learn basic GUI, but dont waste too much time learning GUI, jump to learn JASS
immediately, coz there you can really enhance your spell...

 

[defskull]

Player 1 (Red) >>> TriggerPlayer

trigger enhancing spells is really hard for beginners, I suggest you look into the tutorials
and learn basic GUI, but dont waste too much time learning GUI, jump to learn JASS
immediately, coz there you can really enhance your spell...

A person with low knowledge on programming language can't even properly do GUI, how do you expect them to understand JASS that fast ?

If they have background knowledge on programming, that's fine, but what if that person is just a new person trying to learn triggers and stuff, he has to at least master GUI at about 80% of it and understand every possible problems and solutions

It's better for him to stick to GUI until he has learned a proper indexing or Hashtable, then go on for JASS

 

[ForeverBeADragon]

A person with low knowledge on programming language can't even properly do GUI, how do you expect them to understand JASS that fast ?

If they have background knowledge on programming, that's fine, but what if that person is just a new person trying to learn triggers and stuff, he has to at least master GUI at about 80% of it and understand every possible problems and solutions

It's better for him to stick to GUI until he has learned a proper indexing or Hashtable, then go on for JASS

I have stuck to GUI for 6 years
Can you show me somewhere to learn JASS?

 

[defskull]

Use the 'Search' function in this forum would help you
This would be a great place to start as it included tutorials as well as practice for you - http://www.hiveworkshop.com/forums/...vjass-practice-session-1-a-114519/#post982549

Also, browse through the Google won't hurt as Hiveworkshop is not the only warcraft 3 mod community, I heard the The Helper serves a great tutorials and some nice systems too

Keep learning

 

[mckill2009]

I said...

I suggest you look into the tutorials and learn basic GUI, but dont waste too much time learning GUI, jump to learn JASS immediately,...

I did not say 'fast', and even without programming language, you can still
learn jass if you are willing to learn, have patience and time...
Jass editors such as JassNewGenPack and JassCraft has an auto fill information of all
those functions and arguments within that function, plus it is faster than GUI if coded properly...