Am i making leaks?

[venjoulytes]

For every 3 seconds:

Pick every unit in Attackers(specified unit group) and do (multiple actions)
Order picked unit to attack TempPoint(consider this line leak free cause iv made the removeLoc thing)

Do i need to destroy the group? or am i leak free?

 

[MortAr]

If the unit group is a veriable put a

• Custom script: call DestroyGroup (udg_GroupName)

after all actions into the group are done.

If its not (using <matching unit>) then put a

• Custom script: set bj_wantDestroyGroup = true

before the group loop.

 

[VergilThazaar]

You DO need to destroy the group and use the [TRIGGER][/TRIGGER] tags.

• Leak
• Custom Script: call DestroyGroup(udg_tmpGroup)

Of course you'll need to set the unit-group into a variable.

 

[eleljrk]

you need to remove both location and group.
You should add this after the use of the point:
Custom Script: Call RemoveLocation(udg_TempLoc)

and this after the unit group, no, not in the unit group, after!
Custom Script: Call DestroyGroup(udg_TempGroup)

Read this tutorial: https://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/basic-memory-leaks-5889/ for more information about leaks.

 

[venjoulytes]

I said i already have the locations leakless. I just want to know if using a variable that is not temporary needs to be cleaned. Because "Attackers" unit group variable is none temporary. It is a group of units in a Wave that needs to be ordered to attack a region every 10 seconds. If i destroy Attackers i will lose control over the units.

 

[eleljrk]

You got 3 answers and the only part you did read was my advertisment of location leaks? READ THE POSTS BEFORE YOU REPLY!

EDIT:
You can also just remove unit group when they come to the "Life Lost" region.

 

[MortAr]

I said i already have the locations leakless. I just want to know if using a variable that is not temporary needs to be cleaned. Because "Attackers" unit group variable is none temporary. It is a group of units in a Wave that needs to be ordered to attack a region every 10 seconds. If i destroy Attackers i will lose control over the units.

Making them attack in the begining won't do anything in the future, they will head at the point where the order (attack) is given and attack. Then you don't need the veriable for the specified group anymore.

 

[venjoulytes]

Yes but they often lose their way.

Also, is it true that unit group leaks dont do that much damage to your map. Ive seen warchasers and it has a hell of a lot more leaks

 

[eleljrk]

Well, you could check if all units in unit group is dead and then remove it?

"Unit dies, check if units in unit group is dead, remove if true"

 

[Thunder_eye]

If you're gonna re-use the group, don't destroy it. If it's you're using it temporarily, destroy it.

Most of the times:

• Actions
  • Unit Group - Pick every unit in Attackers and do (Actions)
    • Loop - Actions
      • Do stuff

Or;

• Actions
  • Set Attackers = (Units in (Playable map area))
  • Unit Group - Pick every unit in Attackers and do (Actions)
    • Loop - Actions
      • Do stuff
  • Custom script: call DestroyGroup(udg_Attackers)