About Strings

Starquizer · Jul 30, 2009

When I want to rename a Player or a Unit with ANY name what is the best way to make this ?

Element of Water · Jul 30, 2009

You can't rename a unit. To rename a player you need to do:

Player - Set name of Player to Whatever

Starquizer · Jul 30, 2009

I want whatever to be anything the player type, you once posted me a trigger about that and I also posted another one, can't remeber the thread. If you remeber the events I used, it was an entered chat string containg the 26 alphabet. I want to know whats wrong with it.

Ciebron · Jul 30, 2009

A player just type -Name and what the thier name to be after.

eg. "-Name TheCakeIsALie"

JASS:

library NameChange initializer init

globals
    private string EnteredString
    private string NameString
endglobals

private function ChangeName takes nothing returns nothing
    local player Play = GetTriggerPlayer()
    
    set EnteredString = GetEventPlayerChatString()
    set NameString = SubString(EnteredString,6,StringLength(EnteredString))
    
    call SetPlayerName(Play,NameString)
    
    //If you have a dialog or multiboard you should update those
endfunction

private function init takes nothing returns nothing
    local trigger Trig = CreateTrigger()
    local integer index = 0
    
    loop
        exitwhen index >= bj_MAX_PLAYER_SLOTS
        call TriggerRegisterPlayerChatEvent(Trig,Player(Index),"-Name ",false)
        set index = index + 1
    endloop
    
    call TriggerAddAction(Trig,function ChangeName)
endfunction

endlibrary

If you dont know how substrings work ill will tell you

JASS:

native SubString takes string source, integer start, integer end returns string

the parameter start sould be 6 since "-name " is 6 charters. The end parameter in this case should be at the end of the entered message.
So if we type "-Name TheCakeIsALie" it will only get "TheCakeIsALie" and set that as a name

Starquizer · Jul 30, 2009

"-Name" string will always be constant; you define some names and you are forced to change your player name to those.

Ciebron · Jul 30, 2009

Don't really understand what you mean

Starquizer · Jul 30, 2009

Ok, I want to type a name, any name, then set the player name to that string that was typed.

That was my triggers

Change Player Name
- Events
  - Player - Player 1 (Red) types a chat message containing A as A substring
  - Player - Player 1 (Red) types a chat message containing B as A substring
  - Player - Player 1 (Red) types a chat message containing C as A substring
  - Player - Player 1 (Red) types a chat message containing D as A substring
  - Player - Player 1 (Red) types a chat message containing E as A substring
  - Player - Player 1 (Red) types a chat message containing F as A substring
  - Player - Player 1 (Red) types a chat message containing G as A substring
  - Player - Player 1 (Red) types a chat message containing H as A substring
  - Player - Player 1 (Red) types a chat message containing I as A substring
  - Player - Player 1 (Red) types a chat message containing J as A substring
  - Player - Player 1 (Red) types a chat message containing K as A substring
  - Player - Player 1 (Red) types a chat message containing L as A substring
  - Player - Player 1 (Red) types a chat message containing M as A substring
  - Player - Player 1 (Red) types a chat message containing N as A substring
  - Player - Player 1 (Red) types a chat message containing O as A substring
  - Player - Player 1 (Red) types a chat message containing P as A substring
  - Player - Player 1 (Red) types a chat message containing Q as A substring
  - Player - Player 1 (Red) types a chat message containing R as A substring
  - Player - Player 1 (Red) types a chat message containing S as A substring
  - Player - Player 1 (Red) types a chat message containing T as A substring
  - Player - Player 1 (Red) types a chat message containing U as A substring
  - Player - Player 1 (Red) types a chat message containing V as A substring
  - Player - Player 1 (Red) types a chat message containing W as A substring
  - Player - Player 1 (Red) types a chat message containing X as A substring
  - Player - Player 1 (Red) types a chat message containing Y as A substring
  - Player - Player 1 (Red) types a chat message containing Z as A substring
- Conditions
- Actions
  - Player - Set name of Player 1 (Red) to (Entered chat string)

But EoW told me that it was wrong, I don't know how to set a player name except by this way, other ways I don't understand except for the trigger posted in the thread http://www.hiveworkshop.com/forums/triggers-and-scripts-269/halp-w-camera-commands-138113/ by EoW, that I understand.

Amigurumi · Jul 30, 2009

Change Playername
- Events
  - Player - Player 1 (Red) types a chat message containing -setname as A substring
  - Player - Player 2 (Blue) types a chat message containing -setname as A substring
  - Player - Player 3 (Teal) types a chat message containing -setname as A substring
  - Player - Player 4 (Purple) types a chat message containing -setname as A substring
  - Player - Player 5 (Yellow) types a chat message containing -setname as A substring
  - Player - Player 6 (Orange) types a chat message containing -setname as A substring
  - Player - Player 7 (Green) types a chat message containing -setname as A substring
  - Player - Player 8 (Pink) types a chat message containing -setname as A substring
- Conditions
  - (Substring((Entered chat string), 1, 9)) Equal to -setname
- Actions
  - Game - Display to (All players) the text: (PlayerName[(Player number of (Triggering player))] + ( changed his/her name to + (Substring((Entered chat string), 10, 20))))
  - Player - Set name of (Triggering player) to (Substring((Entered chat string), 10, 20))

with this code, you can change your playername, if you type -setname + yourname.
the substring 10,20 means, that you can type max 10 letters

Dr Super Good · Jul 30, 2009

You can easilly change player names via a command -name and substrings starting at 5-6 and ending at 255 of the entered chat message.

You can not change unit names.

Starquizer · Jul 30, 2009

Ahha, I understood it at last.

Thanks to all users posted in this thread.

Ciebron · Jul 30, 2009

my code does that...

Yixx · Jul 30, 2009

Yes your code does that, but your code has 1 flaw which Amigurumi covers perfectly,
If i would type "wtflolhax-Name lol i owned your code" then it would not set my name properly, and if i would try to teach someone in-game how to set your name, and i type "You just have to type '-Name YourName' and then you are done! =D" then it would bug.
That condition covers that.

Mooglefrooglian · Jul 30, 2009

... why would someone ever do that, rofl?

Element of Water · Jul 30, 2009

if i would try to teach someone in-game how to set your name, and i type "You just have to type '-Name YourName' and then you are done! =D" then it would bug.
That condition covers that.

You obviously didn't read the post through...

Starquizer · Jul 30, 2009

Well, to tell the truth I understood from Amigurumi's post but based on the post of EoW in another thread (I posted its link in this thread BTW)

Ciebron · Jul 30, 2009

JASS:

library NameChange initializer init

globals
    private string EnteredString
    private string NameString
endglobals

private function ChangeName takes nothing returns nothing
    local player Play = GetTriggerPlayer()
    
    set EnteredString = GetEventPlayerChatString()
    set NameString = SubString(EnteredString,6,StringLength(EnteredString))
    
    call SetPlayerName(Play,NameString)
    
    //If you have a dialog or multiboard you should update those
endfunction

private function Conds takes nothing returns boolean
    return SubString(GetEventPlayerChatString(),1,6) == "-Name "
endfunction

private function init takes nothing returns nothing
    local trigger Trig = CreateTrigger()
    local integer index = 0
    
    loop
        exitwhen index >= bj_MAX_PLAYER_SLOTS
        call TriggerRegisterPlayerChatEvent(Trig,Player(Index),"-Name ",false)
        set index = index + 1
    endloop
    
    call TriggerAddCodition(Trig,Condition(function Conds))
    call TriggerAddAction(Trig,function ChangeName)
endfunction

endlibrary

That should do it

About Strings

Similar threads