Earth Splitter v1.05

[Moderator]

00:12, 17th Jun 2010
Hanky:
The effects are cool. Also your spell is MUI and leakless. Well, I got no other choice. Approved!

 

[aaron]

very nice triggering, and honestly. i might use this in my map, good job.

 

[D4RK_G4ND4LF]

niceeeeeeeeeeee
someone is reading my code
unfortunately, you also copyed a mistake I made
you won't need to set the tree checker unit's position to that of the tree for some reason
my bad, sorry ^^

very nice code, only some tiny things for next time

non-array-variables are like twice as fast as array-variables

and I just ran

set udg_r = GetWidgetX(udg_u)
set udg_r = GetUnitX(udg_u)

5 million times (r is a real variable, u is a unit)
GetWidgetX took 23 seconds while
GetUnitX took 18 seconds
(stopped with my stop watch cause wc3 got frozen)
GetUnitX might be even faster since I ran it together with a function to count them
I think this is caused by typecasting from widget to unit

to check if a distance is bigger than some value it will be faster to use pythagoras directly (x,y,x2,y2,r are variables of type real)

if (x-x2)*(x-x2)+(y-y2)*(y-y2) > r * r then

pow and sqrt are slow

you may also try to merge more arrays together (e.g. you can save booleans as reals (if x = 1 then...)) but if you paste all spell data when the map is ready it does not really matter

5/5 + rep from me

edit:

set udg_r = udg_r

took 6 seconds while

set udg_array[0] = udg_array[0]

took 9 seconds

and before somebody starts to complain about these data being damn inaccurate I'll do it first
THESE THINGS WERE MEASURED WITH MY PC AND COULD BE DIFFERENT FOR OTHER PEOPLE

edit2:
SetWidgetLife took 40 sec
SetUnitState(udg_u, UNIT_STATE_LIFE, 100) took the same
the BJ first broke the operation limit and after I adjusted it it broke the game after 40 seconds
(of cause I always handled the operation limit with running the trigger again after 25000 function calls (+ 5000 exitwhen, 5000 udg_i = udg_i + 1)

edit3:
local variables are as "slow" (compared to normal ones) as arrays (fuck! gonna recode some spells X)
and it appears like the game can't handle 5k trigger executions in a row
and booleans are as fast as reals

 

[powerloll]

i could not find any leak :-|
gj

 

[BlackHawk]

Thanks D4RK_G4ND4LF for such a great review, will change the tree check thingy later when I have time.

You are right, your codes were my inspiration^^. I learned a lot from your spells , so I owe you a big thanks . I would rep you but I have to spread some first before I can give it to you again :/

About the array stuff, would it be faster for example to set a location without an array, EA_Loc instead of EA_Loc[1] ? Or do this just affect "2D-arrays" ?

Merging more arrays afterwards is, of course you know^^, a torture and I think that the code is already hard to read so when I merge even more variables it could be an overkill

@aaron79:

Thanks, feel free to edit this for your purposes

@powerloll:

Thanks

 

[aaron]

Thanks D4RK_G4ND4LF for such a great review, will change the tree check thingy later when I have time.

You are right, your codes were my inspiration^^. I learned a lot from your spells , so I owe you a big thanks . I would rep you but I have to spread some first before I can give it to you again :/

About the array stuff, would it be faster for example to set a location without an array, EA_Loc instead of EA_Loc[1] ? Or do this just affect "2D-arrays" ?

Merging more arrays afterwards is, of course you know^^, a torture and I think that the code is already hard to read so when I merge even more variables it could be an overkill

@aaron79:

Thanks, feel free to edit this for your purposes

@powerloll:

Thanks

yeah i have edited it, my map required low dmg so i changed the damage formula and # of lightnings. you should also make this jass, it is like 30% custom script anyway xD