X-OMG-X's Spellpack v1.4

Moderator · Nov 1, 2009

15:00, 16th Jun 2010
Hanky:
I found leaks in some of your trigger. Fix them and I'll approve your spellpack.

kola · Nov 1, 2009

can you post the triggers? i would like to see them but on this comp i dont have wc3...

X-OMG-X · Nov 1, 2009

kola said:
can you post the triggers? i would like to see them but on this comp i dont have wc3...

That will take some time :/
Anyways will do.

mjllonir · Nov 1, 2009

Nice spells

. Will speak to you of a couple of them

X-OMG-X · Nov 1, 2009

Thanks mjllonir

Kola, i have posted the triggers. Damn it took me long time.

G00dG4m3 · Nov 1, 2009

NIce spells dude

Only 2 things are bad - the rocks. They:
1) Live too long
2) Are targetable.
You should add the locust ability to rock's dummy unit.

MortAr · Nov 1, 2009

Ok, first of all its good that you finally released an entire spellpack.

But lets start with the critics...

1. Usage of multiple Integer A handles may cause the entire trigger to bug if its used more than once - use your own integers though.

2. Divine Surrounding does not protect the unit from triggered damage - when I was attacked by the wendingos and then I use the electric push thingy, the unit still take damage from the knockback

3. Its better to determine the level of the ability into a separated integer veriable, than using "Real((Level of Sunrise for SU_Caster))))" - check -BeRZeKeR- spells. By the way (Level of <Ability> for <Unit>) is an integer, you don't need to convert it.

4. I suggest you to use (Triggering Unit) instead of (Casting Unit) - its not a mistake, but (Triggering Unit) can be used multiple times and its work faster

5. Rockcircle - make the rocks (dummies) somehow unselectable, because they are selectable now and may cause errors or misclicks. Also I suggest you to make the explosion event more flexible, because if a unit stay near 3-4 rocks it will take realy high amount of damage and that makes the spell very imbalanced - try to make a group in a loop for every dying dummy, then damage the units within its range and put them into the group, so they won't be damaged more than once.

6. Theres a leak into the "Electricity Stomp":

Unit - Create 1 Dummy for (Owner of ES_Caster) at (Position of (Picked unit)) facing Default building facing degrees

7. That

Unit - Cause (Picked unit) to damage (Picked unit), dealing ((Real((Intelligence of (Picked unit) (Include bonuses)))) x 2.00) damage of attack type Spells and damage type Normal

will make the picked unit to suicide, eg. the kill and bounty will not go to the caster of the spell - use the "ES_Caster" veriable as a damage source.

8. This effect here:

Special Effect - Create a special effect attached to the overhead of (Picked unit) using Abilities\Spells\Items\AIlb\AIlbSpecialArt.mdl

Is not cleared, it may cause intense lag after certain usages.

9. Limit the units here:

Set ES_Group = (Units within 550.00 of ES_Point matching (((Matching unit) is A Hero) Equal to True))

So it won't trigger if the Hero is dead or its an friendly - add (Matching is Alive) and (Matching Unit) belongs to an enemy of (Owner of (ES_Caster).

10. The entire spellpack LACKS of documentation... Ok I see that theres an documentation how to import them (well its not the best but... I'm sure you can do it better) also try to implement "trigger comments" into the triggers for easy understanding of the triggers, because I'm 100% sure that you'll receive alot of comments regarding to this matter.

11. Discriptions are not well made, I had to test the spell and after that I finally realize what does the spell actually do. Try to improve this and add information below the spell discription, regarding the spell is instant-cast, channeling, passive and put the "level-information" in the normal way, b/c in this way its kinda... stupid

.

12. This thing:

Unit - Cause (Picked unit) to damage (Picked unit), dealing ((Real(SU_Intelligence)) x -2.00) damage of attack type Spells and damage type Normal

can be done by (Unit - Set life of unit to (Life of (Picked Unit)) + ((Real(SU_Intelligence)) x 2.00)

13. This thing:

Unit - Create 1 Dummy for (Owner of EN_Caster) at (Position of (Picked unit)) facing Default building facing degrees

Also leaks too, you can use one point into the loop for each picked unit.

On the other hand, the spellpack is good, but the SFXs (special effects) are a bit too much and using more than 2 abilities at the same time caused my FPS to drop realy bad, causing the game to lag. Try to make it more clear and avoid usage of multiple (Interger A).

At the end, I can surely give a 4/5 and vote for approval, but after you fix the things I mention above.

Best regards,
MortAr-

kola · Nov 1, 2009

hahah... i understand why you werent posting it...

but now im on the comp taht i have Wc3... LOL

here is some bugs.. like.. if u kill the target of the electricity push it wont give u the credit of the kill.. so no gold, the Electricity Stomp chance to remake it if an enemy hero is damaged works on allies too...

The wall of rock u made is using dummy.. thats good but... u can click them (thats not good) and the icon it shows is the one of a human peason (thats rly not good)

lol... fix this... i didnt find any other bugs... i didnt check the triggers... so read what mortar said for the triggers

Oh also.. Add the damage that it is doing in the spell description that is shown in the game... and the Hit point that it heals...

Thanathos · Nov 1, 2009

Mhh an OK spellpack you made there. The ideas are not the most creative ones but that is nothing too bad. The visuals and the ingame descriptions are alright but there could be a more detailed manual for each spell on 'How to Import' and i also miss some inCode comments. The coding itself is not too bad but there is still some room for improvements. All spells seem to be instant and therefore they are MUI, but not all of them are leakless.

Trigger	Suggestions
Electricity Stomp	Here you use Integer-A in both of your loops. Thats not really bad because the spell is instant but it´s still not recommended, just create your own loop integer. In your Group-Loop near the end of the trigger you leak effects, you create them on units but you never remove them. In the IF you create a dummy on a location which you never cleaned up. I think it´s a bit imbalanced that there is a chance to recast the spell if there are heros.
Electric Push	Again the Integer-A issue.
Divine Surrounding	The trigger looks ok for me, no leaks found. The only thing you could improve is to replace the one-line-IF by a multi-line-If for the sake of readability.
Sunrise	Looks good sofar but dealing negative damage to heal units is a bit confusing IMO, but i dont think doing it that way is wrong.
Tormenting of Spikes	Integer-A
Rock Circle	Coding looks okay but again you use Integer-A for the loop. In the Destroy Trigger you leak a location, you saved it into a variable but you didn´t remove it. IMO you should use destructabels instead of dummy unit, because you can select the dummies ingame.
Entangelious	In the Group-Loop you create a dummy on a location which you did not clean up.
Overgrown	Looks ok but here you use Integer-A and Integer-B

Well that´s it form my point of view.

~TNT

[edit]
Damn Mortar was faster xD

X-OMG-X · Nov 1, 2009

Thanks guys. I have done almost everything you guys said.

@MortAr- Its not a bug that divine surrounding doesnt protect the unit

The only thing that the shield does it that it stops the unit from attacking/moving. Also, i havent made a better description on the spell right now but i will. (i mean 'instant, no target') Thanks for the rating and the review.
@Thanathos Yes mortar was faster but you found some things he didnt find

Anyways i have added more description on how to import and fixed all the leaks you and mortar notified me about. Thanks for testing and reviewing.

Piwlady · Nov 1, 2009

pretty nice, but effects bugs alot on my computer :O only makes 1 to 2 effects...

X-OMG-X · Nov 1, 2009

Piwlady said:
pretty nice, but effects bugs alot on my computer :O only makes 1 to 2 effects...

Yea i just noticed :cry:

After i updated and added integers instead of 'integer a' it bugs :sad:

Its because of the for each integer.
Could someone please tell me how to fix it?

BloodSoul · Nov 1, 2009

X-OMG-X said:
Yea i just noticed
After i updated and added integers instead of 'integer a' it bugs
Its because of the for each integer.
Could someone please tell me how to fix it?

--
You created a loop with a variable ES_Integer and you still using Integer A at the effects

:

Electricity Stomp
- Events
  - Unit - A unit Starts the effect of an ability
- Conditions
  - (Ability being cast) Equal to Electricity Stomp
- Actions
  - -------- Okay lets start with setting the variables --------
  - Set ES_Caster = (Triggering unit)
  - Set ES_Point = (Position of ES_Caster)
  - Set ES_Level = (Level of Electricity Stomp for ES_Caster)
  - -------- Now we start the pretty circle --------
  - For each (Integer ES_Integer) from 1 to 10, do (Actions)
    - Loop - Actions
      - -------- Here we set the points in the circle --------
      - Set ES_Offset = (ES_Point offset by 250.00 towards ((Real(Integer A)) x 36.00) degrees)
      - -------- Now we create the dummies --------
      - Unit - Create 1 Dummy for (Owner of ES_Caster) at ES_Offset facing Default building facing degrees
      - Unit - Add Electricity Stomp (Dummy) to (Last created unit)
      - Unit - Set level of Electricity Stomp (Dummy) for (Last created unit) to ES_Level
      - Unit - Order (Last created unit) to Orc Tauren Chieftain - War Stomp
      - -------- And now its time for the effects --------
      - Special Effect - Create a special effect at ES_Offset using Abilities\Weapons\Bolt\BoltImpact.mdl
      - Special Effect - Destroy (Last created special effect)
      - Unit - Add a 3.00 second Generic expiration timer to (Last created unit)
      - -------- And now we remove the leaks --------
      - Custom script: call RemoveLocation(udg_ES_Offset)
  - For each (Integer ES_Integer) from 1 to 15, do (Actions)
    - Loop - Actions
      - -------- As we did in the lines above we set variables --------
      - Set ES_Offset2 = (ES_Point offset by 400.00 towards ((Real(Integer A)) x 24.00) degrees)
      - -------- And creates the dummies --------
      - Unit - Create 1 Dummy for (Owner of ES_Caster) at ES_Offset2 facing Default building facing degrees
      - Unit - Add Electricity Stomp (Dummy) to (Last created unit)
      - Unit - Set level of Electricity Stomp (Dummy) for (Last created unit) to ES_Level
      - Unit - Order (Last created unit) to Orc Tauren Chieftain - War Stomp
      - -------- Creates the effects --------
      - Special Effect - Create a special effect at ES_Offset2 using Abilities\Weapons\Bolt\BoltImpact.mdl
      - Special Effect - Destroy (Last created special effect)
      - Unit - Add a 3.00 second Generic expiration timer to (Last created unit)
      - -------- And removing the leaks --------
      - Custom script: call RemoveLocation(udg_ES_Offset2)
  - -------- Now we pick all heroes in the area --------
  - Set ES_Group = (Units within 550.00 of ES_Point matching ((((Matching unit) is A Hero) Equal to True) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an ally of (Owner of ES_Caster)) Equal to False))))
  - Unit Group - Pick every unit in ES_Group and do (Actions)
    - Loop - Actions
      - -------- And we damage the picked units --------
      - Unit - Cause ES_Caster to damage (Picked unit), dealing ((Real((Intelligence of (Picked unit) (Include bonuses)))) x 2.00) damage of attack type Spells and damage type Normal
      - -------- Now we show the special effects --------
      - Special Effect - Create a special effect attached to the overhead of (Picked unit) using Abilities\Spells\Items\AIlb\AIlbSpecialArt.mdl
      - Special Effect - Destroy (Last created special effect)
  - -------- Here we set the chance to do doublecast --------
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Random real number between 1.00 and 100.00) Less than or equal to 10.00
    - Then - Actions
      - -------- And we simply makes a dummy cast the spell --------
      - Set ES_PickedPos = (Position of (Picked unit))
      - Unit - Create 1 Dummy for (Owner of ES_Caster) at ES_PickedPos facing Default building facing degrees
      - Unit - Add Electricity Stomp to (Last created unit)
      - Unit - Order (Last created unit) to Orc Tauren Chieftain - War Stomp
      - Unit - Add a 3.00 second Generic expiration timer to (Last created unit)
    - Else - Actions
  - -------- And at last we remove the leaks --------
  - Custom script: call RemoveLocation(udg_ES_Point)
  - Custom script: call DestroyGroup(udg_ES_Group)
  - -------- ---------------------------- --------
  - -------- ---------------------------- --------
  - -------- Spell by X-OMG-X --------
  - -------- ---------------------------- --------

Change Integer A to Integer Variable.

Electricity Stomp
- Events
  - Unit - A unit Starts the effect of an ability
- Conditions
  - (Ability being cast) Equal to Electricity Stomp
- Actions
  - -------- Okay lets start with setting the variables --------
  - Set ES_Caster = (Triggering unit)
  - Set ES_Point = (Position of ES_Caster)
  - Set ES_Level = (Level of Electricity Stomp for ES_Caster)
  - -------- Now we start the pretty circle --------
  - For each (Integer ES_Integer) from 1 to 10, do (Actions)
    - Loop - Actions
      - -------- Here we set the points in the circle --------
      - Set ES_Offset = (ES_Point offset by 250.00 towards ((Real(ES_Integer)) x 36.00) degrees)
      - -------- Now we create the dummies --------
      - Unit - Create 1 Dummy for (Owner of ES_Caster) at ES_Offset facing Default building facing degrees
      - Unit - Add Electricity Stomp (Dummy) to (Last created unit)
      - Unit - Set level of Electricity Stomp (Dummy) for (Last created unit) to ES_Level
      - Unit - Order (Last created unit) to Orc Tauren Chieftain - War Stomp
      - -------- And now its time for the effects --------
      - Special Effect - Create a special effect at ES_Offset using Abilities\Weapons\Bolt\BoltImpact.mdl
      - Special Effect - Destroy (Last created special effect)
      - Unit - Add a 3.00 second Generic expiration timer to (Last created unit)
      - -------- And now we remove the leaks --------
      - Custom script: call RemoveLocation(udg_ES_Offset)
  - For each (Integer ES_Integer) from 1 to 15, do (Actions)
    - Loop - Actions
      - -------- As we did in the lines above we set variables --------
      - Set ES_Offset2 = (ES_Point offset by 400.00 towards ((Real(ES_Integer)) x 24.00) degrees)
      - -------- And creates the dummies --------
      - Unit - Create 1 Dummy for (Owner of ES_Caster) at ES_Offset2 facing Default building facing degrees
      - Unit - Add Electricity Stomp (Dummy) to (Last created unit)
      - Unit - Set level of Electricity Stomp (Dummy) for (Last created unit) to ES_Level
      - Unit - Order (Last created unit) to Orc Tauren Chieftain - War Stomp
      - -------- Creates the effects --------
      - Special Effect - Create a special effect at ES_Offset2 using Abilities\Weapons\Bolt\BoltImpact.mdl
      - Special Effect - Destroy (Last created special effect)
      - Unit - Add a 3.00 second Generic expiration timer to (Last created unit)
      - -------- And removing the leaks --------
      - Custom script: call RemoveLocation(udg_ES_Offset2)
  - -------- Now we pick all heroes in the area --------
  - Set ES_Group = (Units within 550.00 of ES_Point matching ((((Matching unit) is A Hero) Equal to True) and ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an ally of (Owner of ES_Caster)) Equal to False))))
  - Unit Group - Pick every unit in ES_Group and do (Actions)
    - Loop - Actions
      - -------- And we damage the picked units --------
      - Unit - Cause ES_Caster to damage (Picked unit), dealing ((Real((Intelligence of (Picked unit) (Include bonuses)))) x 2.00) damage of attack type Spells and damage type Normal
      - -------- Now we show the special effects --------
      - Special Effect - Create a special effect attached to the overhead of (Picked unit) using Abilities\Spells\Items\AIlb\AIlbSpecialArt.mdl
      - Special Effect - Destroy (Last created special effect)
  - -------- Here we set the chance to do doublecast --------
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Random real number between 1.00 and 100.00) Less than or equal to 10.00
    - Then - Actions
      - -------- And we simply makes a dummy cast the spell --------
      - Set ES_PickedPos = (Position of (Picked unit))
      - Unit - Create 1 Dummy for (Owner of ES_Caster) at ES_PickedPos facing Default building facing degrees
      - Unit - Add Electricity Stomp to (Last created unit)
      - Unit - Order (Last created unit) to Orc Tauren Chieftain - War Stomp
      - Unit - Add a 3.00 second Generic expiration timer to (Last created unit)
    - Else - Actions
  - -------- And at last we remove the leaks --------
  - Custom script: call RemoveLocation(udg_ES_Point)
  - Custom script: call DestroyGroup(udg_ES_Group)
  - -------- ---------------------------- --------
  - -------- ---------------------------- --------
  - -------- Spell by X-OMG-X --------
  - -------- ---------------------------- --------

Demongrip · Nov 2, 2009

I told you in your previous spell that Integer A bugs

Anachron · Nov 2, 2009

These spells seem to be pretty much the same.

X-OMG-X · Nov 2, 2009

Blood soul, thank you so much. All spells should work fine now.
Demongrip, integer a didnt bug, i just screw it up

Anachron, did u test the spells or did u only take a look on the screenshot?
If you just was looking at the screenshot its because nova spells is the easiest spells to take a screenshot off.

Anachron · Nov 2, 2009

I checked screenshots and code.

MortAr · Nov 2, 2009

Demongrip, integer a didnt bug, i just screw it up

No its bugs since you used it 10 times in a different actions/triggers. Create your own integer and use it instead of placing (Integer A) everywhere.

X-OMG-X · Nov 2, 2009

MortAr- said:
No its bugs since you used it 10 times in a different actions/triggers. Create your own integer and use it instead of placing (Integer A) everywhere.

I did. Check the trigger codes in the description to see the changes. I have also inserted trigger comments.

Panda · Nov 8, 2009

Nice work man.

X-OMG-X · Nov 9, 2009

Updated!

2 new spells is added. The fire spells.

[EDIT]

Updated!

2 new spells is added. The darkness spells.

MortAr · Nov 13, 2009

Unit - Move (Picked unit) instantly to ((Position of (Picked unit)) offset by 4.00 towards (Angle from (Position of (Picked unit)) to BH_Position) degrees)

Special Effect - Create a special effect at (Position of (Picked unit)) using Abilities\Spells\Undead\DeathandDecay\DeathandDecayTarget.mdl

Special Effect - Create a special effect at (Position of (Picked unit)) using Abilities\Spells\Undead\AnimateDead\AnimateDeadTarget.mdl

These leaks

This thing here:

Unit - Set life of SA_Caster to ((Percentage life of SA_Caster) - 2.00)%

Returns a random percentage of the life (eg. it can hit 100% or 40%), use a different math.

Since the spellpack contain a recycling trigger for knockback, try to use it for the black hole as well.

Sir_Astral · Nov 14, 2009

You could mix Lightning with earth and nature, 'cuz it comes almost on same.

X-OMG-X · Nov 16, 2009

Thanks for all the useful feedback.
I have fixed the life percentages but i have a few questions.
First, about the picked units location.
How do i set up a variable that works for all picked units and not only one?
And what do i need to do, to make the black hole MUI? I wont use the knockback system, cuz using other peoples systems doesnt improve my works in the future.

DevilDuke1995 · Nov 16, 2009

man how do u lvlup heroes?

EDIT: black hole DOESNT destroy trees as it say and u should make sacrificial not to kill caster but to leave him with a minimum amount of hp

BlackHawk · Nov 16, 2009

Well i don´t know what exactly you mean by this

How do i set up a variable that works for all picked units and not only one?

, but i guess you want to know how you can move each unit individuality with variables, or am i wrong? If i am right you just can set up the position variable for each unit in the loop and remove it in the loop

example

Einheitengruppe - Pick every unit in BH_Group and do (Actions)
- Schleifen - Aktionen
  - Set Loc_temp[1] = (Position of (Picked unit))
  - Set Loc_temp[2] = (Loc_temp[1] offset by 4.00 towards (Angle from Loc_temp[1] to BH_Position) degrees)
  - Einheit - Move (Picked unit) instantly to Loc_temp[2]
  - Einheit - Pause ein (Picked unit)
  - Custom script: call RemoveLocation(udg_Loc_temp[1])
  - Custom script: call RemoveLocation(udg_Loc_temp[2])

shadeye · Nov 16, 2009

Ok spells nice test map i was little like a rpg

X-OMG-X · Nov 17, 2009

Thanks for the feedback. Blackhawk, lol i totally forgot that i could do that

What i meant by setting up variables for all picked units is 'set variable - (picked unit)' doesnt affact all units but only one unit in the picked units. Anyways i will update later, cuz i have to go to school now (damn school).

pippo · Nov 17, 2009

I haven't got much time atm but there are many leaks...One of it is in Entanglious... It leaks on

Set EN_PickedPos = (Position of (Picked unit))

You have to clear it, too, probably you forgot it

MortAr · Nov 17, 2009

You can use one point veriable into a loop as long as you clear it in the end of the loop.

thecheeselover · Nov 17, 2009

The black hole spell make lagg and leak wc3...

Santa_Claus. · Nov 18, 2009

Omg , black hole is LAGGY !!!!!!!!! and people got stuck in the black hole continue to slide even if the spell is finish

X-OMG-X · Nov 18, 2009

Yea i know there is problems with the black hole spell. Its because its not fully MUI. I dont know how to fix it yet, but will be fixed as soon as possible.

kola · Nov 21, 2009

huh.. Cast Knockback and Get Knockback arent made by paladon??? cuz it look rly similar

EDIT: yeah its the same... and u didnt give any credits... isnt that a rule violation?

X-OMG-X · Nov 22, 2009

kola said:
huh.. Cast Knockback and Get Knockback arent made by paladon??? cuz it look rly similar

EDIT: yeah its the same... and u didnt give any credits... isnt that a rule violation?

I did give credits.. The knockback triggers is made by Paladon and the black hole triggers is made by me.

Piwlady · Dec 3, 2009

I love these spells

I want to see MORE ^^

X-OMG-X's Spellpack v1.4

Spell Pack (Map)

Moderator

Moderator

Similar threads