- Joined
- May 26, 2009
- Messages
- 1,829
Thanks for the submission to the spells section
I made some quick notes:
- Loops should run every 0.03 seconds - 0.01 is needlessly fast
- you only need one index variable (that doesn't need to be an array)
- The triggers in your description are a bit messed up
- Your filtering in bandage toss is sub-optimal (there's a tutorial on how to do this better in the tutorial section)
- Collision size for bandage toss should be configurable
- DummyPoint leaks in bandage toss
- Grouo[0] leaks in bandage toss
- I suggest using SetUntX/Y over move unit instantly
- if all units have the despair buff removed at the same time, then they aren't recycled
- You index all units affected by despair repeatedly - even if they are already indexed
- Real[1] in despair is not set to 0 when a unit is first indexed - this makes the damage dealt by the ability inconsistent
- You can use Triggering Unit instead of learning hero, it's faster
- There's a random pointless condition in "Tantrum refresh"
- There's a lack of uses of temporary variables when appropriate (such as storing calculations of which the results will be used many times)
- Special effects should be configurable
- Dummy units should be owned by a neutral player as to not mess up the score screen
- Running a filter on literally every unit is not terribly efficient - keep track of what units have which abilities instead of constantly filtering from all units
- Each spell has a very different level of code quality, please bring them all up to the same level
- Don't use imported and especially ripped models from games.
- Change the folder name for the pack to an appropriate name
- Standardize your trigger names (apply prefix, be consistent in naming)
- Change your variable names to have a common prefix e.g. ASM_Group[] this prevents other spells from interfering with this pack
- Temporary groups (ones that are cleared and not stored anywhere after the spell ends) do not need to be indexed - they can all be the same group
- The amount of effects for CotSM should be configurable
- Each spell should have a separate configuration trigger - people may not want to import all the spells from the pack
That's all I got from my first read-through, there may be more but it's hard to notice due to these ones.
I made some quick notes:
- Loops should run every 0.03 seconds - 0.01 is needlessly fast
- you only need one index variable (that doesn't need to be an array)
- The triggers in your description are a bit messed up
- Your filtering in bandage toss is sub-optimal (there's a tutorial on how to do this better in the tutorial section)
- Collision size for bandage toss should be configurable
- DummyPoint leaks in bandage toss
- Grouo[0] leaks in bandage toss
- I suggest using SetUntX/Y over move unit instantly
- if all units have the despair buff removed at the same time, then they aren't recycled
- You index all units affected by despair repeatedly - even if they are already indexed
- Real[1] in despair is not set to 0 when a unit is first indexed - this makes the damage dealt by the ability inconsistent
- You can use Triggering Unit instead of learning hero, it's faster
- There's a random pointless condition in "Tantrum refresh"
- There's a lack of uses of temporary variables when appropriate (such as storing calculations of which the results will be used many times)
- Special effects should be configurable
- Dummy units should be owned by a neutral player as to not mess up the score screen
- Running a filter on literally every unit is not terribly efficient - keep track of what units have which abilities instead of constantly filtering from all units
- Each spell has a very different level of code quality, please bring them all up to the same level
- Don't use imported and especially ripped models from games.
- Change the folder name for the pack to an appropriate name
- Standardize your trigger names (apply prefix, be consistent in naming)
- Change your variable names to have a common prefix e.g. ASM_Group[] this prevents other spells from interfering with this pack
- Temporary groups (ones that are cleared and not stored anywhere after the spell ends) do not need to be indexed - they can all be the same group
- The amount of effects for CotSM should be configurable
- Each spell should have a separate configuration trigger - people may not want to import all the spells from the pack
That's all I got from my first read-through, there may be more but it's hard to notice due to these ones.