[Crash] Players always gets crash when picking a hero, except Player 1 slot

[Hordeon]

Test it out yourself. Host map, pick hero (keep in mind, this is WIP project).

(Test it with 2+ players).

What happens is:

You are the only guy left in the game, other players crash instantly after picking their hero. I dont know where is the problem. Customscripts look fine, everything looks fine, I just don't know where the problem lies.

View attachment Nightmare Arena 0.01.w3x

 

[deathismyfriend]

can u show the triggers plz.

 

[Hordeon]

can u show the triggers plz.

Map isn't protected, it is very small. I would be glad if you checked them via WE.
There are loads of triggers already, but okay.

Here we go:

• Hero Picked
  • Events
    • Unit - A unit Sells a unit
  • Conditions
    • (Unit-type of (Selling unit)) Equal to Tavern
  • Actions
    • Unit - Kill (Buying unit)
    • Set tempPoint = (Center of Heroes Sellected <gen>)
    • Unit - Move (Sold unit) instantly to tempPoint, facing Default building facing degrees
    • Set tempPoint = (Center of Heroes Sellected <gen>)
    • Camera - Pan camera as necessary for (Owner of (Buying unit)) to tempPoint over 0.01 seconds
    • Set SoldHeroes = (SoldHeroes + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • SoldHeroes Equal to Players
      • Then - Actions
        • Trigger - Run END <gen> (ignoring conditions)
      • Else - Actions
    • Custom script: call RemoveLocation(udg_tempPoint)

 

[deathismyfriend]

i dont see anything that would cause desync. can u show me the trigger that is called ?

ur leaking the point when u store this the second time. it isnt necessary to store this a second time.
Set tempPoint = (Center of Heroes Sellected <gen>)

 

[Hordeon]

i dont see anything that would cause desync. can u show me the trigger that is called ?

ur leaking the point when u store this the second time. it isnt necessary to store this a second time.
Set tempPoint = (Center of Heroes Sellected <gen>)

Thanks for the leakfix. I was very sleepy, when creating Initial v. of this map. So I stored it twice somehow.

• END
  • Events
    • Time - PickHero expires
  • Conditions
  • Actions
    • Visibility - Destroy (Last created visibility modifier)
    • Countdown Timer - Destroy (Last created timer window)
    • Countdown Timer - Start SpawnTime as a One-shot timer that will expire in 40.00 seconds
    • Countdown Timer - Create a timer window for (Last started timer) with title Enemy Wave
    • Set tempGroup = (Units of type Soul Chooser)
    • Unit Group - Pick every unit in tempGroup and do (Actions)
      • Loop - Actions
        • Unit - Kill (Picked unit)
    • Custom script: call DestroyGroup(udg_tempGroup)
    • Custom script: call DestroyTrigger(GetTriggeringTrigger())

 

[Daffa]

• Visibility - Destroy (Last created visibility modifier)

This one is equal to null.
No modifier is made.

• Set tempGroup = (Units of type Soul Chooser)

Unit of Type always leak according to Ralle's Things that Leaks, it's a black listed function.

 

[Hordeon]

• Visibility - Destroy (Last created visibility modifier)

This one is equal to null.
No modifier is made.

• Set tempGroup = (Units of type Soul Chooser)

Unit of Type always leak according to Ralle's Things that Leaks, it's a black listed function.

Better?:

• Hero Taverns
  • Events
    • Time - Elapsed game time is 0.01 seconds
  • Conditions
  • Actions
    • Set tempPoint = (Center of Create Teleporter <gen>)
    • Special Effect - Create a special effect at tempPoint using Abilities\Spells\Human\MassTeleport\MassTeleportTo.mdl
    • Custom script: call RemoveLocation(udg_tempPoint)
    • Set tempForce = (All players controlled by a User player)
    • Player Group - Pick every player in tempForce and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked player) controller) Equal to User
            • ((Picked player) slot status) Equal to Is playing
          • Then - Actions
            • Visibility - Create an initially Enabled visibility modifier for (Picked player) emitting Visibility across Arena <gen>
            • Visibility - Create an initially Enabled visibility modifier for (Picked player) emitting Visibility across Tavern <gen>
            • Set tempPoint = (Center of Soul Chooser <gen>)
            • Camera - Pan camera for (Picked player) to (Center of Tavern <gen>) over 0.00 seconds
            • Unit - Create 1 Soul Chooser for (Picked player) at tempPoint facing Default building facing degrees
            • Custom script: call RemoveLocation(udg_tempPoint)
          • Else - Actions
    • Custom script: call RemoveLocation(udg_tempPoint)
    • Custom script: call DestroyForce(udg_tempForce)

• END
  • Events
    • Time - PickHero expires
  • Conditions
  • Actions
    • Visibility - Destroy (Last created visibility modifier)
    • Countdown Timer - Destroy (Last created timer window)
    • Countdown Timer - Start SpawnTime as a One-shot timer that will expire in 40.00 seconds
    • Countdown Timer - Create a timer window for (Last started timer) with title Enemy Wave
    • Set tempGroup = (Units in Remove Soul Choosers <gen>)
    • Unit Group - Pick every unit in tempGroup and do (Actions)
      • Loop - Actions
        • Unit - Kill (Picked unit)
    • Custom script: call DestroyGroup(udg_tempGroup)
    • Custom script: call DestroyTrigger(GetTriggeringTrigger())

Btw Destroy (Last creadet visibility modifier) works completely fine. I need that function. See?

 

[Hordeon]

bump

 

[deathismyfriend]

u can only bump a thread after 24 hrs plz be patient.

ur problem is the visibility modifier. when u destroy a null object it will cause a crash. also note that ur only destroying one of the visibility modifiers not the both of them

 

[Hordeon]

u can only bump a thread after 24 hrs plz be patient.

ur problem is the visibility modifier. when u destroy a null object it will cause a crash. also note that ur only destroying one of the visibility modifiers not the both of them

Dude, I tried to remove visibility modifiers, still same DESYNC. Not really a crash, they get desync. Tried it myself. Also, sorry for bumping, didn't knew you can't do that more than once after 24hrs.

 

[deathismyfriend]

Remove the action that destroys the visibility modifier and see if the players still desync.

 

[maddeem]

Dude, I tried to remove visibility modifiers, still same DESYNC. Not really a crash, they get desync. Tried it myself. Also, sorry for bumping, didn't knew you can't do that more than once after 24hrs.

Tis actually 48 hours :3

 

[Tonex]

When people register, they should be forced to take a test on the forum rules.

 

[deathismyfriend]

if u are destroying a null timer then it will cause the same desync problem.
just delete each action till u find the one causing it.

 

[Tonex]

Instead of deleting, you could just disable, in case there are any long actions you'd rather not enter again.

 

[Daffa]

• Countdown Timer - Destroy (Last created timer window)

Also returns null, no timer is made.

If that don't do :
Save the modifier in a variable and see if it still cause desync, if I was right, the current removal causes null to the modifier = desync/crash
Also applies to the timer.

 

[WaterKnight]

Do not use Camera - Pan Camera As Necessary (Timed). Blizzard failed there and created a location inside a local block or modified GetCameraTargetPositionLoc to return a new object later on:

function SmartCameraPanBJ takes player whichPlayer, location loc, real duration returns nothing
    local real dist
    if (GetLocalPlayer() == whichPlayer) then
        // Use only local code (no net traffic) within this block to avoid desyncs.

        set dist = DistanceBetweenPoints(loc, GetCameraTargetPositionLoc())
        if (dist >= bj_SMARTPAN_TRESHOLD_SNAP) then
            // If the user is too far away, snap the camera.
            call PanCameraToTimed(GetLocationX(loc), GetLocationY(loc), 0)
        elseif (dist >= bj_SMARTPAN_TRESHOLD_PAN) then
            // If the user is moderately close, pan the camera.
            call PanCameraToTimed(GetLocationX(loc), GetLocationY(loc), duration)
        else
            // User is close enough, so don't touch the camera.
        endif
    endif
endfunction

 

[caleman]

• Set tempGroup = (Units of type Soul Chooser)

Unit of Type always leak according to Ralle's Things that Leaks, it's a black listed function.

is that true or not?

in ralle's things that leak it says "Unit Group - Pick all units of type Footman and do..."

setting units of type in a variable group sounds like something different

 

[Daffa]

I don't know, but I don't use that function much, I would rather use ITE check D:
For safety.

Also, check WaterKnight post.