[Spell] Why this trigger does not work? Just couldn't figure out...

[Geshishouhu]

Don't know why the following trigger does not work. The event just did not fire.... Need help please

function bangmang takes nothing returns nothing
    call SetUnitInvulnerable(gg_unit_H00F_0198,false) 
    call DisableTrigger(LoadTriggerHandle(udg_chongfeng1,5,0))
    call DestroyTrigger(LoadTriggerHandle(udg_chongfeng1,5,0))
    call FlushChildHashtable(udg_chongfeng1,5)
    call ReleaseTimer(GetExpiredTimer())   
endfunction
function Trig_bangmang_Actions takes nothing returns boolean
    local timer t =NewTimer()
    call DisplayTimedTextToForce(udg_wanjiazu,1.,"|cFFFF0000Debug!|r")
    call SetUnitState(gg_unit_H00F_0198, UNIT_STATE_LIFE, GetUnitState(gg_unit_H00F_0198, UNIT_STATE_MAX_LIFE))
    call UnitRemoveBuffs(gg_unit_H00F_0198,false,true)
    call DisplayTimedTextToForce(udg_wanjiazu,30,"TRIGSTR_15427")
    call SetUnitInvulnerable(gg_unit_H00F_0198,true)
    call SaveTriggerHandle(udg_chongfeng1,5,0,GetTriggeringTrigger())        
    call TimerStart(t,60.,false,function bangmang)
    set t=null
    return false
endfunction
function InitTrig_bangmang takes nothing returns nothing
    set gg_trg_bangmang=CreateTrigger()
    call TriggerRegisterUnitStateEvent(gg_trg_bangmang,gg_unit_H00F_0198,UNIT_STATE_LIFE,LESS_THAN,80000.)
    call TriggerAddCondition(gg_trg_bangmang,Condition(function Trig_bangmang_Actions))
endfunction

Edit: figured out why it did not work... I declared a local variable as following that made the trigger unable to execute:
local real x = xbase + 450. * Cos((I2R(angleUp)*60.) * bj_DEGTORAD)

 

[andreasaspenberg]

i dont have a lot of knowledge about jass but if you tell me what you want to accomplish, maybe i can solve your problem with a trigger.

 

[Geshishouhu]

i dont have a lot of knowledge about jass but if you tell me what you want to accomplish, maybe i can solve your problem with a trigger.

Ok, thnx. What I want to do is very simple: when the life of unit A is lower than 80000., set unit A as invulnerable for 60 seconds.

 

[andreasaspenberg]

that should be easy to do. one thing i must know first however is wether the unit is pre-placed or spawned somehow. the reason for that is that the triggers used is different for each.

 

[Geshishouhu]

that should be easy to do. one thing i must know first however is wether the unit is pre-placed or spawned somehow. the reason for that is that the triggers used is different for each.

It is pre-placed.

 

[andreasaspenberg]

ok. that is all the information i need to start working. i will create an example map and upload it here but it shouldnt take too long. what i did was create an event that checks the unit`s hp to trigger when it activates then, i added a unit action that made that unit invulnerable followed by a 60 seconds wait after which another action triggeres that makes it vulnerable. i tested it myself and it works perfectly.

 

[Geshishouhu]

ok. that is all the information i need to start working. i will create an example map and upload it here but it shouldnt take too long.

Thanks a lot!

 

[andreasaspenberg]

i updated my post with the example map.

 

[Geshishouhu]

i updated my post with the example map.

Thank you! +Rep
Actually I did the same thing in my code, but the trigger just did not work. Anyway, thnx!

 

[deathismyfriend]

Anything used twice or more should be stored into a variable. Especially hashtable reads as they are up to 8 times slower than an arrayed variable read.

LoadTriggerHandle(udg_chongfeng1,5,0)

 

[Geshishouhu]

Anything used twice or more should be stored into a variable. Especially hashtable reads as they are up to 8 times slower than an arrayed variable read.

LoadTriggerHandle(udg_chongfeng1,5,0)

Thanks for the reminder! Glad to see you back!

 

[deathismyfriend]

Lol i've been back. Just not as much as before.

 

[Vinz]

What was the problem with the local?

 

[Geshishouhu]

What was the problem with the local?

Sorry, I didn't clarify that. I declared that local and then used it in a loop and set angleUp=angleUp+1, it looks like the following:

function A takes nothing returns nothing
   local real x = xbase + 450. * Cos((I2R(angleUp)*60.) * bj_DEGTORAD)
   ......
   loop
        exitwhen i > X
        call CreateUnit(....x,y,....)
        set angleUp=angleUp+1
        ....
   endloop
endfunction

This caused the problem, it should be like the following:

function A takes nothing returns nothing
   local real x
   ......
   loop
        exitwhen i > X
        set x = xbase + 450. * Cos((I2R(angleUp)*60.) * bj_DEGTORAD)
        .....
        call CreateUnit(....x,y,....)
        set angleUp=angleUp+1
        ....
   endloop
endfunction

 

[Vinz]

Oh okay then.