Why not work?

[BigOneMarvelFan]

In the tutorial of my project I can not resurrect the heroes automatically, I took the trigger from a DOTA map but I think I deleted something by mistake... at first it worked, now no longer works

• Revive Heroes
  • Eventi
    • Unit - A unit dies
  • Condizioni
    • ((Dying unit) is a Hero) Uguale a TRUE
    • (Owner of (Dying unit)) Uguale a Giocatore (Rosso)
  • Azioni
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • Se - Condizioni
        • ((Dying unit) is in SuperHeroes) Uguale a TRUE
      • Allora - Azioni
        • Gruppo di unitÃ* - Add (Dying unit) to RevivableHeroes
        • Conto alla rovescia - Start ReviveTimers[1] as a Una volta timer that will expire in 3.00 seconds
      • Altrimenti - Azioni

• Revive SuperHeroes Timer
  • Eventi
    • Tempo - ReviveTimers[1] expires
  • Condizioni
  • Azioni
    • Gruppo di unitÃ* - Pick every unit in RevivableHeroes and do (Actions)
      • Giro - Azioni
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • Se - Condizioni
            • (Nick Fury 0158 <gen> is alive) Uguale a TRUE
          • Allora - Azioni
            • Set HeroCentre[1] = (Center of Startzone1 <gen>)
            • Eroe - Instantly revive (Picked unit) at HeroCentre[1], Mostra revival graphics
            • UnitÃ* - Move Nick Fury 0158 <gen> instantly to HeroCentre[1]
            • Wait 3.00 seconds
            • Custom script: call RemoveLocation(udg_HeroCentre[1])
          • Altrimenti - Azioni

Can you tell me why?

 

[Solu9]

Wow reading Italian (I'm guessing) is annoying when you can't speak it ^^

The only thing I can see that should mess it up is the Wait 3.00 seconds. Try disabling it and see if it works.

 

[Pharaoh_]

Wow reading Italian (I'm guessing) is annoying when you can't speak it ^^

The only thing I can see that should mess it up is the Wait 3.00 seconds. Try disabling it and see if it works.

Exactly. Wait within unit group enumerations doesn't work as expected. Additionally, removing the location after a waiting period makes no sense. Directly remove it. You can use another timer instead of the wait, but I don't see why you would need that anyway - this is exactly why you fire the timer in the first place; if you want a duration of 6 seconds instead, then allow the timer to expire after 6 seconds and not 3.

Finally, use "Triggering unit" over Dying unit. It's faster and much more flexible.

 

[BigOneMarvelFan]

Exactly. Wait within unit group enumerations doesn't work as expected. Additionally, removing the location after a waiting period makes no sense. Directly remove it. You can use another timer instead of the wait, but I don't see why you would need that anyway - this is exactly why you fire the timer in the first place; if you want a duration of 6 seconds instead, then allow the timer to expire after 6 seconds and not 3.

Finally, use "Triggering unit" over Dying unit. It's faster and much more flexible.

Pharaoh_? Are you still alive? (just a joke)

Thank you for answering me, the Wait action is a "remnant" of an old Cinematic (Nick Fury said "You're failde, try again" but it didn't work)

In the old Revive Superheroe Timer there was a condition

• Condition
  • ReviveTimers[1] is less than 1.00

but I remove because if the Event is:

• Eventi
  • Time ReviveTimers[1] expires

then ReviveTimers[1] is less than 1.00 ... or not?

Tomorroow I tried to remove the wait action and change Dying Unit into Triggering Unit...

Thank you and thank to Solu9

 

[Pharaoh_]

No, that condition makes no sense if you already have such an event. It's already accurate.

 

[BigOneMarvelFan]

No, that condition makes no sense if you already have such an event. It's already accurate.

Maybe because if another heroes dies beetween Revivers Timer[1] and the expires timer the Revivers Timer[1] restart from 3... I guess

 

[Pharaoh_]

You don't use the same timer, that's why it has an array (those brackets '[]'). Inside the brackets you use (Player number of (Owner of (Triggering unit))). I think (Player number of (Triggering player)) could also work in this case, but I don't remember under which ones it works.