Why does this Action Sometimes Not Run???

[Gnuoy]

Sorry for posting so frequently but I'm having a lot of confusion about Triggers.

This one only seems to fire as intended only sometimes. I tried changing the Event from Unit Dies / Dying Unit to its current form: Becomes revivable / Revivable hero. It seems to still only work intermittently. Does anyone have any insight on this? Thanks for reading.

• Yellow Auto Rez
  • Events
    • Unit - A unit owned by Player 5 (Yellow) Becomes revivable
  • Conditions
    • (Revivable Hero) Equal to Yellow_Hero
  • Actions
    • Unit - Order Altar of Knights 0352 <gen> to Revive Hero Yellow_Hero

 

[Cokemonkey11]

What is Yellow_Hero

 

[Gnuoy]

It's a unit variable that's successfully referenced in other triggers so I'm sure it's valid.

• Yellow Hero Trained
  • Events
    • Unit - Altar of Knights 0352 <gen> Finishes training a unit
  • Conditions
  • Actions
    • Set VariableSet Yellow_Hero = (Trained unit)
    • Trigger - Turn off (This trigger)

 

[Pwnica]

How much hero’s can yellow player have?

 

[Gnuoy]

one hero. i do not think it's a variable problem because the trigger works sometimes. but really i don't know at this point.

 

[Pwnica]

Ok did he revive the first time and then not anymore or can you explain exactly because the triggers looks normal...

 

[Pwnica]

I think it’s Not in the trigger i think you did this for all players and somewhere the yellow hero variable gets overwritten that means one of your other triggers are for example for orange hero you put in yellow hero that’s the only thing I can think about sorry for my double post
Check all other triggers one by one and read them carefully....

 

[Wrda]

You. Need. A. Wait.

Some specific and tricky events require that sort of thing.

 

[Cokemonkey11]

Is it the event that requires a wait or the action?

 

[Wrda]

The action, I guess.

• Trigger
  • Events
    • Unit - A unit Becomes revivable
  • Conditions
  • Actions
    • Game - Display to (All players) the text: A
    • Wait 0.00 seconds
    • Unit - Order Altar of Kings 0001 <gen> to Revive Hero (Triggering unit)

The text is displayed, however if i permutate these actions, the reviving won't work.
I should have been more clear

 

[Cokemonkey11]

So @Wrda that's these, right? jassdoc/unit.j at master · lep/jassdoc

It would be good to send a PR to note the bug in jassdoc, then this information won't be lost somewhere in a forum comment

 

[Wrda]

Yes, but I tested it futher and found out that it's specifically the revive order, not any other thing related to the altar having the hero that becomes revivable.
I added attack 1 to the altar and ordered it to attack some other unit nearby after the hero becoming revivable (after event firing).

 

[Cokemonkey11]

It sounds like you tested two orders, but that doesn't sound conclusive

But in any case it seems worth adding to @LeP 's jassdoc

 

[Wrda]

Yes, but I think I explained it poorly.
My best guess as to why it didn't revive immediately is that: after the hero elevates, message and sound of fallen hero triggers, the hero is available for revive on altar, but with greyed icon (not revivable yet.
After a few seconds it resets the colouring and is now revivable, this is when the event triggers. Now what seems to be happening is that the event is triggered, actions are executed, yet the button to revive isn't ready yet.
Some weird order of operations? I don't know...Warcraft and its idiosyncrasies.

 

[Uncle]

The Event fires too early. The Altar in that trigger is attempting to Revive the hero using the Order but the hero isn't considered revivable yet. Blizzard goofed.