Why does it leak ?

[Chucky]

local unit u = GetSpellTargetUnit()
    local unit a
    local location tl = GetUnitLoc(u)
    local unit t = GetSpellAbilityUnit()
    call CreateNUnitsAtLoc( 1, 'e000', GetOwningPlayer(t), tl, bj_UNIT_FACING )
    set a = GetLastCreatedUnit()
    call UnitApplyTimedLifeBJ( 2.00, 'BTLF', a )
    call UnitAddAbility( a, 'A007')
    call IssueTargetOrderBJ( a, "soulburn", u )
    set a = null
    call RemoveLocation( tl )
    set t = null
    call UnitAddAbility( u, 'Abun')
    call UnitAddAbility( u, 'Awan')
    call TriggerSleepAction( 45 )
    call UnitRemoveAbility( u, 'Abun' )
    call UnitRemoveAbility( u, 'Awan' )

    set u = null

This happens when a unit casts a spell. The spell is MUI but when I cast it multiple times or other units cast it my computer starts lagging badly...

 

[Magtheridon96]

This isn't the right place to post stuff like this.

How the hell did you post a thread here and not in the Submissions?!?!

Post it in the Triggers and Scripts section.

 

[Maker]

Post the full code. The soulburn could trigger this.

Try to get rid of the functions coloured in red, use native functions instead.

bj_LastCreatedUnit, UnitApplyTimedLife(), IssueTargetOrder()

 

[Chucky]

No need to bite my head off ! I didn't know ok ?

 

[Dirac]

What mag meant is that this forum should be impossible to post to people and only mods can move things here lol.

QUICK UPLOAD YOUR RESOURCES TO GET THEM INSTA-APPROVED

local unit a = CreateNUnitsAtLoc( 1, 'e000', GetOwningPlayer(t), tl, bj_UNIT_FACING )

Avoid the use of locations at all times.

local unit a = CreateUnit(player,unit,x,y,facing)

 

[Magtheridon96]

QUICK UPLOAD YOUR RESOURCES TO GET THEM INSTA-APPROVED

Time to code a chat system

 

[Chucky]

Ok here's the whole trigger, I replaced everything like you guys told me and I think I know where the problem is. It's because the local unit u is kept in memory for 45 seconds as I need it and afterwards it's cleaned. Isn't there another way to do this ?

function Trig_Blind_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == 'A008' ) ) then
        return false
    endif
    return true
endfunction

function Trig_Blind_Actions takes nothing returns nothing
    local unit u = GetSpellTargetUnit()
    local real x = GetUnitX(u)
    local real y = GetUnitY(u)
    local unit a = null
    local unit t = GetSpellAbilityUnit()
    set a = CreateUnit(GetOwningPlayer(t), 'e000', x, y, 0.0 )
    call UnitApplyTimedLife( a, 'BTLF', 2.00 )
    call UnitAddAbility( a, 'A007')
    call IssueTargetOrder( a, "soulburn", u )
    set a = null
    set t = null
    set x = 0
    set y = 0
    call UnitAddAbility( u, 'Abun')
    call UnitAddAbility( u, 'Awan')
    call TriggerSleepAction( 45 )
    call UnitRemoveAbility( u, 'Abun' )
    call UnitRemoveAbility( u, 'Awan' )

    set u = null
endfunction

//===========================================================================
function InitTrig_Blind takes nothing returns nothing
    set gg_trg_Blind = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Blind, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Blind, Condition( function Trig_Blind_Conditions ) )
    call TriggerAddAction( gg_trg_Blind, function Trig_Blind_Actions )
endfunction

 

[Magtheridon96]

Start a timer and save the unit in a hashtable using the timer's id.

When the timer expires, the unit will be loaded from the hashtable using the handle id of the expiring timer.

 

[Chucky]

Won't it create lag when let's say 20 units or more cast the same spell very fast ? and also can you give me a quick demo on how to implement this ? I really have NO IDEA about hash tables and I don't got time...

 

[Magtheridon96]

It possibly could.
Timer expirations happening at the same time could cause lag, but trust me. Even if 2 units cast the spell with a time difference of a hundredth of a second, it shouldn't matter at all.

Timers are the best way to go. TriggerSleepAction causes a lot of problems when used outside of single-player mode.
TriggerSleepAction doesn't work unless a function needs to return something.
Plus, since most of us use conditions for anything instead of actions, we can't use TriggerSleepAction anyway.

Trust me bro, timers win hands down.