Water Techniques 3 in 1

[Moderator]

17:42, 20th Jan 2016
BPower:

Terrible code with tons of leaks. For now Need Fix, however more
a candidate for a Rejected status.

 

[jyckos]

Sorry for the bad picture!

 

[Knight of Arsford]

You need to explain more about the spells...Put in a better description. You can post the triggers, the damage, cooldown, mana cost, or effects of the spells, etc.

 

[Yours Truly]

All this dragons sounds cool,gonna check it out.

EDIT:All the spells looks 'cool'.But there's something wrong with your "Riding Ice Dragon".When you reach the end of the map,
the dragon move through and your character cannot move anymore.Also,the controls on the dragon is a bit confusing.If you could fix that,+rep.

EDIT:Oh well,you tried. +rep

 

[jyckos]

I cant fix the "confusing" dragon control, but i can fix if it reach the end of map
Its my first skill map, and im not really good at doing it

 

[Bribe]

Hey jyckos, thank you for posting your first group of spells. Please keep in mind that spells require an in-game screenshot and for the triggers to be posted in

• tags to be approvable. [url]http://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/how-easily-post-triggers-163285/[/url]
• 0.01 second timers are too fast, you'll want to use 0.03 in most cases.
• Memory leaks are when you use things like (position of unit) without removing them. You have a lot of these, which is expected for a first submission. Please review [url]http://www.hiveworkshop.com/forums/general-mapping-tutorials-278/complete-list-things-leak-126761/[/url] and [url]http://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/quick-tutorial-common-triggering-tips-190802/[/url]
• None of your triggers are MUI. You'll want at least a basic understanding that arrays and/or hashtables are the only way to make something MUI. Here's something to get you started: [url]http://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/hashtables-mui-133407/[/url]

 

[Tank-Commander]

I had a quick look at the code for these spells and there's quite a lot of issues. I'll try to state them as clearly as I can:

In the case of the first ability (Water Bomb 1st Technique )
- You use TSAs or Waits these are inconsistent and should not be used
- The Ability is not MUI or even MPI
- There is no configuration for the ability
- The main code is written inefficiently, instead of making each dragon separately you could use a loop reducing the lines of code to 5 for creating them instead of 32
- Same as above could be used for damaging all units and moving all of them
- don't use loop timers of 0.01, use 0.03 instead (or even 0.04)
- You only need one timed trigger (Loop trigger) to control all movement and damage of the dragons
- Use unit starts the effect of instead of unit begins casting
- Use Set Unit X/Y instead of move unit
- Do not use terrain deformation effects, they leak
- you leak many, many locations and unit groups

In the case of the second ability (Water Dragon Ride)
- The ability suffers from everything the first one does and some other things
- Specifically only works for player 1 (red)
- Don't lock player cameras to units, this should not be done except in the case of Camera systems and other similar submissions

In the case of the third ability (Ice Water Technique)
- Everything the first one suffers from also applies here as well
- Leaks regions

Essentially all the basic stuff is lacking in these abilities, I strongly recommend having a look at our tutorial section for making abilities
http://www.hiveworkshop.com/forums/trigger-gui-editor-tutorials-279/
and review memory leaks here: http://www.hiveworkshop.com/forums/triggers-scripts-269/things-leak-35124/ (which is what I'm referring to when I say things leak)

sadly these abilities would have to be almost entirely re-written for them to be able to be approved by moderators as it does not meet the Rules of this section

Any terminology I've used which you're unfamiliar with will probably be explained in those rules (&/or common tutorials in the GUI tutorials section that I've linked)
I wish you luck with your future works

 

[jyckos]

I would be very thank for all of those useful comments! Ill be work hard for the next skill pack but indeed ill have to learn MUI's and leaks and Memorys And Hashtables.

 

[Yours Truly]

You forgot to delete leaks tho.