warpten090 Simple Item Drop System

[Antares]

- Open World Editor - File - Preferences... - General Tab - Tick the Automatically create unknown variables while pasting trigger data

• Copy the 3 trigger need for the system to run
• YOU'RE DONE !

That's not true. A user would have to still do a lot of editing of your functions to make your system work in the way he or she wants to and you give no directions as to what has to be edited where. You need to clearly indicate the parts of your triggers that should be customized, which parts are not to be touched, and which parts are just part of your test map.

The way you're handling the random item roll is unnecessarily complicated and restrictive. You can simply do

• (Random percentage) Less than or equal to percentChance

in your condition and have the user set the drop chance to any value between 0 and 100, instead of restricting them to divisors of 100.

You can set up a trigger array during map initialization and them call the correct trigger for the creep level with

• Trigger - Run itemSetupTriggers[(Level of (Triggering unit))] (ignoring conditions)

This will avoid having to create a bunch of nested If-statements in your defeat creep function.

You're removing the dying unit from the game, which I don't know why.

You're leaking a location every time a unit dies. Read here on how to remove memory leaks.

Even with all of this fixed, your system is quite restrictive, for example not allowing for "choose one out of N" item drops, and there are just better, similar systems available. Because of that, I'll put it to lacking. While I don't want to discourage you, the World Editor Help Forum might be the better section to get feedback on your triggers and improve.

Lacking

 

[warpten090]

The way you're handling the random item roll is unnecessarily complicated and restrictive. You can simply do

• 
  (Random percentage) Less than or equal to percentChance

Math.Random of World Editor is not like in Visual Studio. The result of math.random is not the percent but only random number. what if computer generate small number and item always drop.


Maybe you should read Why I do this section and try v2.1.

 

[Antares]

Math.Random of World Editor is not like in Visual Studio. The result of math.random is not the percent but only random number. what if computer generate small number and item always drop.

• (Random percentage)

returns a random number between 0 and 100. You can also just use the default random real number function and specify the bounds yourself.

Maybe you should read Why I do this section and try v2.1.

Sorry, but your code is a complete mess. You need multiple nested If-Then-Else blocks to do simple mathematical operations, and, unlike with your previous version, I don't even know what you're trying to do. There's no way this system can get approved in a state like this.