[Solved] Units arent created.

[.KyTe]

Guys i need help from you, units aren't created, if someone could help me with this trigger.

   function action2 takes nothing returns nothing
        local integer a
        local integer c = 2
        local integer counter = 0
        local integer b = 3
        set a = a + 1
        call DisplayTimedTextToForce( GetPlayersAll(), 30, "TRIGSTR_009" )
        loop
            exitwhen counter > c
            call CreateUnitAtLoc( Player(11), udg_UnitTypeSpawn[a], GetRectCenter(udg_SpawnRegion[GetRandomInt(1,b)]),180.)
            call IssuePointOrderLoc( GetLastCreatedUnit(), "attack", GetRectCenter(gg_rct_Base_Center_1))
            set counter = counter + 1
        endloop
    endfunction
    
    function action takes nothing returns nothing
        local timer timerz
        call TimerStart( timerz, 2., true, function action2)
    endfunction
    
    function InitTrig_SpawnTimer takes nothing returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterTimerEventSingle(t, 1.)
        call TriggerAddAction(t, function action)
    endfunction

 

[deathismyfriend]

try this
also since ur learning jass u should learn how to inline.

  function action2 takes nothing returns nothing
        local integer a
        local integer c = 2
        local integer counter = 0
        local integer b = 3
        local unit u 
        local integer r = GetRandomInt(1,b)
        local real x = GetRectCenterX(udg_SpawnRegion[r])
        local real y = GetRectCenterY(udg_SpawnRegion[r])
        local real x1 = GetRectCenterX(gg_rct_Base_Center_1)
        local real y1 = GetRectCenterX(gg_rct_Base_Center_1)
        set a = a + 1
        call DisplayTimedTextToForce( GetPlayersAll(), 30, "TRIGSTR_009" )
        loop
            exitwhen counter > c
            set u = CreateUnit( Player(11), udg_UnitTypeSpawn[a], x, y, 180.)
            call IssuePointOrder( u, "attack", x1, y1 )
            set counter = counter + 1
        endloop
    endfunction
    
    function action takes nothing returns nothing
        local timer timerz
        call TimerStart( timerz, 2., true, function action2)
        set timerz = null
    endfunction
    
    function InitTrig_SpawnTimer takes nothing returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterTimerEvent( t, 1., false ) //set true if periodic
        call TriggerAddAction(t, function action)
    endfunction

 

[.KyTe]

I am sorry @deathismyfriend but still units wont be spawned. I am actually planning for a spawning trigger wherein every 45 seconds, 15 units will be spawned once at a time with interval of 1.5 seconds each.

 

[Dr Super Good]

You never create a timer to start. Thus you are starting a initialized variable which causes a thread crash.

local timer timerz
should be
local timer timerz = CreateTimer()

 

[deathismyfriend]

make sure the trigger fires u might have a problem w a trigger above this one or below it tht is causing the triggers to glitch i did this once by forgetting to set t = createtrigger() in one of the triggers above the one i was working on. other than tht it should work if u cant find the problem paste the map or use degub messages to find out what fires and what doesnt fire.

 

[.KyTe]

Still it wont work. I guess i need to post the map now.

Here is the map:

 

[rulerofiron99]

Is the game message being displayed?

 

[.KyTe]

No, thanks for noticing that i put it in there to see what is going on.

 

[rulerofiron99]

I'm struggling to understand; you are creating TWO timers. One at map init makes sense, but why are you also creating new timers each loop?

The problem with those would be that you are nulling them immediately.

local integer a

->

local integer a = 0

 

[.KyTe]

finally reworked it thanks for helping me guys plus rep!