Unit is attacked and attacked unit takes damage

[ZiGOR]

Hi there guys! Tell me please what's wrong with these triggers?

• Magic Arrows
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • And - All (Conditions) are true
      • Conditions
        • (Unit-type of (Attacking unit)) Equal to Naga Sea Witch
        • (Level of Magic Arrows for (Attacking unit)) Greater than 0
  • Actions
    • Trigger - Add to Magic Arrows work <gen> the event (Unit - (Attacked unit) Takes damage)
    • Trigger - Turn on Magic Arrows work <gen>

• Magic Arrows work
  • Events
  • Conditions
    • And - All (Conditions) are true
      • Conditions
        • (Unit-type of (Attacking unit)) Equal to Naga Sea Witch
        • (Level of Magic Arrows for (Attacking unit)) Greater than 0
  • Actions
    • Set Player_Number_Int = (Player number of (Owner of (Attacking unit)))
    • Set Magic_Arrows_Attacker[Player_Number_Int] = (Attacking unit)
    • Set Magic_Arrows_Target[Player_Number_Int] = (Attacked unit)
    • Unit - Cause Magic_Arrows_Attacker[Player_Number_Int] to damage Magic_Arrows_Target[Player_Number_Int], dealing ((Real((Intelligence of Magic_Arrows_Attacker[Player_Number_Int] (Include bonuses)))) x (((Real((Level of Magic Arrows for Magic_Arrows_Attacker[Player_Number_Int]))) x 0.05) + 0.05)) damage of attack type Spells and damage type Fire
    • Special Effect - Create a special effect attached to the chest of Magic_Arrows_Target[Player_Number_Int] using Abilities\Spells\NightElf\Blink\BlinkCaster.mdl
    • Special Effect - Destroy (Last created special effect)
    • Trigger - Turn off (This trigger)

There are mistakes in these triggers but I can't see them

 

[Gismo359]

Use Event Response - Damage Source in the second trigger.
Keep in mind that the triggers will fail if the hero attacks a second unit before the first projectile lands (assuming that its ranged).
Also, it leaks an event which may cause problems if the game gets longer.

 

[ZiGOR]

Use Event Response - Damage Source in the second trigger.
Keep in mind that the triggers will fail if the hero attacks a second unit before the first projectile lands (assuming that its ranged).
Also, it leaks an event which may cause problems if the game gets longer.

Is it possible to overcome this "event leak"?

 

[Gismo359]

Yes, by using some kind of damage detection system. Its basically a generic 'Unit takes damage' event. I suggest looking_for_help's DDS since you can easily use it in GUI.
Also, next time put longer triggers in hidden tags because they stretch the screen a lot, and it is somewhat annoying.

 

[ZiGOR]

Yes, by using some kind of damage detection system. Its basically a generic 'Unit takes damage' event. I suggest looking_for_help's DDS since you can easily use it in GUI.
Also, next time put longer triggers in hidden tags because they stretch the screen a lot, and it is somewhat annoying.

Yeap, sorry, I know. But I forgot how to do it

 

[Acutesharpness]

Secondly, use a unit group variable to record and check if they are already added, by the add event definition, the second time you attack the target which will add a second event OF the same unit when it's not controlled. This result in massive lag and up to infinite amount of execution, WHICH also means it will work literally like incinerate except this time without the buff limitation

 

[ZiGOR]

Secondly, use a unit group variable to record and check if they are already added, by the add event definition, the second time you attack the target which will add a second event OF the same unit when it's not controlled. This result in massive lag and up to infinite amount of execution, WHICH also means it will work literally like incinerate except this time without the buff limitation

Thanks for help