Triggered XP System Issues

[Flitty]

I'm trying to have a triggered XP system for 10 levels with custom level brackets, however I can't get the bracket or level to update correctly.

• Initialisation
  • Events
    • Map initialization
  • Conditions
  • Actions
    • -------- XP Setup --------
    • Set XPBrackets[1] = 20
    • Set XPBrackets[2] = 50
    • Set XPBrackets[3] = 95
    • Set XPBrackets[4] = 145
    • Set XPBrackets[5] = 220
    • Set XPBrackets[6] = 340
    • Set XPBrackets[7] = 480
    • Set XPBrackets[8] = 630
    • Set XPBrackets[9] = 800
    • Set XPBrackets[10] = 1000

• XP Update
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Owner of (Killing unit)) Equal to Player 1 (Red)
  • Actions
    • Set XP = (XP + ((Level of (Dying unit)) x 2))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • XP Greater than or equal to XPBrackets[Level]
        • Level Less than 10
      • Then - Actions
        • Set Level = (Level + 1)
        • Multiboard - Set the text for Multiboard item in column 2, row 2 to (String(Level))
        • Multiboard - Set the text for Multiboard item in column 3, row 5 to (|cffffcc00[|r + ((String(XP)) + (|cffffcc00/|r + ((String(XPBrackets[Level])) + |cffffcc00]|r))))
      • Else - Actions
    • Multiboard - Set the text for Multiboard item in column 3, row 5 to (|cffffcc00[|r + ((String(XP)) + (|cffffcc00/|r + ((String(XPBrackets[Level])) + |cffffcc00]|r))))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • XP Greater than 1000
      • Then - Actions
        • Set XP = 1000
        • Multiboard - Set the text for Multiboard item in column 3, row 5 to |cffffcc00[|r1000|c...
      • Else - Actions

 

[Kanadaj]

• XP Update
  • Events
    • Unit - A unit Dies
  • Conditions
    • (Owner of (Killing unit)) Equal to Player 1 (Red)
    • XP Lower than 1000
  • Actions
    • Set XP = (XP + ((Level of (Dying unit)) x 2))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • XP Greater than 1000
      • Then - Actions
        • Set XP = 1000
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • XP Greater than or equal to XPBrackets[Level]
        • Level Less than 10
      • Then - Actions
        • Set Level = (Level + 1)
        • Multiboard - Set the text for Multiboard item in column 2, row 2 to (String(Level))
      • Else - Actions
    • Multiboard - Set the text for Multiboard item in column 3, row 5 to (|cffffcc00[|r + ((String(XP)) + (|cffffcc00/|r + ((String(XPBrackets[Level])) + |cffffcc00]|r))))

This looks and works much smoother. No need to run the trigger if the XP is above 1000, and no need to update the multiboard 3x in a trigger with the same line.

Also, I'm not sure but I think if you change the content of a multiboard, you have to hide it and then show it, if I remember right.

 

[Flitty]

Thanks a lot that fixed it! I agree, much cleaner looking trigger. The multiboard updates fine without hiding then showing it though.

 

[deathismyfriend]

remove the dying unit and use triggering unit instead.

 

[Starquizer]

remove the dying unit and use triggering unit instead.

@ TheHerb
If you are wondering why, its because it is faster. This is a technical hint nothing more to optimize your map and make it faster.

 

[Spartipilo]

Kanadaj: No need to close/open multiboard to change data. Only to change the multiboard structure

 

[Kanadaj]

Oh yea, really... Haven't touched WE for a long time, I'm doing standalone applications since then

 

[Flitty]

@ TheHerb
If you are wondering why, its because it is faster. This is a technical hint nothing more to optimize your map and make it faster.

You mean it's quicker simply because clicking it is quicker?

 

[Spartipilo]

Wc3 handles Triggering Unit faster and better than other Event Response units. It's the only Unit Event Response you can use after a wait in a trigger without having to store it in a variable. So, it's better because Blizzard decided it.

 

[deathismyfriend]

dying unit calls triggering unit.
same with entering unit, casting unit and mybe a few others.