Trigger doesnt work

[Foxace]

I am trying to make boss cast this spell when players enter in 50 range from the boss, but nothing happens.

function Trig_LKspell1_Actions takes nothing returns nothing
    call UnitAddAbilityBJ( 'A002', gg_unit_H00N_0336 )
    call SetUnitAnimation( gg_unit_H00N_0336, "spell channel" )
    call TriggerSleepAction( 2.00 )
    call IssuePointOrderLocBJ( gg_unit_H00N_0336, "a002", GetUnitLoc(gg_unit_H00N_0336) )
endfunction

//===========================================================================
function InitTrig_LKspell1 takes nothing returns nothing
    set gg_trg_LKspell1 = CreateTrigger(  )
    call TriggerRegisterUnitInRangeSimple( gg_trg_LKspell1, 50.00, gg_unit_H00N_0336 )
    call TriggerAddAction( gg_trg_LKspell1, function Trig_LKspell1_Actions )
endfunction

 

[TriggerHappy]

I don't see why you just made a GUI trigger and converted it (again).

Use JASS or GUI not shitty converted GUI.

"a002" is not a valid order. If you kept it in GUI you would clearly see the list of available spell orders. Look in the object editor and find out which order string your spell has under Text - Order String.

 

[Foxace]

I cant find all options I need in GUI and making GUI trigger and then converting into custom text is easy way to see how it works and I can change some parts of the code.

In place of a002 was originally Blizzard spell, the list didnt have all of the spells in the game so I was unable to get my custom spell from the list.

Why custom spell names are not in the order string list?

 

[TriggerHappy]

I cant find all options I need in GUI and making GUI trigger and then converting into custom text is easy way to see how it works and I can change some parts of the code.

In place of a002 was originally Blizzard spell, the list didnt have all of the spells in the game so I was unable to get my custom spell from the list.

Why custom spell names are not in the order string list?

Okay then learn JASS because that piece of code up there is bad.

Did you find the correct order string in the object editor?

 

[Foxace]

I used the default order string of the custom spell and changed it in the code, but still nothing happens.

I would like to learn JASS but despite hours and hours of reading tutorials I still could not understand anything about writing jass. I would use just GUI but GUI does not even have command like "destroy all path blockers", only "destroy random"

 

[pOke]

You should really try to understand the GUI before you try trekking into pure JASS because something as elementary as this will be the least of your concerns.

Also...post the updated trigger, we don't know what advances you've made or not. Also tell us the base spell and we can simply tell you the order string if you are unable to locate it.

Edit: About path blockers, you can just add them to a destructible group and remove them I'm pretty sure. While GUI definitely has its limitations, if you're struggling try to embrace it and weave JASS in slowly and as needed.

 

[Foxace]

I only changed that a002 into thunderclap, nothing else changed

 

[TriggerHappy]

I only changed that a002 into thunderclap, nothing else changed

Thunderclap isn't a point order.

IssueImmediateOrder

 

[Foxace]

Thunderclap isn't a point order.

IssueImmediateOrder

I changed that and now there are following errors:

line2: undeclared variable gg_unit_H00N_0336
line5: too many arguments passed to function
line 10: undeclared variable gg_trg_LKspell1
line 11: undeclared variable gg_unit_H00N_0336

function Trig_LKspell1_Actions takes nothing returns nothing
    call UnitAddAbilityBJ( 'A002', gg_unit_H00N_0336 )
    call SetUnitAnimation( gg_unit_H00N_0336, "spell channel" )
    call TriggerSleepAction( 2.00 )
    call IssueImmediateOrder( gg_unit_H00N_0336, "thunderclap", GetUnitLoc(gg_unit_H00N_0336) )
endfunction

//===========================================================================
function InitTrig_LKspell1 takes nothing returns nothing
    set gg_trg_LKspell1 = CreateTrigger(  )
    call TriggerRegisterUnitInRangeSimple( gg_trg_LKspell1, 50.00, gg_unit_H00N_0336 )
    call TriggerAddAction( gg_trg_LKspell1, function Trig_LKspell1_Actions )
endfunction

 

[TriggerHappy]

See you're in over your head just like I said.

This is such a basic change you couldn't even make because you don't know the the first thing about JASS nor does it seem like you event want to know.
You want people to write stuff for you so you can copy it in your map without even understanding what's going on.

The line should be this:

call IssueImmediateOrder( gg_unit_H00N_0336, "thunderclap")

line5: too many arguments passed to function

If you can't even read the syntax errors you shouldn't be using JASS. It clearly stated the problem..

 

[Foxace]

Best way to learn is by example, and this is exactly how learning happens most effectively. Also reading syntax errors have no use if I dont understand where stated problem is.

I changed that line removing the last argument, but trigger still doesnt do anything.

 

[TriggerHappy]

Also reading syntax errors have no use if I dont understand where stated problem is.

It said the error was on line 5?

I changed that line removing the last argument, but trigger still doesnt do anything.

Does the trigger even fire?

add BJDebugMsg("debug")'s throughout your trigger and see if any messages display. If they do, the issue is with order string.

50 is also a small range, try 90+

Best way to learn is by example, and this is exactly how learning happens most effectively

Sure it's a great way to learn, but that's not what you're doing.

 

[pOke]

lol, it says line 5, but whatever.

It would make more sense if you want to learn JASS, to read tutorials and practice on your own. Make this trigger in GUI, make sure it works how you want it to. Then convert it to JASS and interpret what you had and see how it was manipulated by the system.

Saying I want to learn, I want to learn but expecting someone to just fix your problems with no effort of your own does not seem genuine to me.

I'm not "mad" that you are posting trying to get help its just like someone with only general math knowledge does not attempt to understand Calculus. They need to build up their knowledge base before delving into the next tier, in this instance coding in JASS.

EDIT: If the trigger had errors it was likely disabled, did you re-enable it?

 

[Foxace]

Its extremely frustrating to make GUI triggers because its extremely counter-intuitive.

 

[TriggerHappy]

Its extremely frustrating to make GUI triggers because its extremely counter-intuitive.

Blindly writing nonsense in JASS in counter-intuitive.

I'm more than glad to help newbies but you're making it difficult.

This also isn't the first thread like this that you have made.

 

[pOke]

I completely disagree. It was made to be as easy for beginners to understand as possible.

In your instance trying to get your unit to cast thunderclap...

You would go to actions...

Then look for something to the effect of

Issue a Unit order with No Target

Specify the unit, specify the order "Human Mountain King Thunderclap" for your thunderclap based spell.

Seems to be very logical in my opinion.

 

[Foxace]

But if GUI trigger makes unit to cast thunderclap, then doesnt it cast the original thunderclap instead of my custom spell? how can i differentiate between ordering to cast real thunderclap and custom spell?

 

[TriggerHappy]

But if GUI trigger makes unit to cast thungerclap, then doesnt it cast the origina thunder clap instead of my custom spell? how can i differentiate between ordering to cast real thunderclap and custom spell?

You would have to give the spell a different order string.

As I said a few posts back the field is under Text - Order String in the object editor.

 

[Foxace]

As I said previously, I checked that order string command, but problem was that there are no custom spells in the list

 

[TriggerHappy]

As I said previously, I checked that order string command, but problem was that there are no custom spells in the list

There are no custom order strings, you have to re-use already created ones.

1. Go to your ability in the object editor.
2. Find Text - Order String.
3. Change the value to something that doesn't conflict with other spells the unit has.
4. Order it via triggers
   
   • Unit - issue "some spell string" to unit

 

[Foxace]

I issued order with no target and spell thunderclap, nothing happens

Trigger only has event unit enters region

 

[TriggerHappy]

I issued order with no target and spell thunderclap, nothing happens

Trigger only has event unit enters region

Like I said a few posts back (I'm turning into a broken record), add debug messages to your trigger and see if the trigger even runs.

http://www.hiveworkshop.com/forums/2455351-post12.html

You really can't expect me to help you at this point sorry im out.

 

[Maker]

Discussion can continue here: http://www.hiveworkshop.com/forums/world-editor-help-zone-98/need-example-triggers-245303/

Thread closed.