[System] CDS {Combat Data Storage}

[Magtheridon96]

This is broken. Do not use it.

ASS no longer uses this system to store data.

It still actually is functional, but assists are not retrievable when using ASS through this snippet.

/************************************************
*
*   CombatDataStorage
*   v1.4.0.0
*   By Magtheridon96
*
*   Allows the retrieval of Player Hero:
*       - Kills
*       - Deaths
*       - Suicides
*       - Denies
*       - Assists (Only with AdvancedStreakSystem implemented)
*
*   Useful for AoS maps.
*
*   API:
*   ----
*
*       function GetPlayerKillsById takes integer i returns integer
*       function GetPlayerDeathsById takes integer i returns integer
*       function GetPlayerDeniesById takes integer i returns integer
*       function GetPlayerSuicidesById takes integer i returns integer
*       function GetPlayerAssistsById takes integer i returns integer
*           - Retrieve values given a player id
*
************************************************/
library CombatDataStorage requires RegisterPlayerUnitEvent
    globals
        // DataVars
        private integer array kills
        private integer array deaths
        private integer array denies
        private integer array suicides
        // When you deny a hero, do you get a kill?
        private constant boolean DENIES_COUNT_KILLS     = false
        // When you get denied, do you get a death?
        private constant boolean DENIES_COUNT_DEATHS    = false
        // Does suicide count as a death?
        private constant boolean SUICIDE_DEATH          = true
    endglobals
    
    private function E takes nothing returns nothing
        local unit u = GetTriggerUnit()
        local player k = GetOwningPlayer(GetKillingUnit())
        local integer i = GetPlayerId(GetTriggerPlayer())
        local integer j = GetPlayerId(k)

        if IsUnitType(u,UNIT_TYPE_HERO) then
            if u == GetKillingUnit() then
                set suicides[i] = suicides[i] + 1
                static if SUICIDE_DEATH then
                    set deaths[i] = deaths[i] + 1
                endif
            elseif IsUnitEnemy(u, k) then
                set kills[j] = kills[j] + 1
                set deaths[i] = deaths[i] + 1
            else
                set denies[j] = denies[j] + 1
                static if DENIES_COUNT_KILLS then
                    set kills[j] = kills[j] + 1
                endif
                static if DENIES_COUNT_DEATHS then
                    set deaths[i] = deaths[i] + 1
                endif
            endif
        endif

        set u = null
        set k = null
    endfunction
    
    function GetPlayerKillsById takes integer i returns integer
        return kills[i]
    endfunction
    function GetPlayerDeathsById takes integer i returns integer
        return deaths[i]
    endfunction
    function GetPlayerDeniesById takes integer i returns integer
        return denies[i]
    endfunction
    function GetPlayerSuicidesById takes integer i returns integer
        return suicides[i]
    endfunction
    
    static if LIBRARY_ASS then
        private struct A extends array
            static integer array assists
        endstruct
        
        function IncreasePlayerAssistsById takes integer i returns nothing
            set A.assists[i] = A.assists[i] + 1
        endfunction
        
        function GetPlayerAssistsById takes integer i returns integer
            return A.assists[i]
        endfunction
    endif
    
    private module Init
        private static method onInit takes nothing returns nothing
            call RegisterPlayerUnitEvent(EVENT_PLAYER_UNIT_DEATH,function E)
        endmethod
    endmodule
    private struct Inits extends array
        implement Init
    endstruct
endlibrary

Feel free to comment..

 

[Bribe]

Could you please elaborate on "denies" and "suicides"? The two seem very similar to me.

 

[Magtheridon96]

A deny is when you kill your allies.
A suicide is when you kill yourself.

 

[Bribe]

While it could be useful I believe there is a native that detects player kills already, I will look at common.j again to find it. Albeit it's only one component.

 

[Magtheridon96]

While it could be useful I believe there is a native that detects player kills already, I will look at common.j again to find it. Albeit it's only one component.

I hope it doesn't exist xD

 

[Bribe]

If memory serves it has to do with the playerscore type and PLAYER_SCORE_UNITS_KILLED.

 

[Magtheridon96]

PLAYER_SCORE_UNITS_KILLED doesn't filter creep kills out so that only hero kills count though

 

[Bribe]

Then obviously yours has an advantage

 

[Magtheridon96]

Then obviously yours has an advantage

^^ Awesome

 

[tooltiperror]

>a player can only have one hero
Just make it use an indexer and make it MUI. This is just plain silly.

>function F1
>function F2
No script using names like these should be approved, ever.

set t=null

You don't need to null triggers in one time initilization.

>Alternate wrappers
Useless.

 

[Nestharus]

Yawn, JASS convention is camelcase with the first letter being lower for non constant variables >.>

PlayerDeaths -> playerDeaths

 

[Magtheridon96]

update
Now follows convention

edit
The Alternate wrappers aren't useless.
You're going to have to call "GetPlayerId(p)" one way or another.
Do you want to call it outside the system? Or do you want the system to call it for you..

 

[Bribe]

set t=null

You don't need to null triggers in one time initilization.

It's way better programming practice to null *all* handles, no matter if they are destroyed or not. The reason being is because each reference to the handle takes up some space in memory.

 

[Nestharus]

that memory space is like an integer and is reused eventually >.>

 

[Bribe]

A user from this site was experiencing some heavy lag, the only change he made was to null a player handle in a timer-loop and the lag went away. A test map should be worthwhile, I'll build one up sometime to try it for myself.

 

[Magtheridon96]

Looks like we need some Benchmarks
I like to null ALL handles to reduce as much memory as possible thus increasing performance =)

 

[Magtheridon96]

Update:

Optimized a lot.

 

[Bribe]

Denies are pretty rare these days, with anti-backstab detection. Using
this would mean you'd basically want to differentiate between denies
and normal kills, and if not then triggering this yourself wouldn't take
much effort at all.

So this has limited uses, but when it is useful it's not too terrible. The
short variable names don't do anything for the script, however, except
hinder readability. The library name is already way too long for it to
make a difference, you'd be better using Vexorian's Optimizer if you
wanted to bother, which is working mostly fine.

 

[Magtheridon96]

Ok then Bribe
You win xD

edit
Made variable names longer :/

 

[Bribe]

It is about infinite times more readable now, however I just recommend pure
JASS convention, globalsAreCamelCasedLikeThisTheSameAsLocalsWithLowerFirst.

 

[Magtheridon96]

Done =D

 

[Bribe]

This should use, at least optionally, RegisterPlayerUnitEvent.

 

[Magtheridon96]

Yeah, I'm in the process of updating all my libraries.
I'm making this compatible with AdvancedStreakSystem so you can retrieve assists too ;D

edit
Updated.
Can you change the title of the thread to "[Snippet] CombatDataStorage"? ^^

 

[Bribe]

I'm not sure what use "IncreasePlayerAssistsById" is, is this function called automatically or is the user expected to call it?

The static if LIBRARY_ASS is also broken with that globals block.

 

[Magtheridon96]

Yeah, IncreasePlayerAssistsById is only for the streak system to call (If it exists)
I'm doing this because there's no way to get player assists when using my streak system.
It already gets the kills, deaths, suicides and the 'denies', so I might as well give it the ability to get assists too.

edit

Updated.

 

[Bribe]

Approved.

 

[Magtheridon96]

This is broken as of today.
I'm going to rewrite it soon.

 

[Magtheridon96]

Graveyarding this trash.