Suck and Pull system By colourcloud

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

09:03, 7th Jun 2011
Maker: The waits make it not MUI. The "JASS" version looks just like it's converted from GUI.

 

[Fallen Solar]

If you convert GUI to JASS, it still look pretty inefficent. Both of them are not MUI and the loop trigger leaks as well.
I suggest you read these tutorials: Hashtables and MUI, Essentials Tutorial

Waits make the spell non-MUI unless you are using locals.

1/5 and vote for rejection until updated.

 

[Archangel678]

If you're going to continue with Jass, these help:

[code=jass][/code]
How to use Jass
Aligner
JassCraft

I'd also suggest that you compare your script to other Jass spells - Not the visual effects, but the scripting. There's a huge difference.

Also, this isn't a system.

 

[Jazztastic]

@Color Cloud

1. Don't ever use waits in spells unless there are local variables.

2. You have to use the destroy function for the third point inside the loop, or else it will only destroy the last point, also, you don't even use the fourth point, so deleting it is stupid.

3. Instead of assigning group to a variable, just call the magic function

• set bj_wantDestroyGroup = true

it is easier and you will only need 1 extra function instead of 2 for the group (1 to destroy group, versus 1 to create and 1 to destroy.)

4. You don't clear any memory leaks in the loop part.

5. You need to use time in a hashtable to turn on and off the loop. Use an If/Then/Else to check if the unit group has anything in it.

6. Post jass in jass tags, not trigger tags. And having the spell in jass is 100% useless if it is just converted from GUI. The reason people code in jass is because it is faster and more optimal, so if you don't use the cool things about jass, it's pointless.

Please don't make the same mistake I made and upload tons of spells that are broken. Learn from your mistakes, post frequently in the trigger help section about anything you have problems with, and heed the words of knowledgable people. Also, you really should learn hashtables, it has helped me become more creative with spells, and allowed me to create unique effects. Finally, don't feel pressured to post spells, just because you finished making them. I have about 8 finished spells just sitting on my computer, because I don't want to submit bad resources.

LEARN FROM YOUR MISTAKES! IT IS THE BEST THING YOU CAN DO

 

[SpectreD]

ok sure thanks for the advice

 

[Jazztastic]

Yeah np bro. Now go fix these spells

Like I said, learn hashtables, it will completely expand what your spells can do