[Trigger] Spell problem

[Chaosy]

I made a spell earlier today, it works fine when casting but when i try with 2 units at the same time it wont even start they do the first attack and then stop. with other words it is not mui

the spell should be teleported around the unit and attack for dmg

triggers

• Initialization
  • Events
    • Map initialization
  • Conditions
  • Actions
    • -------- to make it look good you need to change it based on wich model you use --------
    • Set KS_animation_Speed = 300.00
    • Set KS_dmg_per_attack[1] = 10.00
    • Set KS_dmg_per_attack[2] = 20.00
    • Set KS_dmg_per_attack[3] = 30.00
    • Set KS_number_of_attacks = 6
    • -------- How far from the target the unit will stand --------
    • Set KS_range = 50.00
    • -------- - --------
    • Hashtable - Create a hashtable
    • Set KS_hash = (Last created hashtable)
    • Set KS_handle[1] = (Triggering unit)
    • Set KS_handle[2] = (Picked unit)

• cast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
  • Actions
    • Set KS_time = 0.00
    • Set KS_caster = (Triggering unit)
    • Set KS_target = (Target unit of ability being cast)
    • Set KS_target_loc = (Position of KS_target)
    • Set KS_facing = ((Facing of KS_target) / 2.00)
    • Set KS_move_to_loc = (KS_target_loc offset by KS_range towards KS_facing degrees)
    • Unit - Move KS_caster instantly to KS_move_to_loc
    • Unit - Make KS_caster face KS_target over 0.00 seconds
    • Animation - Change KS_caster's animation speed to 300.00% of its original speed
    • Animation - Play KS_caster's Attack Slam animation
    • Unit - Cause KS_caster to damage KS_target, dealing KS_dmg_per_attack[(Level of (Ability being cast) for KS_caster)] damage of attack type Spells and damage type Normal
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (KS_group is empty) Equal to True
      • Then - Actions
        • Trigger - Turn on loop <gen>
      • Else - Actions
    • Set KS_attack_count = 1
    • Hashtable - Save KS_attack_count as 1 of (Key KS_handle[1]) in KS_hash
    • Hashtable - Save Handle OfKS_caster as 2 of (Key KS_handle[1]) in KS_hash
    • Hashtable - Save Handle OfKS_target as 3 of (Key KS_handle[1]) in KS_hash
    • Hashtable - Save KS_time as 4 of (Key KS_handle[1]) in KS_hash
    • Unit Group - Add KS_caster to KS_group
    • Custom script: call RemoveLocation(udg_KS_target_loc)
    • Custom script: call RemoveLocation(udg_KS_move_to_loc)

• loop
  • Events
    • Time - Every 0.01 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in KS_group and do (Actions)
      • Loop - Actions
        • Set KS_time = (Load 4 of (Key KS_handle[2]) from KS_hash)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • KS_time Less than 0.40
          • Then - Actions
            • Set KS_time = (KS_time + 0.01)
            • Hashtable - Save KS_time as 4 of (Key KS_handle[2]) in KS_hash
          • Else - Actions
            • Set KS_attack_count = (Load 1 of (Key KS_handle[2]) from KS_hash)
            • Set KS_caster = (Load 2 of (Key KS_handle[2]) in KS_hash)
            • Set KS_target = (Load 3 of (Key KS_handle[2]) in KS_hash)
            • Set KS_random = (Random integer number between 1 and 3)
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • KS_random Equal to 2
              • Then - Actions
                • Set KS_facing = ((Facing of KS_target) - 90.00)
              • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • KS_random Equal to 1
              • Then - Actions
                • Set KS_facing = ((Facing of KS_target) - 180.00)
              • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • KS_random Equal to 3
              • Then - Actions
                • Set KS_facing = ((Facing of KS_target) + 90.00)
              • Else - Actions
            • Set KS_target_loc = (Position of KS_target)
            • Set KS_move_to_loc = (KS_target_loc offset by KS_range towards KS_facing degrees)
            • Unit - Move KS_caster instantly to KS_move_to_loc
            • Unit - Make KS_caster face KS_target over 0.00 seconds
            • Animation - Play KS_caster's Attack Slam animation
            • Unit - Cause KS_caster to damage KS_target, dealing KS_dmg_per_attack[(Level of (Ability being cast) for KS_caster)] damage of attack type Spells and damage type Normal
            • Set KS_attack_count = (1 + KS_attack_count)
            • Set KS_time = 0.00
            • Hashtable - Save KS_attack_count as 1 of (Key KS_handle[2]) in KS_hash
            • Hashtable - Save KS_time as 4 of (Key KS_handle[2]) in KS_hash
            • Custom script: call RemoveLocation(udg_KS_target_loc)
            • Custom script: call RemoveLocation(udg_KS_move_to_loc)
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • KS_attack_count Greater than or equal to 6
              • Then - Actions
                • Animation - Change KS_caster's animation speed to 100.00% of its original speed
                • Unit Group - Remove KS_caster from KS_group
                • Hashtable - Clear all child hashtables of child 1 in KS_hash
                • Hashtable - Clear all child hashtables of child 2 in KS_hash
                • Hashtable - Clear all child hashtables of child 3 in KS_hash
                • Hashtable - Clear all child hashtables of child 4 in KS_hash
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (KS_group is empty) Equal to True
                  • Then - Actions
                    • Trigger - Turn off (This trigger)
                  • Else - Actions
              • Else - Actions

//slowed makers fix did it

 

[Maker]

Create an integer variable. I'll name it ID.

In cast trigger:

• Custom script: set udg_ID = GetHandleId(GetTriggerUnit())

Then save stuff like this:

• Hashtable - Save KS_attack_count as 1 of ID in KS_hash
• Hashtable - Save Handle OfKS_caster as 2 of ID in KS_hash
• ...

In looping trigger:

• Custom script: set udg_ID = GetHandleId(GetEnumUnit())

And load stuff using ID.

 

[Chaosy]

should i use the

• set udg_ID = GetHandleId(GetTriggerUnit())

in the looping trigger too? since i need to use it to save the new values there

 

[Maker]

should i use the

• set udg_ID = GetHandleId(GetTriggerUnit())

in the looping trigger too? since i need to use it to save the new values there

In looping trigger:

• Custom script: set udg_ID = GetHandleId(GetEnumUnit())

And load stuff using ID.

....

 

[Chaosy]

idiotic me

edit, omg works perfect now thanks alot maker rep +

edit 2, could you give some kind of review on it if i give you map? might upload it to the spell section sometime

 

[Maker]

edit 2, could you give some kind of review on it if i give you map?

No, sorry.

I can do a quick review:
Use 0.03 instead of 0.01
Don't clear hashtables using keys 1-4. Clear it with using the ID
Add ability being cast condition
Maybe check that the unit is alive in the looping trigger

 

[defskull]

Why did you set (Triggering unit) and (Picked unit) in the Initialization trigger ??

The variable cannot relate with the event which is Map initialization lol...

 

[Chaosy]

no i know that, but when i use the handles when saving values in the cast trigger there is a triggering unit

thats not the problem since it works

 

[mckill2009]

that's not how to do it, use Maker's answer on post #2, ID's should be saved on every cast and loop, coz its changing reference every time...
you might as well consider using Stacking(unique) ID's such as OneHash, for GUI...
and you dont need to save KS_caster coz it's already in the group and can be called via PickedUnit...

 

[Chaosy]

thanks mckill, yeah makers way works i said thanks to him in a post above. and i will take a look on the one hash in a moment.

about the store ks caster i will fix it soon

thanks again