Spell makes game crash! Why?

[MateuszD]

I made a spell that has a chance to drain life points from enemies! Sometimes when hero drains life points the game crush. Her is the Tigger i hope someone can help me.

• BloodSuck chance
  • Events
    • Unit - A unit Learns a skill
  • Conditions
    • (learned Hero Skill) equal to BloodSuck
  • Actions
    • Set TRiggeringUnit[8] = (Triggering unit)
    • Set BloodSuckChance = (Random integer number between 1 and (14 - (Level of BloodSuck for TriggeringUnit[8]
    • Set BloodSuckPercentChance = 1

[/TRIGGER]

• BloodSuck
  • Events
    • Unit -A unit is attacked
  • Conditions
    • ((Attacked unit) is A structure) equal to false
    • ((Attacked unit) belongs to an enemy of (owner of TriggeringUnit[8])) equal to true
    • ((Attacked unit) is in (Units within 900.00 of (Position of TriggeringUnit[8]))) Equal to True
  • Actions
    • Set AttackedUnit [1] = (Attacked unit)
    • Set BloodSuckChance = (Random integer number between 1 and (14-(Level of BloodSuck for TriggeringUnit[8])))
    • If (ALL Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • BloodSuckChance Equal to BloodSuckPercentChance
      • Then - Actions
        • Unit - Add Sucklife effect to TriggeringUnit[8]
        • Unit - Set level of Sucklife effect for TriggeringUnit[8] to (Level of BLoodSuck for TriggeringUnit[8])
        • Unit - Order TriggeringUnit[8] to Neutral Dark Ranger - Life Drain AttackedUnit[1]
        • Wait 10.00 seconds
        • Unit - Remove Sucklife effect from TriggeringUnit[8]
      • Else - Actions

 

[paskovich]

Well, you could make this far more efficient, and in one trigger only, WITHOUT variables, so it'll be MUI. Download spells, look at how other spell-makers create spells, and "steal" the tricks.

• BloodSuck
  • Events
    • Unit -A unit is attacked
  • Conditions
    • (Level of BloodSuck for Attacking unit) is greater then 0
  • Actions
    • If (ALL Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Random integer number between 1 and (14-(Level of BloodSuck for Attacking unit))) is equal to 1
      • Then - Actions
        • Unit - Add Sucklife effect to Attacking unit
        • Unit - Set level of Sucklife effect for Attacking unit to (Level of BLoodSuck for Attacking unit)
        • Unit - Order Attacking unit to Neutral Dark Ranger - Life Drain (Triggering unit)
        • Wait 10.00 seconds
        • Unit - Remove Sucklife effect from Attacking unit
        • Else - Actions

 

[MateuszD]

Thx but know he dont stop to cast sucklife effeckt when a trigerring unit is dead.

 

[paskovich]

Well, I only "converted" YOUR trigger, that's not my problem anymore, your trigger neither stops to cast 'sucklife'...
But because i'm so kind, i made it for you. Needs one line of custom script (jass).

• BloodSuck
  • Events
    • Unit -A unit is attacked
  • Conditions
    • (Level of BloodSuck for Attacking unit) is greater then 0
  • Actions
    • If (ALL Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Random integer number between 1 and (14-(Level of BloodSuck for Attacking unit))) is equal to 1
      • Then - Actions
        • Unit - Add Sucklife effect to Attacking unit
        • Unit - Set level of Sucklife effect for Attacking unit to (Level of BLoodSuck for Attacking unit)
        • Unit - Order Attacking unit to Neutral Dark Ranger - Life Drain (Triggering unit)
        • For each integer from 1 to 10 do Actions
          • Loop - Actions
            • Custom script: exitwhen GetUnitState(GetTriggerUnit(),UNIT_STATE_LIFE) <= 0
            • Wait 1.00 seconds
        • Unit - Remove Sucklife effect from Attacking unit
        • Else - Actions

 

[PurplePoot]

Pask, GetWidgetLife is generally better than GetUnitState ><

(just a tip)

And I think GUI has some sort of "Wait for condition, checking every n seconds"

 

[MateuszD]

thx paskovich!!! You always help me!!! thx again

 

[paskovich]

And I think GUI has some sort of "Wait for condition, checking every n seconds"

He wanted to wait for 10 seconds OR until the unit dies! This couldn't be done with 'wait for condition' i think.

 

[PurplePoot]

Ooh, 10 seconds too. Yeah, you're right there. Missed that.

But as to the GetWidgetLife thing, it is a little more code-length-friendly, and easy-on-hands-friendly ><

 

[Captain Griffen]

That won't be MUI, as the loop integer in GUI is a global.

The crash is most likely due to a feedback loop, with unit being attacked => attack => being attacked => attack, and so on and so forth.

 

[paskovich]

Or, the same with orders:
Ordered => Give a new order => Ordered => ...

Or by running the same trigger without a wait
Event - .
Cond - .
Action
-Run (This trigger)