Spell Advice Needed

[Silvenon]

Note: this is for JASSers.

I have a hero that has 5 different spells. When I was testing them all at once, I noticed that some of the spells weren't working properly. First I was surprised, because there were all working when I tested them one by one. Then I was trying to find the problem when I realized what happened. Before that, I want to make sure that everyone knows how to create a channeling JASS spell: attach stuff to the caster, mostly timer(s), then in the trigger that fires if/when the caster stops channeling, get that stuff from the caster you previously attached and destroy timer(s) etc. But here is the problem: If I attach stuff to the caster in more than one spell, FlushHandleLocals(caster) from one spell would mess up the other one's attached stuff. Does anybody know how to fix this problem?

 

[PurplePoot]

Don't attach it to the caster. Attach all the data to the trigger that detects and stops the reorder.

Oh, and don't forget to destroy your triggeraction!

 

[Silvenon]

Thanks.

Oh, and don't forget to destroy your triggeraction!

It's not what you think, it's like this:

function InitTrig_Venom_Fury takes nothing returns nothing
    local trigger t = CreateTrigger()
    local integer i = 0
    set gg_trg_Venom_Fury = CreateTrigger()
    loop
        call TriggerRegisterPlayerUnitEvent(gg_trg_Venom_Fury, Player(i), EVENT_PLAYER_UNIT_SPELL_EFFECT, null)
        set i = i + 1
        exitwhen i == bj_MAX_PLAYER_SLOTS
    endloop
    call TriggerAddCondition(gg_trg_Venom_Fury, Condition(function Trig_Venom_Fury_Conditions))
    call TriggerAddAction(gg_trg_Venom_Fury, function Trig_Venom_Fury_Actions)
    set i = 0
    loop
        call TriggerRegisterPlayerUnitEvent(t, Player(i), EVENT_PLAYER_UNIT_SPELL_ENDCAST, null)
        set i = i + 1
        exitwhen i == bj_MAX_PLAYER_SLOTS
    endloop
    call TriggerAddCondition(t, Condition(function VenomFury_StopConditions))
    call TriggerAddAction(t, function VenomFury_StopActions)
    set t = null
endfunction

So the trigger that stops the spell when stop channeling exists all the time.

Is it better to create a trigger, then destroy it each time? I'm saying that because this way, it's kinda hard/impossible to attach the stuff to that other (local) trigger. And don't worry about triggeractions/triggerconditions, I destroy them each time. (I had to add GetHandleTriggerAction/GetHandleTriggerCondition )

 

[DiscipleOfLife]

Creating one trigger each time the channeling begins sounds like the most reasonable way to go.

 

[Silvenon]

Ok, then I will do that, thanks

 

[PurplePoot]

>_>, obvious script flaw on your part

function InitTrig_Venom_Fury takes nothing returns nothing
    local trigger t = CreateTrigger()
    local integer i = 0
    set gg_trg_Venom_Fury = CreateTrigger()
    loop
        call TriggerRegisterPlayerUnitEvent(gg_trg_Venom_Fury, Player(i), EVENT_PLAYER_UNIT_SPELL_EFFECT, null)
        call TriggerRegisterPlayerUnitEvent(t, Player(i), EVENT_PLAYER_UNIT_SPELL_ENDCAST, null)
        set i = i + 1
        exitwhen i == bj_MAX_PLAYER_SLOTS
    endloop
    call TriggerAddCondition(gg_trg_Venom_Fury, Condition(function Trig_Venom_Fury_Conditions))
    call TriggerAddAction(gg_trg_Venom_Fury, function Trig_Venom_Fury_Actions)
    call TriggerAddCondition(t, Condition(function VenomFury_StopConditions))
    call TriggerAddAction(t, function VenomFury_StopActions)
    set t = null
endfunction

Oh, and grab local triggers with GetTriggeringTrigger() if you plan on cleaning them within said trigger's actions.

 

[Silvenon]

Oh, and grab local triggers with GetTriggeringTrigger() if you plan on cleaning them within said trigger's actions.

How stupid do you think I am?? Do you think I've never cleaned triggeractions before?

Thanks for the help, I really didn't see that loop thing

 

[PurplePoot]

No, I meant flushing the trigger from said trigger's actions, nothing to do with triggeractions here

Is it better to create a trigger, then destroy it each time? I'm saying that because this way, it's kinda hard/impossible to attach the stuff to that other (local) trigger. And don't worry about triggeractions/triggerconditions, I destroy them each time. (I had to add GetHandleTriggerAction/GetHandleTriggerCondition )

Oh, sorry, you were complaining about the performance about that "global" trigger (right?) (aka the trigger used for all the spells). Well, it wouldn't matter anyways, since you'd run into your initial problem again with one overall trigger.