[JASS] Sound Leak

[Geries]

How can I remove sound and handle leak after playing a sound? I tried everything I could think out but nothing worked yet D: Or sounds are leaking?

 

[Magtheridon96]

Use SoundTools for all your sound needs
All you have to do is call RunSound(yourSoundStructInstance) and you can create a sound like this: NewSound("file path", durationInMilliseconds, looping, 3D)
You won't need to call ReleaseSound unless the sound is looping and you want to terminate it =)

 

[Geries]

Maggy... I have just one question: If I have a non looping sound then your system will auto-remove it?
And wait a little and I make you mad

 

[Troll-Brain]

KillSoundWhenDone works as expected, it destroys the sound when it is finished to be played.
Now, i've heard about bugs with sounds, like it's not played if you create and play it in the same thread, or without any delay, something like that.
But i've never played that much with sounds, just enough to ensure that KillSoundWhenDone works.

 

[Dr Super Good]

I thought sound objects were resuable? If that is the case just cache each unique sound if it will be replayed in the future.

 

[Geries]

Exactly my problem is KillSoundWhenDone is not working as it should do, nor StopSound. I keep tracking handle counts, but every time I play a sound handle's count increasing. Same with your system maggy... Leaks same as my 10 line code Also you know my opinion of all vJass structs and other shitz I'd never use them

 

[Troll-Brain]

You know that a local handle variable has to be nulled ? (function parameters are not concerned by this bug)
Else you will leak an handle id when the handle will be destroyed, just as you are describing.

EDIT : Oh wait, i remember that sounds are not played if wc3 volume is disabled (tested with TriggerWaitForSound), so the sound is probably not destroyed in this case, and in any other case when the sound is not played (probably player lag, wc3 minimized, ...)

 

[Geries]

You know that a local handle variable has to be nulled ? (function parameters are not concerned by this bug)
Else you will leak an handle id when the handle will be destroyed, just as you are describing.

Of course I know and also I do remove those leaks

EDIT for your EDIT: I have sound enabled, but I think that is only for musics... I am not sure.
The problem is not that sound is not being played, problem is that it not gets removed.

 

[Troll-Brain]

EDIT for your EDIT: I have sound enabled, but I think that is only for musics... I am not sure.

Basically, if you hear the sound it should be fine.

But because the sound is a local thing, we can say that KillSoundWhenDone can't be safely used, i mean sometimes it will just not work since the sound won't be played, so yeah using a stack of sound seems the only way to go.

 

[Magtheridon96]

Maggy... I have just one question: If I have a non looping sound then your system will auto-remove it?

It will not remove it, it will recycle it so it can be reused in the future.

 

[Geries]

Warcraft will make me mad... I don't want to keep globals, nor I want to have leaks... D: Sadly I need to use globals then...

 

[Troll-Brain]

Buy several mouses and go for sc2.