somthing wrong with my trigger :/

[Anti_Bodies]

this trigger here is for an ability called Capture planet. a unit targets the planet, uses the ability and this trigger then runs to change control of the planet. however it doesnt seem to work all the time. peticulary when multiple planets are being captured at the same time, however there shouldnt be any problems because the ability takes 12 seconds to cast, and then like .5 seconds to execute. any help?

Solved

in addition, can anyone tell me what the code is so i can make trigger text look like world editor trigger text, because i have not found a BB code for that

• Events
  • Unit - A unit Finishes casting an ability
• Conditions
  • (Ability being cast) Equal to Capture Planet
• Actions
  • Unit Group - Pick every unit in (Units within 512.00 of (Position of (Casting unit))) and do (Actions)
    • Loop - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Unit-type of (Picked unit)) Equal to Planet
        • Then - Actions
          • Unit - Change ownership of (Picked unit) to (Triggering player) and Change color
        • Else - Actions
          • Do nothing

 

[PatruX]

For the BB Code question, use the [ trigger ] [ /trigger ] tags and paste your code inside.

 

[Vicboy]

• Events
  • Unit - A unit Finishes casting an ability
• Conditions
  • (Ability being cast) Equal to Capture Planet
• Actions
  • Unit Group - Pick every unit in (Units within 512.00 of (Position of (Casting unit))) and do (Actions)
    • Loop - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Unit-type of (Picked unit)) Equal to Planet
        • Then - Actions
          • Unit - Change ownership of (Picked unit) to (Owner of (Casting Unit)) and Change color
        • Else - Actions
          • Do nothing

I changed Triggering Player to Owner of Casting Unit.

BTW, you should remove leaks... No matter how small or rare this trigger is.

 

[Zack1996]

• Events
  • Unit - A unit Finishes casting an ability
• Conditions
  • (Ability being cast) Equal to Capture Planet
• Actions
  • Unit Group - Pick every unit in (Units within 512.00 of (Position of (Casting unit))) and do (Actions)
    • Loop - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Unit-type of (Picked unit)) Equal to Planet
        • Then - Actions
          • Unit - Change ownership of (Picked unit) to (Owner of (Casting Unit)) and Change color
        • Else - Actions
          • Do nothing

I changed Triggering Player to Owner of Casting Unit.

BTW, you should remove leaks... No matter how small or rare this trigger is.

Yeah, that and:
]

• Events
  • Unit - A unit Finishes casting an ability
• Conditions
  • (Ability being cast) Equal to Capture Planet
• Actions
  • Unit Group - Pick every unit in (Units within 512.00 of (Position of (Casting unit))) and do (Actions)
    • Loop - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Unit-type of (Matching unit)) Equal to Planet
        • Then - Actions
          • Unit - Change ownership of (Picked unit) to (Owner of (Casting Unit)) and Change color
        • Else - Actions
          • Do nothing

You have to change picked unit when checking the condition to matching unit.

 

[Vicboy]

Side note...


Wouldn't a condition inside the unit group trigger be better than the if condition are true...

 

[Anti_Bodies]

i guess ill just wait for you guys to make a final decision on what triggers are best for this, thanks so far thou

 

[Vicboy]

• Events
  • Unit - A unit Finishes casting an ability
• Conditions
  • (Ability being cast) Equal to Capture Planet
• Actions
  • Unit Group - Pick every unit in (Units within 512.00 of (Position of (Casting unit))) and do (Actions)
    • Loop - Actions
      • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        • If - Conditions
          • (Unit-type of (Matching unit)) Equal to Planet
        • Then - Actions
          • Unit - Change ownership of (Picked unit) to (Owner of (Casting Unit)) and Change color
        • Else - Actions
          • Do nothing

Read carefully, this is both mine and his thought...

Just use it... Picked unit and matching unit etc... owner of casting unit

 

[Anti_Bodies]

alright i will thanks (rep given out to all 3 of u)