[Snippet] Thread

[Troll-Brain]

But if he removes this fugly comment usage, it would make sense and he wouldn't bitching Cohadar's jasshelper.
It's just too much for him.

 

[Nestharus]

Fixed a problem with unsync'd code that creates threads ;o. The unit was getting created/selected for one machine before another machine, which was causing syncing problems.

 

[Nestharus]

Updated

now synchronizes all 12 players rather than just waiting for the first player to send sync request ; O.

 

[Troll-Brain]

However as said i don't what happens if a player don't load completely the game before leaving.

 

[Nestharus]

It'll still work just fine

edit
no wait, it won't ;o

hm...

i'm going to have to update the sync count in both the synced operator and the selection event

also... for the selection event, I really don't want it to fire whenever any unit is selected, but I've no choice >.<.

 

[Troll-Brain]

I thought about something else, if a such leaving player trigger the player leave event then it's easy.

 

[Nestharus]

no, because there are multiple thread instances. Would have to iterate over every thread ; \.

 

[Troll-Brain]

No, at init you check how many players there are.
And when a player leaves you just decrease this number.

And btw have you not already done something similar to handle players "PlayerUtils" something like that ?

 

[Nestharus]

That won't work because a leaving player may/may not have run a selection event (possible early fire)

Also, the leaving player may be the last one to run the selection event, in which case the synced var is never updated.

 

[Troll-Brain]

That won't work because a leaving player may/may not have run a selection event (possible early fire)

Also, the leaving player may be the last one to run the selection event, in which case the synced var is never updated.

My assumption is that the leaving player won't trigger the select event but trigger the player leave event.
If it trigger the player event then the code in the current version is fine.

 

[Nestharus]

er...

they might have *previously* done a sync event. Sync events don't all have to be done at the same time...

 

[Troll-Brain]

I don't follow you ...

 

[ck5524209]

method wait takes nothing returns nothing
            loop
                call TriggerSyncStart()
                call SelectUnit(threadSyncer, true)
                call SelectUnit(threadSyncer, false)
                exitwhen synced_p
                call TriggerSyncReady()
            endloop
        endmethod

or it may not exit loop

 

[Nestharus]

method wait takes nothing returns nothing
            loop
                call TriggerSyncStart()
                call SelectUnit(threadSyncer, true)
                call SelectUnit(threadSyncer, false)
                exitwhen synced_p
                call TriggerSyncReady()
            endloop
        endmethod

or it may not exit loop

No, adding those lines there would screw everything up : p.

 

[ck5524209]

No, adding those lines there would screw everything up : p.

But in my map it works.
If don't change it,my map will never trigger unit_select_event.I debug it.

 

[Nestharus]

Because you're using it wrong

It will break something like Network library

 

[ck5524209]

Because you're using it wrong

It will break something like Network library

In fact,I use library"GameStart" ,and I found it loops Thread.wait and can't get to line "set gameStarted = true".I tried to change method wait,and it worked.
I suggest if Thread is right,GameStart may be wrong.

 

[Nestharus]

Game Start is correct and it will wait until all players have finished loading the map.


And yes, I just looked.



The problem you speak of, of it never exiting... I've never run into that.

 

[ck5524209]

Game Start is correct and it will wait until all players have finished loading the map.


And yes, I just looked.



The problem you speak of, of it never exiting... I've never run into that.

I test it again,and it still don't work before add the two line.

 

[Nestharus]

Ok, I looked at the code and I see some possible issues : ). I'll update the library =).

 

[edo494]

just a question, why on earth you kept * * Alloc * hiveworkshop.com/forums/jass-resources-412/snippet-alloc-192348/
there? It is not used, so why having it, it may be confusing because people may think it is typo and will also use Alloc even tho it is not needed

edit: actually, there is implement Alloc in there, so Alloc should actually be required because it will not compile otherwise

 

[Berb]

Nestharus:

• Writes libraries of code and tests them for 40 hours, so that 1 person can use the code in a script for a map that 2 people will ever play.
• Writes libraries named "Thread" that don't really give you any control over threads, other than one specific scenario that, as mentioned, 2 people have ever encountered.
• Claims that he tests his code "hardcore" and there is no probability that it will not work.
• Discourages people from testing his code (that has been hardcore tested) only to find an "issue" somewhere in the code.

What a joke.

 

[Nestharus]

I did test this a lot... I had 0 issues with it and I tested it for 2 days straight. I don't know why people are encountering problems in Thread, but I do see some weird code in there, so I'll rewrite some of it to hopefully fix the problem. I'm still encountering 0 issues.

 

[Bribe]

Hence, encouraging others to test your code for you should be not only a normal practise for you (and everyone), but also that you show gratitude when someone points out your imperfections or unnecessary features and optimizations.

 

[Nestharus]

0 errors, this runs correctly >.>


Are you sure that you tested it in a synchronous thread? The thread must be synchronous.


This code works perfectly

function BooBoo takes nothing returns nothing
    local Thread thread = Thread.create()
    
    if (GetLocalPlayer() == Player(0)) then
        call thread.sync()
    endif
    
    call thread.wait()
    
    call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60,"hi")
endfunction

struct Tester extends array
    private static method onInit takes nothing returns nothing
        call ExecuteFunc("BooBoo")
    endmethod
endstruct

Not ganna fix something that's not broken, lol

 

[Frotty]

nvm tardy moment

 

[Nestharus]

Updated for proper initialization