Simple Rolling System

[Lord_Earthfire]

The idea for the System is actually ok, but i think there are some flaws in this system.
Firstly, the item can just be picjed up, making the reason why you roll for it pretty nuch obsolete, because then the fastest one gets it (e.g. thats the case in Diablo 2)
When a Unit gains the item and drops it, anyone else can pick it up easiely. Or roll for it, for thst matter.

So what is firstly needed is any kind of saving system for the ownership of an item.


Secondly, you quite sigmificantly shorten the code of the Winning Event by using a loop and Arrays.

Eg:

Set Winning.Player = 0.

For each Loop.Integer from 1 to 12, do actions:
If Player.Roll[Loop.Integer] greater than Player.Roll[Winning.Player]
Then do:
Set Winning.Player = Loop.Integer

Arrays could also be used to unify all the Roll-Trigger into a single one.

Thirdly, the action of the kind:
Item - Move rolled_item to (Position of rolling_green)
Are leaking a location (Position of rolling_green)

The last thing that can be changed is making some Initialisation variables, so you can adjust the System to your liking. Like storing which spell is the roll spell or how long does the timer last. It makes implenenting the system much easier.

Overall, i recommend that you keep working on the system, because it got potential. Try to look up Tutorials for the use of arrays, loops and memory leaks, so you can grab a grasp of what can be done.
If yoz got questions, dont scare away from bringing them up in the Trigger help zone .

By the way, im currently on the mobile phone, so sorry if this text isnt nicely formated and the help in the coding examples are quite short.

 

[Tiagomrorais]

Thanks very much for the reply, i'll be working on the leaks arrays and configurable initialisation, and reguarding the player picking up the item, if you test it you will notice that even if someone loots the item if its beeing rolled, after the roll the item aways goes to the victory player, also if you want a RPG game you could put the itens into a unreachable place, so only trough rolls you could get the itens so i dont think that is a problem, but i'll see what i can do.

 

[Lord_Earthfire]

Well, this only happens when someone rolls the item before someone rolls it. It is circumventable like you said with unreachable places, but it is a suggestion take it as user friendly as possible.

You can possibly make it optional by using the initialisation variables.

 

[Tiagomrorais]

Thanks Very much for the suggestions, after learning a bit of arrays i've seen how much better and easier it is, and how much that will make all my maps better! Remade the system, and it works.... the only thing i could not make was the lock item thing for i dont know how to do that...

 

[Tank-Commander]

Some quick notes:
- You can use triggering unit instead of casting unit
- You need a consistent prefix (at least 3 characters long) for all your variables
- This system doesn't resolve equal rolls properly (player 1 will always win on an 100 roll regardless of if every other player also rolls an 100)
- You shouldn't destroy "last created timer window" you need to destroy the timer window used by the system specifically otherwise you'll get system collisions
- Use your references more, e.g. rolled_item is stored but when you want to get the name you don't reference that variable and instead use target item of ability being cast again

 

[Tiagomrorais]

Fixed the things Tank-Commander asked and waiting for review!

 

[DD_legionTN]

Not a bad idea, but there are some flaws you will need to fix for this system.

Need Fix :
1. If player red rolls 10, player blue rolls 10, and another player rolls 50, the result will still be draw.
2.

• Game - Display to (All players matching ((Owner of (Triggering unit)) Equal to (Matching player))) the text: Wait for the curren...

can just be

• Game - Display to (Player group((Owner of (Triggering unit)))) the text: Wait for the curren...

But player group would leak, remember to clear the leak.
3. You might need to store repeated function calls into a temporary variable, not only for speed gaining, but for readability, optimizing and also develop a good habit.

Suggestions :
1. Roll result is calculated after the timer expired, maybe you could change it to after all existing player completed the rolls, directly calculate the result and give the item to winner. If you consider doing this, then you may need to implement "Give Up Roll" as there may present player wouldn't need or wouldn't want the item.
2. Perhaps adding that to enable various multiple rolls occurring at the same time for different items, but this would change the system drastically.