Script not working?

[Arad MNK]

Hey there hive! I Hope you have a nice day.
It's the second day I'm trying to learn some ways to write scripts, So I'm a n00b.
Anyways, on one of my JavaScript Scripts, I encountered a Problem:

The main Idea is supposed to be Something like Hidden tags, To show screenshots when a button is clicked, and Hide when clicked again. I Used some variables and If/then/elses, they didn't work out... So any help would be appreciated.

Code

The button things

<button onclick="displayScreenshots()">Screenshots</button>

The script:

function displayScreenshots() {
    var boolScreenies = "false";
    var ScreenshotString;
    if (boolScreenies = false) {
         boolScreenies = "true";
         ScreenshotString = "Daiee"
    } else {
         boolScreenies = "false";
         ScreenshotString = "";
    }
    document.getElementById("ScreenshotsHere").innerHTML = ScreenshotString;
}

And don't hurt me, I'm a noob

I also tried inspecting the Hidden tags in the Hive, understood Nothing

 

[GhostWolf]

You have three different errors.

First of all, you are mixing the assignment operator (=) and the equality operator (==, but you'd usually want to use ===, to be extra safe).

The second issue is that you are using a string, but comparing it to a boolean.
"false" is a string, false is a boolean.

Finally, the last error is a logical one - you are checking if a variable you just set at the beginning of the function call is a certain value.
You just set it - the value will always be "false".
You probably meant to use a global variable, just declare it outside of the function.

With all of these changes, it should be something like this:

var boolScreenies = false;

function displayScreenshots() {
    var ScreenshotString;
	
    if (boolScreenies === false) {
         boolScreenies = true;
         ScreenshotString = "Daiee";
    } else {
         boolScreenies = false;
         ScreenshotString = "";
    }
	
    document.getElementById("ScreenshotsHere").innerHTML = ScreenshotString;
}

 

[Arad MNK]

Wow Thanks GhostWolf, +Rep for you
It worked

 

[andreasaspenberg]

think this is in the wrong forum.

 

[GhostWolf]

Uhm, why was this moved from the Programming forum?

 

[Arad MNK]

Was this at the Programming forum? I posted this on Computer tech...

Anyway, this was solved Long ago.

 

[GhostWolf]

Oh, my bad.