[JASS] Rounding Code Errors

[FelFox]

I was trying to write a function to round out numbers, and I came up with this:

function RoundTo takes real roundee, integer decimalplace returns integer rounded
local string a = R2S(roundee)
local string b
local integer product
if S2I(Substring( a, StringLength(a), StringLength(a) )) >=6 then
set b = SubString( a, 1, StringLength(a)-decimalplace-1 )+I2S(S2I(Substring( a, StringLength(a)-decimalplace, StringLength(a)))+1)+"0"
else
set b = Substring( a, 1, StringLength(a)-decimalplace ) +"0"
endif
set product = S2I(b)
return product
endfunction

It keeps giving me a syntax error on the first line, and I can't figure out why. Because of this, I have no clue whether it will work or not. Help!!!

 

[wyrmlord]

It keeps giving me a syntax error on the first line.

That's right. You only specify a return type, not a name for it. Think for a second, what's the point in having the return value have a name? For the parameters, it's so you can refer to them.

As for some further help, what are you trying to do with that function? If you're trying to round a real value properly, just add .5 to it and convert it to an integer. Also, you're using the SubString function incorrectly. You're using it like SubStringBJ, you need to subtract 1 from the first value instead.

 

[paskovich]

Yeah, correct round function:

function Round2I takes real r returns integer
return R2I(r+.5)
endfunction

And yyour script won't work, as you're trying to round a real, with decimals to an integer! Make it return a real instead!

 

[FelFox]

Thanks I thought I got something wrong.