[Trigger] Random Hero Problem

[Jamal XVI]

IMG2

This code supose to make a random hero, but it doens't.Every time it's get exactly the same number and same hero.I do no what to do,
Thanks At All,
Jamal XVI

 

[Arhowk]

https://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/how-easily-post-triggers-163285/

 

[HesitationSnow]

It is getting random, test map is not.
File -> Preferences -> Test Map -> Untick "Used Fixed Random Seed".

 

[Maker]

Here's a good method of not getting the same hero twice:

• Actions
  • Set random = (Random integer number between 1 and MAX)
  • Set pick = Bonus[random]
  • Unit - Create units[pick]
  • Set units[pick] = units[MAX]
  • Set MAX = (MAX - 1)

 

[defskull]

@Maker
By using that algorithm, ain't that method disturbs the original order of the array (not that this does not appeal to the thread's topic) ?

Let's say we have 5 values from a single array;
Number[1] = 1
Number[2] = 2
...
Number[5] = 5

The order would be: 1, 2, 3, 4, 5.

Let's take your algorithm into actions and let's say the random is 3, therefore;
Number[3] is 3, right ?

Then;
Number[3] = Number[5] (since 5 is the max)

The order now would be;
1, 2, 5, 4, 5.

Then;
Max = Max - 1

The order now would be;
1, 2, 5, 4.

Is this the correct tracing of values, right ?

 

[Maker]

^Yes, that is how it works.

 

[Starquizer]

May be this "system-ling" could be of help.

 

[Maker]

@Starquizer, using the method I posted, it could be as simple as this. Your method does unnecessary loops.

Trigger

• Untitled Trigger 001
  • Events
    • Player - Player 1 (Red) skips a cinematic sequence
  • Conditions
  • Actions
    • -------- -------------------------------------------------- --------
    • -------- Initializes desired numbers --------
    • -------- -------------------------------------------------- --------
    • For each (Integer A) from 1 to 16, do (Actions)
      • Loop - Actions
        • Set itaken[((Integer A) + 16)] = (Integer A)
    • -------- -------------------------------------------------- --------
    • -------- Randomizes the order of numbers --------
    • -------- -------------------------------------------------- --------
    • For each (Integer A) from 1 to 16, do (Actions)
      • Loop - Actions
        • Set i = (Random integer number between (Integer A) and 16)
        • Set itaken[(Integer A)] = itaken[(i + 16)]
        • Set itaken[(i + 16)] = itaken[((Integer A) + 16)]
    • -------- -------------------------------------------------- --------
    • -------- Prints the numbers --------
    • -------- -------------------------------------------------- --------
    • For each (Integer A) from 1 to 16, do (Actions)
      • Loop - Actions
        • Game - Display to Player Group - Player 1 (Red) for 30.00 seconds the text: (String(itaken[(Integer A)]))

 

[Starquizer]

@Maker, awesome, thanks

 

[defskull]

I just want to share to you guys how to remove an element from an array without disturbing its order (but I guess it won't be used in this case - since order does not matter in your case - perhaps some other time ?)

• Setup
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Set Number[1] = 1
    • Set Number[2] = 2
    • Set Number[3] = 3
    • Set Number[4] = 4
    • Set Number[5] = 5
    • Set Max = 5

• Remove Element
  • Events
    • Player - Player 1 (Red) skips a cinematic sequence
  • Conditions
  • Actions
    • Set Random = (Random integer number between 1 and Max)
    • Game - Display to (All players) the text: (|cffffcc00 + ((String(Random)) + |r))
    • Set Max = (Max - 1)
    • For each (Integer LoopingInteger) from Random to Max, do (Actions)
      • Loop - Actions
        • Set Number[LoopingInteger] = Number[(LoopingInteger + 1)]
    • For each (Integer LoopingInteger) from 1 to Max, do (Actions)
      • Loop - Actions
        • Game - Display to (All players) the text: (String(Number[LoopingInteger]))

This will remove an element from an array without disturbing its order.

 

[Jamal XVI]

Solved

@HesitationSnow
This is My problem!Thanks at all!
@Maker && @defskull && @Starquizer
The solutions you proposed are exelent, may i change my system.Thanks at all!


+Rep all you guys