[JASS] Problems with condition

[Vulcano]

When i use

    private function isUnitAlly2 takes nothing returns boolean
        return IsUnitOwnedByPlayer(GetFilterUnit(), Player(11)) or IsUnitOwnedByPlayer(GetFilterUnit(), Player(12))
    endfunction

it never returns true, while there are darkgreen and brown units

 

[Deaod]

    private function isUnitAlly2 takes nothing returns boolean
        return GetOwningPlayer(GetFilterUnit())==Player(11)) or GetOwningPlayer(GetFilterUnit())==Player(12))
    endfunction

Try that.

 

[Vulcano]

Doesn't work
And this used to work pre 1.24 but now it always return true:

private function isUnitAlly takes nothing returns boolean
    return IsUnitAlly(GetFilterUnit(), GetOwningPlayer(GetSpellTargetUnit())) and (GetFilterUnit() != GetSpellTargetUnit())
endfunction

I hope i just made a stupid mistake, i don't want all my conditions with loads of if's in it.

EDIT: There aren't waits before this is called.

 

[Child_0f_Bodom]

local integer player_id_1 = GetPlayerId(GetOwningPlayer(unit1))
return i == 10 or i == 11

In JASS player 1 is player 0, player 2 is player 1, etc...

 

[Vulcano]

ok, the first one now works but the second one still returns true, also on units owned by red. I changed the second one:

return (GetOwningPlayer(GetFilterUnit())==Player(10) or GetOwningPlayer(GetFilterUnit())==Player(11)) and (GetFilterUnit() != GetSpellTargetUnit())

BTW: ogame is boring, i played it 3 months, stopped playing, started again, played 6 months and now i stopped with it again. Top 10 players keep crashing you if you don't come online each day to fleetsave

EDIT: SOLVED, it was another stupid mistake :s, i was using a BJ that destroyed the boolexpr(which was stored in a global)

EDIT2: +rep all, btw COB, your in my map credits for you hidden resource tutorial , i like the car models