Picked Unit After Set Unit Group Variable - better way to do this?

[Gnuoy]

Is there a better way to do this?

• Trigger
  • Events
    • x
  • Conditions
    • y
  • Actions
    • Custom script: call DestroyGroup(udg_Units_Yellow)
    • Set VariableSet Units_Yellow = (Units owned by Player 5 (Yellow).)
    • Unit Group - Remove Yellow_Hero from Units_Yellow.
    • Unit Group - Remove Unit_Yellow_Altar from Units_Yellow.
    • Unit Group - Pick every unit in Units_Yellow and do (Unit - Change ownership of (Picked unit) to Player 21 (Coal) and Change color)

 

[Daffa]

The DestroyGroup should be at the end of the trigger. In this regard, there's nothing much of improvement I can think of for this trigger. However, if this trigger is repeated multiple times, ideally a loop can be used to reduce trigger repetition.

 

[Gnuoy]

picked units does not create a Unit Group Object[?] because it's set to a variable and not something like <(Units owned by Player 5 (Yellow).)>

so, no need to do <set bj want destroy trigger> or anything further besides call DestroyGroup?

is that right?

 

[Uncle]

picked units does not create a Unit Group Object[?] because it's set to a variable and not something like <(Units owned by Player 5 (Yellow).)>

so, no need to do <set bj want destroy trigger> or anything further besides call DestroyGroup?

is that right?

Yes, that's correct. With this setup the Variable creates the Unit Group instead of the Pick Every Unit function.

The only way to keep track of and later on Destroy a newly created Unit Group is if you store it as a Variable. If you create the Unit Group inside of the Pick Every Unit function like so:

• Unit Group - Pick every unit in (Units owned by Player 5) and do...

Then you won't have access to the Unit Group (Units owned by Player 5) and you won't be able to Destroy it.

Note that Setbjwantdestroygroup is just another method used for destroying Groups. It's not as safe as using a Variable though so I'd avoid using it.

 

[Razorclaw_X]

You don't need to Destroy a Global variable (although in this case you should Clear it first)

 

[Gnuoy]

Thank you all!

@Uncle - you could destroy the picked unit group not set to a variable with the <set bj want destroy variable> command? but no other way?

@Razorclaw_X - call DestroyGroup will delete the Global Variable Object, making it unable to be set again? also potentially causing a game crash if a later trigger tries to set a variable that's been destroyed? So in this case I NEED to do Clear group, and NOT Destroy group.

 

[Uncle]

Thank you all!

@Uncle - you could destroy the picked unit group not set to a variable with the <set bj want destroy variable> command? but no other way?

@Razorclaw_X - call DestroyGroup will delete the Global Variable Object, making it unable to be set again? also potentially causing a game crash if a later trigger tries to set a variable that's been destroyed? So in this case I NEED to do Clear group, and NOT Destroy group.

You can either Fill/Clear the group or Create/Destroy the group. Create/Destroy is perfectly fine and it's what you'll see used majority of the time in GUI triggers like yours.

Although, unless I'm mistaken, this line of code will ALWAYS create a new unit group:

• Set VariableSet Units_Yellow = (Units owned by Player 5 (Yellow).)

So the Fill/Clear method would leak a Unit Group each time the trigger runs beyond the first.

Also, you can't destroy a "global variable object" through code. What you can do is destroy the thing that it's pointing to.

And <set bj want destroy> can be set to True which will tell the next group creating function to destroy the group when it's finished. But there's a lot of posts on Hive about people having issues with it, so I wouldn't use it unless you're certain it's safe.