Odd

[Deleted member 219079]

• freakySound
  • Events
    • Player - Player 1 (Red) skips a cinematic sequence
  • Conditions
  • Actions
    • Player Group - Pick every player in alivePlayers and do (Actions)
      • Loop - Actions
        • Set pl = (Picked player)
        • Custom script: if GetLocalPlayer() == udg_pl then
        • Sound - Play freakySound <gen>
        • Custom script: endif
        • Set b = False
        • Set ug = (Units currently selected by pl)
        • Unit Group - Pick every unit in ug and do (Actions)
          • Loop - Actions
            • Game - Display to (All players) the text: asdf
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Picked unit) is A structure) Equal to False
                • b Equal to False
              • Then - Actions
                • Game - Display to (All players) the text: lol
                • Set b = True
                • Custom script: call customFunctions_SpawnText_Simple(GetEnumUnit(),"What is this feeling...")
              • Else - Actions
        • Custom script: call DestroyGroup(udg_ug)

Doesn't say asdf, or lol... But plays the sounds. And this trigger works fine:

• Untitled Trigger 002
  • Events
    • Player - Player 1 (Red) types a chat message containing asdf as An exact match
  • Conditions
  • Actions
    • Set ug = (Units currently selected by Player 1 (Red))
    • Unit Group - Pick every unit in ug and do (Actions)
      • Loop - Actions
        • Custom script: call customFunctions_SpawnText_Simple(GetEnumUnit(),"What is this feeling...")

Must be something stupid I missed, I can't just see it myself, so tired lol, plz help meh...

 

[Deleted member 219079]

function GetUnitsSelectedAll takes player whichPlayer returns group
    local group g = CreateGroup()
    call SyncSelections()
    call GroupEnumUnitsSelected(g, whichPlayer, null)
    return g
endfunction

Doesn't this leak a group anyway? Didn't know bjasses had leaks in them

Anyway help me fix this, irritates how I can't see it

 

[IcemanBo]

Is playergroup alivePlayersbefore set before?

And each function may leak. Also those by blizzard are not all leakfree.

 

[Deleted member 219079]

It works because I can hear the sound, that's why it is so odd..

 

[IcemanBo]

Can you attach your map?

 

[Deleted member 219079]

Here.

 

[Ceday]

Put sound effect action to where message action is?It surely won't work.

 

[Deleted member 219079]

Eh what's your point? :/

Edit:

• Untitled Trigger 002
  • Events
    • Player - Player 1 (Red) types a chat message containing asdf as An exact match
  • Conditions
  • Actions
    • Custom script: if GetLocalPlayer() == Player(0) then
    • Sound - Play freakySound <gen>
    • Custom script: endif
    • Set ug = (Units currently selected by Player 1 (Red))
    • Unit Group - Pick every unit in ug and do (Actions)
      • Loop - Actions
        • Custom script: call customFunctions_SpawnText_Simple(GetEnumUnit(),"What is this feeling...")

this works too

 

[Ceday]

No, put sound effect NEAR game message.

• freakySound
  • Events
    • Player - Player 1 (Red) skips a cinematic sequence
  • Conditions
  • Actions
    • Player Group - Pick every player in alivePlayers and do (Actions)
      • Loop - Actions
        • Set pl = (Picked player)
        • Set b = False
        • Set ug = (Units currently selected by pl)
        • Unit Group - Pick every unit in ug and do (Actions)
          • Loop - Actions
            • Game - Display to (All players) the text: asdf
            • Custom script: if GetLocalPlayer() == udg_pl then
            • Sound - Play freakySound <gen>
            • Custom script: endif
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Picked unit) is A structure) Equal to False
                • b Equal to False
              • Then - Actions
                • Game - Display to (All players) the text: lol
                • Set b = True
                • Custom script: call customFunctions_SpawnText_Simple(GetEnumUnit(),"What is this feeling...")
              • Else - Actions
        • Custom script: call DestroyGroup(udg_ug)

 

[IcemanBo]

Yo, I made short tests. Seems it doesnt work in player group. If you remove this "Pick every player..." it worked for me. Sorry don't have more time but you can go on testing, and I will look at this thread tomorrow.

 

[Deleted member 219079]

• freakySound
  • Events
    • Player - Player 1 (Red) skips a cinematic sequence
  • Conditions
  • Actions
    • Player Group - Pick every player in alivePlayers and do (Actions)
      • Loop - Actions
        • Set pl = (Picked player)
        • Trigger - Run fs plLoop <gen> (ignoring conditions)

• fs plLoop
  • Events
  • Conditions
  • Actions
    • Custom script: if GetLocalPlayer() == udg_pl then
    • Sound - Play freakySound <gen>
    • Custom script: endif
    • Set b = False
    • Set ug = (Units currently selected by pl)
    • Unit Group - Pick every unit in ug and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked unit) is A structure) Equal to False
            • b Equal to False
          • Then - Actions
            • Set b = True
            • Custom script: call customFunctions_SpawnText_Simple(GetEnumUnit(),"What is this feeling...")
          • Else - Actions
    • Custom script: call DestroyGroup(udg_ug)

this works, somehow in player groups it won't work...

SOLVED