[JASS] Noobalicious question

[DistantHaze]

This trigger creates a leaderboard, but doesn't add the players to it as needed. What am I doing wrong here?

function GameStart_Action01 takes nothing returns nothing
    local integer Pnum = 1
    local player Plyr
    local string Pnam
    local leaderboard Lb = CreateLeaderboard ()
    call DisableTrigger (gg_trg_GameStart)
    call LeaderboardSetLabel (Lb, "Score")
    set udg_Leaderboard = Lb
    loop
        exitwhen Pnum == 9
        set Plyr = Player (Pnum)
        if GetPlayerSlotState (Plyr) ==  PLAYER_SLOT_STATE_PLAYING and GetPlayerController (Plyr) == MAP_CONTROL_USER then
            set Pnam = GetPlayerName (Plyr)
            call LeaderboardAddItem (Lb, Pnam, 1, Plyr)
            call PlayerSetLeaderboard (Plyr, Lb) 
        endif
        set Pnum = Pnum + 1
    endloop
    call LeaderboardDisplay (Lb, true)
    call DestroyTrigger (gg_trg_GameStart)
endfunction

function InitTrig_GameStart takes nothing returns nothing
    set gg_trg_GameStart = CreateTrigger ()
    call TriggerAddAction (gg_trg_GameStart, function GameStart_Action01)
endfunction

 

[paskovich]

Can you leave a space between the function name and the first bracket?
like:
call DoNothing ()
instead of:
call DoNothing()

Anyway, be sure that the trigger runs on map init!

 

[DistantHaze]

I was under the impression that the spaces don't register to JASS anyway. Besides, this trigger DOES create a leaderboard; it just doesn't add the players to it.

 

[PurplePoot]

It doesn't matter, he's just being picky

Try putting a debug message inside the loop (after the exitwhen) to see if it even gets there, and another inside the if-statement to see if it gets THERE.

 

[DistantHaze]

Adding a few of text into the trigger now displays numbers 1 - 8 in sequence, and a message that the loop has finished. Still, however, the players are not added into the leaderboard.

What else is missing?

 

[PurplePoot]

Look into this function

function LeaderboardResizeBJ takes leaderboard lb returns nothing
    local integer size = LeaderboardGetItemCount(lb)

    if (LeaderboardGetLabelText(lb) == "") then
        set size = size - 1
    endif
    call LeaderboardSetSizeByItemCount(lb, size)
endfunction

GUI seems to call it after LeaderboardSetItemBJ