Need help with "For Each Integer A"

[X-Death]

Does this have the same effect as...

• Unit - Create 1 Knight for Neutral Passive at (Center of Region <gen>) facing 180.00 degrees
• For each (Integer A) from 1 to 4, do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Hero[(Integer A)] Equal to No unit
      • Then - Actions
        • Set Hero[(Integer A)] = (Last created unit)
      • Else - Actions

This?

• Unit - Create 1 Knight for Neutral Passive at (Center of Region <gen>) facing 180.00 degrees
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • Hero[1] Equal to No unit
  • Then - Actions
    • Set Hero[1] = (Last created unit)
  • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Hero[2] Equal to No unit
      • Then - Actions
        • Set Hero[2] = (Last created unit)
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Hero[3] Equal to No unit
          • Then - Actions
            • Set Hero[3] = (Last created unit)
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • Hero[4] Equal to No unit
              • Then - Actions
                • Set Hero[4] = (Last created unit)
              • Else - Actions

What I'm trying to do is. I want to save Hero into a variable. And I want it to check 1-4 in order, and then stop once it finds a variable that has 'No Unit' set. I'm worried with Each Integer A it will assign Hero 1-4 for all of them.

 

[IcemanBo]

Loop would not stop by itself, even you set Hero[1] to your created unit.

You can add a "Custom script: exitwhen true" to your action, if condtion matches. Then loop will immediatly exit after this line. (so add it after your Set-action)

 

[Frotty]

You were right, it would.
You can fix this by adding a custom-script in the THEN block after "Set Hero ..." with this content:
"exitwhen true"
(without the " ").
This will make your loop stop once you reached the THEN-block once.

e: 2 slow :/

 

[deathismyfriend]

Example 2 is slightly faster but at a cost for trigger size.
The loop looks a lot better and is easier to manage.
Using the exitwhen will make it faster but it will stop the loop from running through all 4 heroes.

Also never use integer A / B.

 

[JaysProjex]

Edit: Nvm

 

[deathismyfriend]

Well his method above is fine. But I would stick with the loop as it is cleaner.
Also you leak locations.

 

[JaysProjex]

Also you leak locations.

The unit created was of his example so I was just using it so he knows where to start, I wasnt going full out on it but yes it does

 

[deathismyfriend]

The unit created was of his example so I was just using it so he knows where to start, I wasnt going full out on it but yes it does

If you make something that leaks or is not efficient you should always say so. It makes it so that newer people or people looking at this don't get confused thinking that that is a leak free efficient trigger.