Naruto Spell Pack

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

21st May 2012
Bribe: I will review your spell once you fix your indentation.

 

[Magtheridon96]

• The indentation is terrible, you need to indent your code so people could read it easily.
• You shouldn't be using a loop to create units and order them. Orders are very slow in Warcraft III,
  so in an actual map, you're going to find that the dummies are going to move and stop and move and stop and move and etc...
• You should make the Ability and Buff Ids configurable.
• When you create a local and set it to something, it would be more efficient to use that local instead of referencing the same
  thing again. For example, in the trigger "Rasengan", you declared a local unit c, set it to triggering unit, and in the if block, you
  used GetTriggerUnit() instead of c.

 

[Almia]

can you show us the code/triggers???

 

[bowser499]

1. Use IssueTargetOrderById instead of IssueTargetOrder. Order ID an be determined using ConvOrder.
2. Use .025 instead of 0.025.
3. Make the parameters of the spells configurable.
4. SR must have appropriate prefix.
5. You use GetUnitState(d,UNIT_STATE_LIFE). GetWidgetLife(d) would be much better.
6. Null d only in the end of the trigger.
7. Where is the code for 4th spell?

 

[Adiktuz]

This lacks the easeness of configuration for a public resource...